From owner-svn-src-all@freebsd.org Thu Dec 1 20:34:28 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D4D9C60101; Thu, 1 Dec 2016 20:34:28 +0000 (UTC) (envelope-from tsoome@me.com) Received: from st13p35im-asmtp003.me.com (st13p35im-asmtp003.me.com [17.164.199.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 462661654; Thu, 1 Dec 2016 20:34:28 +0000 (UTC) (envelope-from tsoome@me.com) Received: from process-dkim-sign-daemon.st13p35im-asmtp003.me.com by st13p35im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OHI00M00WV9EX00@st13p35im-asmtp003.me.com>; Thu, 01 Dec 2016 20:34:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=4d515a; t=1480624461; bh=mKPyQ53cBWg8XSE9UfO3r06Qs21e0rAaVuQsNM40nHU=; h=Content-type:MIME-version:Subject:From:Date:Message-id:To; b=LCwZwSkZP2RU6/3ZRczYMcV6Hm4j30c/uSIoLWhOTSYBNeeSXErMi67E4QsjtuXGP FcfVkQZMmh42gRt4C+6QHVHYhpPWfcCwOe2X4nOEN4xFZ6kfB+axeNXxXWoUnCkxYl +sQEdI7oihRs9Uu5yHYO3BGYRdEuIpjcxYhmkN/lYAoWDE/GS/CHlpu2r71paqdCuq bt7bmj5VRsrBlT6DE+vs0GH9oerVb4M1e4etPu/vcm7wTNh+exQrx/TL6MF9VI9Ua7 SOtBt0kKlWfI10NF4BgJitxT8TlKDSZqK51ImipMRroANNFp8/Vh7lG9kgXA9QmQ9Q ADDArprOvq2eg== Received: from nazgul.lan (220-90-235-80.dyn.estpak.ee [80.235.90.220]) by st13p35im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OHI00JOUX563400@st13p35im-asmtp003.me.com>; Thu, 01 Dec 2016 20:34:20 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-01_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1612010334 Content-type: text/plain; charset=utf-8 MIME-version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: svn commit: r309368 - stable/11/sys/boot/zfs From: Toomas Soome In-reply-to: <186048AF-0A74-4DCD-8A54-1DCE26CCE9D3@bluezbox.com> Date: Thu, 01 Dec 2016 22:34:17 +0200 Cc: Toomas Soome , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-transfer-encoding: quoted-printable Message-id: <75AD339A-FECF-4C82-ADF1-FACDF0FDD2B6@me.com> References: <201612011906.uB1J69XK076481@repo.freebsd.org> <186048AF-0A74-4DCD-8A54-1DCE26CCE9D3@bluezbox.com> To: Oleksandr Tymoshenko X-Mailer: Apple Mail (2.3251) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 20:34:28 -0000 > On 1. dets 2016, at 22:01, Oleksandr Tymoshenko = wrote: >=20 >=20 >> On Dec 1, 2016, at 11:06 AM, Toomas Soome wrote: >>=20 >> Author: tsoome >> Date: Thu Dec 1 19:06:09 2016 >> New Revision: 309368 >> URL: https://svnweb.freebsd.org/changeset/base/309368 >>=20 >> Log: >> MFC r308776 >>=20 >> loader: zfs toplevel vdev must have spa set. >>=20 >> PR: 214375 >> Reported by: lstewart >> Reviewed by: allanjude, imp >> Approved by: allanjude (mentor), imp (mentor) >> Differential Revision: https://reviews.freebsd.org/D8487 >=20 > Hi Tom, >=20 > Looks like this commit breaks the build: >=20 > In file included from = /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfs.c:49: > /src/FreeBSD/11/sys/boot/efi/loader/../../zfs/zfsimpl.c:1021:13: = error: no membe > r named 'spa' in 'struct vdev' > top_vdev->spa =3D spa; > ~~~~~~~~ ^ >=20 >=20 >=20 Yes, I am so sorry for this confusion, I did back it out; somehow the = impression was the skein boot support is already in 11=E2=80=A6 my = apologies. rgds, toomas=