Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Aug 2016 15:10:13 +0000
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        "Jean-S??bastien P??dron" <dumbbell@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, "Konstantin Belousov" <kostikbel@gmail.com>
Subject:   Re: svn commit: r303890 - in head/sys: contrib/ncsw/user/env contrib/octeon-sdk dev/auxio dev/bktr dev/e1000 dev/ixgb dev/ixgbe dev/ixl dev/netmap dev/pci dev/sound/sbus dev/tpm kern mips/nlm/dev/net m...
Message-ID:  <18158D1D-52E7-4894-A606-6672E81A1D45@FreeBSD.org>
In-Reply-To: <20160810110229.GK83214@kib.kiev.ua>
References:  <201608091932.u79JW6Y6069448@repo.freebsd.org> <20160810110229.GK83214@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On 10 Aug 2016, at 11:02, Konstantin Belousov wrote:

> On Tue, Aug 09, 2016 at 07:32:06PM +0000, Jean-S??bastien P??dron =

> wrote:
>> Author: dumbbell
>> Date: Tue Aug  9 19:32:06 2016
>> New Revision: 303890
>> URL: https://svnweb.freebsd.org/changeset/base/303890
>>
>> Log:
>>   Consistently use `device_t`
>>
>>   Several files use the internal name of `struct device` instead of
>>   `device_t` which is part of the public API. This patch changes all
>>   `struct device *` to `device_t`.
>>
>>   The remaining occurrences of `struct device` are those referring to =

>> the
>>   Linux or OpenBSD version of the structure, or the code is not built =

>> on
>>   FreeBSD and it's unclear what to do.
>>
>>   Submitted by:	Matthew Macy <mmacy@nextbsd.org> (previous version)
>>   Approved by:	emaste, jhibbits, sbruno
>>   MFC after:	3 days
>>   Differential Revision:	https://reviews.freebsd.org/D7447
>
> On powerpc and powerpc64, at r303902, I got
> =3D=3D=3D> usr.sbin/camdd (all)
> In file included from =

> /scratch/tmp/kib/obj/powerpc.powerpc64/scratch/tmp/kib/src
> /tmp/usr/include/machine/bus.h:463,
>                  from /scratch/tmp/kib/src/usr.sbin/camdd/camdd.c:54:
> /scratch/tmp/kib/obj/powerpc.powerpc64/scratch/tmp/kib/src/tmp/usr/incl=
ude/machi
> ne/bus_dma.h:33: error: expected declaration specifiers or '...' =

> before 'device_
> t'
> --- camdd.o ---
> *** [camdd.o] Error code 1
>


I waited for another day;  now just reverted the change on the header =

file in order to get a working universe build again hopefully.  In case =

this will be MFCed please take appropriate care to not break 11.

/bz



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?18158D1D-52E7-4894-A606-6672E81A1D45>