From nobody Mon Apr 17 10:43:09 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q0Ntp4Gc9z45jWW for ; Mon, 17 Apr 2023 10:43:14 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from mail.dawidek.net (mail.dawidek.net [94.130.64.56]) by mx1.freebsd.org (Postfix) with ESMTP id 4Q0Ntn5yJHz43dc for ; Mon, 17 Apr 2023 10:43:13 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 94.130.64.56 is neither permitted nor denied by domain of pjd@FreeBSD.org) smtp.mailfrom=pjd@FreeBSD.org; dmarc=none Received: from [192.168.250.133] (c-73-241-172-196.hsd1.ca.comcast.net [73.241.172.196]) by mail.dawidek.net (Postfix) with ESMTPSA id 5D9C84F949; Mon, 17 Apr 2023 12:43:12 +0200 (CEST) Message-ID: <0164e42a-e7cd-a1e8-295c-21f414edf67b@dawidek.net> Date: Mon, 17 Apr 2023 03:43:09 -0700 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Content-Language: en-US To: freebsd-current@freebsd.org References: <20230413071032.18BFF31F@slippy.cwsent.com> <20230413063321.60344b1f@cschubert.com> <20230413135635.6B62F354@slippy.cwsent.com> <319a267e-3f76-3647-954a-02178c260cea@dawidek.net> <441db213-2abb-b37e-e5b3-481ed3e00f96@dawidek.net> <5ce72375-90db-6d30-9f3b-a741c320b1bf@freebsd.org> <99382FF7-765C-455F-A082-C47DB4D5E2C1@yahoo.com> <32cad878-726c-4562-0971-20d5049c28ad@freebsd.org> <20230415115452.08911bb7@thor.intern.walstatt.dynvpn.de> <20230415143625.99388387@slippy.cwsent.com> <20230415175218.777d0a97@thor.intern.walstatt.dynvpn.de> <6792aded-6e2e-a118-259d-0df0f80c361c@smeets.xyz> <80ea8a67-9b64-c723-6d97-21cfa127ae43@dawidek.net> <01430095-33a3-a949-3772-2ec90b4c3fe6@dawidek.net> From: Pawel Jakub Dawidek In-Reply-To: <01430095-33a3-a949-3772-2ec90b4c3fe6@dawidek.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [2.45 / 15.00]; VIOLATED_DIRECT_SPF(3.50)[]; NEURAL_HAM_LONG(-1.00)[-0.996]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; NEURAL_HAM_MEDIUM(-0.08)[-0.083]; NEURAL_SPAM_SHORT(0.03)[0.027]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:94.130.0.0/16, country:DE]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; R_SPF_SOFTFAIL(0.00)[~all:c]; FREEFALL_USER(0.00)[pjd]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_DOM_EQ_FROM_DOM(0.00)[] X-Rspamd-Queue-Id: 4Q0Ntn5yJHz43dc X-Spamd-Bar: ++ X-ThisMailContainsUnwantedMimeParts: N On 4/17/23 18:15, Pawel Jakub Dawidek wrote: > There were three issues that I know of after the recent OpenZFS merge: > > 1. Data corruption unrelated to block cloning, so it can happen even > with block cloning disabled or not in use. This was the problematic commit: >     https://github.com/openzfs/zfs/commit/519851122b1703b8445ec17bc89b347cea965bb9 > > It was reverted in 63ee747febbf024be0aace61161241b53245449e. > > 2. Data corruption with embedded blocks when block cloning is enabled. > It can happen when compression is enabled and the block contains between > 60 to 112 bytes (this might be hard to determine). Fix exists, it is > merged to OpenZFS already, but isn't in FreeBSD yet. >     OpenZFS pull request: https://github.com/openzfs/zfs/pull/14739 > > 3. Panic on VERIFY(zil_replaying(zfsvfs->z_log, tx)). This is triggered > when block cloning is enabled, the sync property is set to disabled and > copy_file_range(2) is used. Easy fix exists, it is not yet merged to > OpenZFS and not yet in FreeBSD HEAD. >     OpenZFS pull request: https://github.com/openzfs/zfs/pull/14758 > > Block cloning was disabled in 46ac8f2e7d9601311eb9b3cd2fed138ff4a11a66, > so 2 and 3 should not occur. As of 068913e4ba3dd9b3067056e832cefc5ed264b5cc all known issues are fixed, as far as I can tell. Block cloning remains disabled for now just to be on the safe side, but can be enabled by setting sysctl vfs.zfs.bclone_enabled to 1. Don't relay on this sysctl as it will be removed in 2-3 weeks. -- Pawel Jakub Dawidek