From owner-dev-commits-src-main@freebsd.org Sat Apr 10 16:58:57 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 559E65D2263; Sat, 10 Apr 2021 16:58:57 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FHh6S62x6z3mgr; Sat, 10 Apr 2021 16:58:56 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.66.148.124]) by shaw.ca with ESMTPA id VGwflWMh8eHr9VGwhlHxg3; Sat, 10 Apr 2021 10:58:55 -0600 X-Authority-Analysis: v=2.4 cv=Yq/K+6UX c=1 sm=1 tr=0 ts=6071d94f a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=3YhXtTcJ-WEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=Q0dhoez1tl3BAHiCBI8A:9 a=JOWeiY5itpwPQvuQ8dm/GawRuwE=:19 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id CC771226C; Sat, 10 Apr 2021 09:58:52 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 13AGwq0t098644; Sat, 10 Apr 2021 09:58:52 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202104101658.13AGwq0t098644@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: =?UTF-8?Q?T=C4=B3l_Coosemans?= , Edward Tomasz Napierala , src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: 44f3b1aa980e - main - rc: kldxref only needs to depend on rootfs, not FILESYSTEMS In-reply-to: References: <202104100832.13A8WiAg015126@gitrepo.freebsd.org> <20210410162324.343d3624@FreeBSD.org> Comments: In-reply-to Warner Losh message dated "Sat, 10 Apr 2021 09:18:16 -0600." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 10 Apr 2021 09:58:52 -0700 X-CMAE-Envelope: MS4xfAPQRauiGXSidjlQIJRTWwZlumek8N8yiX4WjbwMSad7XRR8U3Hqoc7VxG1VVqsAkh3y0Mojpi2TSKWHZgF32xB2dQ9NEZtCXH4guRj2KTmZQLzYNLpF MdlADWMwKRKSIGgzz/zBOPL4kJ6gjc9AdGvubmwF3EDmFAB45/+Cd56RlG+gY+ThCMvsdWgfVqyVDUnFs3lqZTQPW3NApW9ZYuE1neV7B5u0FENxYobOiCSQ GRaXbYROe3c1z6KWhRBSNIXnBSr+3nnsvkznTDSXzkMzIiLZhaUYQ4dMkkzZn3WfOM9SHRK06GBKu6+MisUz2ckAFuZaH4uEuyStuoEg9A7u7oyTq527hx0x 8q7gVAjTjg4CfaLKB9vblUTobzF7ew== X-Rspamd-Queue-Id: 4FHh6S62x6z3mgr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2021 16:58:57 -0000 In message , Warner Losh writes: > --000000000000e89f2905bf9fcabb > Content-Type: text/plain; charset="UTF-8" > Content-Transfer-Encoding: quoted-printable > > On Sat, Apr 10, 2021, 8:23 AM T=C4=B3l Coosemans wrote: > > > On Sat, 10 Apr 2021 08:32:44 GMT Edward Tomasz Napierala > > wrote: > > > The branch main has been updated by trasz: > > > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=3D44f3b1aa980e747ce9b72ba4333c80a= > 99d8cd966 > > > > > > commit 44f3b1aa980e747ce9b72ba4333c80a99d8cd966 > > > Author: Edward Tomasz Napierala > > > AuthorDate: 2021-04-10 08:19:25 +0000 > > > Commit: Edward Tomasz Napierala > > > CommitDate: 2021-04-10 08:31:12 +0000 > > > > > > rc: kldxref only needs to depend on rootfs, not FILESYSTEMS > > > > > > This makes it run a bit earlier in the startup, which will > > > be useful for the linux rc script later on. > > > > > > Reviewed By: imp (earlier version) > > > Sponsored By: EPSRC > > > Differential Revision: https://reviews.freebsd.org/D29589 > > > --- > > > libexec/rc/rc.d/kldxref | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/libexec/rc/rc.d/kldxref b/libexec/rc/rc.d/kldxref > > > index 4d232ee0d4cf..4c1fa15f2a35 100755 > > > --- a/libexec/rc/rc.d/kldxref > > > +++ b/libexec/rc/rc.d/kldxref > > > @@ -4,7 +4,7 @@ > > > # > > > > > > # PROVIDE: kldxref > > > -# REQUIRE: FILESYSTEMS > > > +# REQUIRE: root > > > # BEFORE: netif > > > # KEYWORD: nojail > > > > > > > kldxref is in /usr which may be a separate file system so this requires > > at least mountcritlocal. > > > > I'd forgotten that detail. Maybe we should move it there. This makes a lot more sense because systems that NFS mount /usr may still break if the dependency is mountcritlocal. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.