From owner-dev-commits-src-main@freebsd.org Mon Oct 4 10:17:40 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ACF7E67BE81; Mon, 4 Oct 2021 10:17:40 +0000 (UTC) (envelope-from christos@margiolis.net) Received: from christos (mail.margiolis.net [95.179.159.8]) by mx1.freebsd.org (Postfix) with ESMTP id 4HNGqm13zbz4Vm6; Mon, 4 Oct 2021 10:17:39 +0000 (UTC) (envelope-from christos@margiolis.net) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; bh=5mx4KMfqDpM2 KFSb+snvPE5bzdEvPjzcPZPC9a8bWMw=; h=in-reply-to:references:subject:cc: to:from:date; d=margiolis.net; b=DsUg9hmFm/H5A18EhMIuUw3OBcU2AE4XsxSM5 wyoHbFhbgFRYBH0tkjQq7ItueLBoheWB79JuTQcKE4irOwrlLWP/nHSDfoKkYSmCyPGpJh aT91jum7hry8iXxU6NFtCKdlRnyqAuvpJ4dry/fgIJ1s+g02sBES/e0veUWxr6VM= Received: from pleb (athedsl-4393259.home.otenet.gr [79.130.121.27]) by christos (OpenSMTPD) with ESMTPSA id 4b0ffeff (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 4 Oct 2021 10:17:31 +0000 (UTC) Date: Mon, 4 Oct 2021 13:17:26 +0300 From: Christos Margiolis To: Mateusz Piotrowski <0mp@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Hans Petter Selasky Subject: Re: git: 903873ce1560 - main - Implement and use new mixer(3) library for FreeBSD. Message-ID: <20211004101726.wraje5ol5vwbhjcv@pleb> References: <202109221803.18MI3gdA013391@gitrepo.freebsd.org> <3d6a23c3-ad2c-4c5b-849e-1ef12dbf8955@FreeBSD.org> <487fa0f2-d845-438f-a035-8b7ccba4285a@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4HNGqm13zbz4Vm6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Oct 2021 10:17:40 -0000 On Mon, Oct 04, 2021 at 10:48:03AM +0200, Mateusz Piotrowski wrote: > Hmm, I agree that mute and volume controls in the new CLI interface are very > consistent. However, in case of the old CLI interface, the mute > functionality could also be added without a problem (at least by looking at > the manual pages, the "mute" command could look like this: "mixer mute > vol"). My point is that I feel that the CLI interface should be > backwards-compatible in this case. I think the new interface is more readable and extensible than the old one, and, as you mentioned, mixer(8) did need an upgrade, so it might be better to have it changed from now on and keep the old version as a port, than to keep working on an -- in my opinion -- obsolete interface and code. > > Would it help to make a port, like "oldmixer", under "audio" ? > > That's a good idea. I've committed the "old" mixer to the ports tree: https://cgit.freebsd.org/ports/commit/?id=e9a0efe4509b8dbdef0b4e4b5b94abf0aebd78a9. Yeap, that's a good idea indeed. -- Christos