Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Mar 2012 10:30:04 -0700
From:      Adrian Chadd <adrian@freebsd.org>
To:        Andre Albsmeier <Andre.Albsmeier@siemens.com>
Cc:        "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org>, "freebsd-mobile@freebsd.org" <freebsd-mobile@freebsd.org>
Subject:   Re: [Patch] Reflect state of rfkill switch in a sysctl for ath based card
Message-ID:  <CAJ-VmomE8L9V7nULVv=ooOo1tbSKEjHuAoZ0faWkExn1qYZuPw@mail.gmail.com>
In-Reply-To: <20120313111126.GA29538@bali>
References:  <20120312151358.GA26109@bali> <CAJ-Vmo=sDU43wiwga=Vgo25VURP%2BK4iKVMLCpYfw0n8RJZA59w@mail.gmail.com> <20120313111126.GA29538@bali>

next in thread | previous in thread | raw e-mail | index | archive | help
On 13 March 2012 04:11, Andre Albsmeier <Andre.Albsmeier@siemens.com> wrote:

>> Would you please create a PR and let me know what the PR number is?
>
> Well, there is a high probability that it might not work on
> non-5212 cards end even here it might fail (I can just test
> it with this Wistron CM9 card). Maybe someone with more
> knowledge about ath(4) (Sam?) might have quick look at it
> before...

Oh, I'm the ath(4) maintainer now and I'm pretty cluey in this area.

The AR5416 and later NICs have a similar looking GPIO rfkill setup but
the code isn't yet in the FreeBSD HAL.
I have it though, I just haven't ported it from the Atheros reference driver.

I'd prefer the rfkill method to be a HAL call, rather than assuming
it's a GPIO line. (I mean, it _is_ a GPIO line, but still.) In any
case, please create a PR for it now and we'll get it into -HEAD once
I've merged in rfkill support for the AR5416 and later NICs.

Thanks,


Adrian
(I work at Atheros now, so..)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomE8L9V7nULVv=ooOo1tbSKEjHuAoZ0faWkExn1qYZuPw>