Date: Wed, 28 Nov 2012 19:29:46 -0500 From: Eitan Adler <eadler@freebsd.org> To: Ruslan Mahmatkhanov <cvs-src@yandex.ru> Cc: svn-ports-head@freebsd.org, Frederic Culot <culot@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r307927 - head/www/reviewboard Message-ID: <CAF6rxg=dtLsYYNJPhS94Nku=PP4LRuG4ZKx-WCVyXoE6AZJb_g@mail.gmail.com> In-Reply-To: <50B65FC7.2010406@yandex.ru> References: <201211281830.qASIUOST007742@svn.freebsd.org> <50B65E6D.9030403@yandex.ru> <50B65FC7.2010406@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 November 2012 14:02, Ruslan Mahmatkhanov <cvs-src@yandex.ru> wrote: > Ruslan Mahmatkhanov wrote on 28.11.2012 22:56: > >> Hi Frederic, >> >> Frederic Culot wrote on 28.11.2012 22:30: >>> >>> Author: culot >>> Date: Wed Nov 28 18:30:23 2012 >>> New Revision: 307927 >>> URL: http://svnweb.freebsd.org/changeset/ports/307927 >>> >>> Log: >>> - Update to 1.6.14 [1] >>> - use dirrmtry in plist for shared python directories to silence >>> pkg_delete warnings >> >> >> [...] >> >>> @dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%% >>> -@dirrm %%PYTHON_SITELIBDIR%% >>> -@dirrm lib/python2.7 >>> +@dirrmtry %%PYTHON_SITELIBDIR%% >>> +@dirrmtry lib/python2.7 >> >> >> They should be just removed altogether, because this directories were >> created by python port, not that reviewboard port. The second note - >> plist entries should not contain hardcoded paths like lib/python2.7, >> because in case user prefer to use python 2.6 or 3.2, this path will be >> lib/python2.6 and lib/python3.2. There is %%PYTHON_LIBDIR%% for such >> things, but it doesn't matter in this case, because they just should be >> removed. > > > And by the way, it looks like reviewboard itself is a great tool to > implement at FreeBSD infrastructure, to make commit reviews like this one > and make sure that it will not be missing. SVN is supported. What other > people think? I've offered to set up reviewboard/phabricator without any reply before. If people are interested I'll gladly run one for FreeBSD. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=dtLsYYNJPhS94Nku=PP4LRuG4ZKx-WCVyXoE6AZJb_g>