From owner-svn-ports-all@FreeBSD.ORG Thu Nov 29 00:30:18 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B834022F for ; Thu, 29 Nov 2012 00:30:18 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0B8DE8FC13 for ; Thu, 29 Nov 2012 00:30:17 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id go10so11091714lbb.13 for ; Wed, 28 Nov 2012 16:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=kcElS6Uedyk9656EjbKlVR0xf46Gq6Td0HthVtEpg6E=; b=O5EmluQ83egwVDruJQj3XGvUdRU1llVOtHRBVIidGKjQmTDy0rjOS23catewpX10ha d1+LEeJKecrpJnGGe0JrdmHmgQRIXHSnXhtV46l7u8EHrD2NSBTdrlP4F9PaXTnAcGjN O8jfUSnqulAtuO3VwccxUUe+JP+8STtNBy5Vo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=kcElS6Uedyk9656EjbKlVR0xf46Gq6Td0HthVtEpg6E=; b=mXs1I0rkNznDPgL1eWnTyfsmTW1uXkr+CX2XpIQry+SsYcwf+73Pb5RcIHZ+UJVyzG fd4hUOWNLnuRU+1vpvmLJsWhN3JLmKUhs5mqJqCoYKbhTYtwRX3nd19rpnUNE+QgXYHs CmWiQB79b8nPIA+S93sVGxCRHuBEEJ3K0gexdUuUX1jPuWtUzrRcWD4yvxdt59OAu6kg 3efMZZcNHP7fPhy2aXyUYhdUBiPQGjbSMoJZAG9MQi65G1xz72HnW3y98WgM42xKMKN0 aZE7xc4qxyczI/M6fiYh2sfzurf+q5D0/uO/4ns84MOGOmV7Rk/IYbLAWJM8Fmpkqmec Awbg== Received: by 10.152.103.100 with SMTP id fv4mr19556516lab.39.1354149016713; Wed, 28 Nov 2012 16:30:16 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.154.168 with HTTP; Wed, 28 Nov 2012 16:29:46 -0800 (PST) In-Reply-To: <50B65FC7.2010406@yandex.ru> References: <201211281830.qASIUOST007742@svn.freebsd.org> <50B65E6D.9030403@yandex.ru> <50B65FC7.2010406@yandex.ru> From: Eitan Adler Date: Wed, 28 Nov 2012 19:29:46 -0500 X-Google-Sender-Auth: f1Sp_vFH7Mi-0U68w0h6X9dccgU Message-ID: Subject: Re: svn commit: r307927 - head/www/reviewboard To: Ruslan Mahmatkhanov Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmzJpAdhsTZtwL3btuK4G8LnRvNMGKy1P6aaLwsEiOg/2a983AzicomFw2TKD6g07dFvbL0 Cc: svn-ports-head@freebsd.org, Frederic Culot , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2012 00:30:18 -0000 On 28 November 2012 14:02, Ruslan Mahmatkhanov wrote: > Ruslan Mahmatkhanov wrote on 28.11.2012 22:56: > >> Hi Frederic, >> >> Frederic Culot wrote on 28.11.2012 22:30: >>> >>> Author: culot >>> Date: Wed Nov 28 18:30:23 2012 >>> New Revision: 307927 >>> URL: http://svnweb.freebsd.org/changeset/ports/307927 >>> >>> Log: >>> - Update to 1.6.14 [1] >>> - use dirrmtry in plist for shared python directories to silence >>> pkg_delete warnings >> >> >> [...] >> >>> @dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%% >>> -@dirrm %%PYTHON_SITELIBDIR%% >>> -@dirrm lib/python2.7 >>> +@dirrmtry %%PYTHON_SITELIBDIR%% >>> +@dirrmtry lib/python2.7 >> >> >> They should be just removed altogether, because this directories were >> created by python port, not that reviewboard port. The second note - >> plist entries should not contain hardcoded paths like lib/python2.7, >> because in case user prefer to use python 2.6 or 3.2, this path will be >> lib/python2.6 and lib/python3.2. There is %%PYTHON_LIBDIR%% for such >> things, but it doesn't matter in this case, because they just should be >> removed. > > > And by the way, it looks like reviewboard itself is a great tool to > implement at FreeBSD infrastructure, to make commit reviews like this one > and make sure that it will not be missing. SVN is supported. What other > people think? I've offered to set up reviewboard/phabricator without any reply before. If people are interested I'll gladly run one for FreeBSD. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams