From owner-svn-src-all@freebsd.org Wed May 22 16:34:45 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D1B8D15B0CC2 for ; Wed, 22 May 2019 16:34:44 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47AC68E0D7 for ; Wed, 22 May 2019 16:34:44 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1558542877; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=eGVD4eJ0vEOuVcVPInoGhTe1u0NJnbawFa5mQjiuyETobt40HUiUCTzzUkrrajbjdXrXqoWcNGgi8 oJSqciF3udT5uCN8gR/qsLX0utEPmYAivoMzcxVFmzVoER5hl3Tqtpz2etujpabanvKdl2ZCNqFBjY mP0JVtRqpi8mrPs1lFPnh6nwsTrOv191A3cOcsjc7eCTK2G7ASkKeaKGFgcg+lRlNb/AZN2GlwyssA MLTnBTy7s2vj8/28OmCcc78LU8xC8qoklIcey7jIIRNq9/ZjnIfkIT51gz4OHSKQxbu9pTvTbyiNhV MzpMnC6cqXIU8D3VhFHAd/QpGSY9NnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=OFYVDxmTS1Agp5uPaYVuBEM6pNwW3QOXB/ZgPplSxkQ=; b=nf9hcB0RaCzQo4it3kOedEDxhRiex5bc93vG2r89UVByzZoQ3lxovvuS3EXx+4PqOru5aPbCvvzrm Xzxk08IuCKp9YYIJpwwNUt50Pf8SxSTbnEpNeE75dUH7aKkmrVfzNsio0FSFyAlQwHNfcjT+FqValY vPTtmfu7mjn0kaBPCIuMP8ET1242ffT59osI7HAMgO3W2YHUISUpi4EnBGeYFNHnZ3TALrxCV/FO2V GdM8c6ti1MfGt4Uv8maV9ckqZvpcYQXOPjbp3HR8XCa7/raXQtC4BqvsCepP/NLPu0URMeq3PXmsBW 9ar4+AxHpyWPP6bUcezHtCM/7zn3Jtw== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=OFYVDxmTS1Agp5uPaYVuBEM6pNwW3QOXB/ZgPplSxkQ=; b=p0Ia1r+BTaTM67+Rh/82P1NDSnize8UQ3ynFIxSoNaCH0D+psh8Eatih7OyFqWz2tsyijM7i4uEAL fNWoS0C0+SIGBrXnOmvg0vh9RczfYLt+EXjCBqBa/Qnm9KyupniK7Db9ENZRRd4EsVrO6ud8Ks8Avk FG8e3CyLOB7XuWI80nNyWsludyZW1uJhz7hew0nCYarTBEQq+t/ENhK7u3mQ6hXGZgbzO3Hj+WgNqB ExIIK9J6SD09yjuGb8ZN55y4ojOj25jb7HORlwSi7PODDaJwf3eQcgmuznfAgZpZQw9HgEu7RDMKHy COZYnHZm4BJTu4uUcX3ynOkm4p+yRWQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: 7c0a3dbf-7caf-11e9-990f-673a89bc4518 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 7c0a3dbf-7caf-11e9-990f-673a89bc4518; Wed, 22 May 2019 16:34:36 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x4MGYZad006203; Wed, 22 May 2019 10:34:35 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <953361717e24b2e3a6911940881f42dcd05736c0.camel@freebsd.org> Subject: Re: svn commit: r250609 - head/sys/dev/ath From: Ian Lepore To: Alexey Dokuchaev , Adrian Chadd Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 22 May 2019 10:34:35 -0600 In-Reply-To: <20190522162005.GA82729@FreeBSD.org> References: <201305131903.r4DJ3DHm045333@svn.freebsd.org> <20190522162005.GA82729@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47AC68E0D7 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 16:34:45 -0000 On Wed, 2019-05-22 at 16:20 +0000, Alexey Dokuchaev wrote: > On Mon, May 13, 2013 at 07:03:13PM +0000, Adrian Chadd wrote: > > New Revision: 250609 > > URL: http://svnweb.freebsd.org/changeset/base/250609 > > > > Log: > > Since the node state is 100% back under the TX lock, just kill > > the use > > of atomics. > > > > Modified: > > head/sys/dev/ath/if_ath.c > > > > @@ -6140,13 +6133,13 @@ ath_tx_update_tim(struct ath_softc *sc, > > /* > > * Don't bother grabbing the lock unless the queue is > > empty. > > */ > > - if (atomic_load_acq_int(&an->an_swq_depth) != 0) > > + if (&an->an_swq_depth != 0) > > return; > > > > if (an->an_is_powersave && > > an->an_stack_psq == 0 && > > an->an_tim_set == 1 && > > - atomic_load_acq_int(&an->an_swq_depth) == 0) { > > + an->an_swq_depth == 0) { > > PVS Studio complains here: warning: V560 A part of conditional > expression > is always true: an->an_swq_depth == 0. Which probably makes sense > since > you return earlier if it's != 0. > > ./danfe > You're replying to a six year old commit? It doesn't check earlier whether that value is 0, it checks whether the address of that value is 0. That's probably a bug. -- Ian