From owner-svn-src-head@freebsd.org Thu Mar 29 18:02:01 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41A3FF6897A for ; Thu, 29 Mar 2018 18:02:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BDC617BB32 for ; Thu, 29 Mar 2018 18:02:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22d.google.com with SMTP id 19-v6so8882113itw.3 for ; Thu, 29 Mar 2018 11:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=tdlOqYEseDRDIIX+dfHOvfnLgy7FvAqzKilhnPCGeps=; b=smxNLzTT7vk8aAz9UUBSVIfFQxrLEOuQ++EBaA12S7QE23UcNAA+VGxf9fHP/5Utkn kBc8QJkWWP/RyNk3X4DrKtOvKPnueKrB2rlj5/kc66Q/i5m4JHlS9T6mDTwr2S6ub8BJ axFa/DDOncfcwd+9vhuYnkmfnex0yNgIdnASNlPIHI1N/8k7OQ4yrfjDYX8O6sS/5mGU KEY3Ebxj5utuvOngV6QvNQU30U2RmeULkPYCII6nJiPcD+WMNK8IJ59P49w2NEttxORA aj3qupgwZdOK8H5RO2VJEMEABcoS0sn3NK8XHo0UYruwWs47iqN0Nqk5Lht9WtCDj/WY /fQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=tdlOqYEseDRDIIX+dfHOvfnLgy7FvAqzKilhnPCGeps=; b=lDhu2kPtJJYg0hXNkpdWBiN7gtZFKSvh3SxQXs27gM8jvMLxbUz/Yb5UB4IPrBX79z 1IlwPGSsrbgDKZbbesccDpqTXD1vGOAfGpNyp/tzQdHK7KZTr80igxZPkChvdMCSJmbp yCJg/TnW+R5fERL/hZ8I0TOpAcxqoIWiEdAPjPrOn5pbMFbWhsM/jNSEdDbWIe5WejHR V57ggvLv8bVsRkRzrXvMCtPabltD70yP/mIB78XdiG1PRha9cQ3uCHzpwyz9W8ylrK/L CxZAdm58a3xgzOBGctkcWq6S0+Cocazgnzgyx2aoyZciGhNmYdjAS1zEmm3JMtKamHEG pP5A== X-Gm-Message-State: AElRT7ELK1preHb1NvoDEWpNHvKju+BzLbFGehY0qnkQztLtrWDs4byZ Hj0UJF9ExuA233XfB8YrjajqIW5VndOQXKJH1h05tg== X-Google-Smtp-Source: AIpwx4/ksvoVKbjB1aoXG0bDGPQHs3PWH4ZGtOja8gSlgHUKBb0GomMVEtkgKSmQzZyszFAnnTIHensuI2mTaCRTQpw= X-Received: by 2002:a24:4286:: with SMTP id i128-v6mr3676366itb.73.1522346520071; Thu, 29 Mar 2018 11:02:00 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Thu, 29 Mar 2018 11:01:59 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <2963143.tibTdn2gMF@ralph.baldwin.cx> References: <201803281651.w2SGp59K069533@repo.freebsd.org> <3653AD2C-F427-4BE7-874C-FF3AF3BDA85D@FreeBSD.org> <2963143.tibTdn2gMF@ralph.baldwin.cx> From: Warner Losh Date: Thu, 29 Mar 2018 12:01:59 -0600 X-Google-Sender-Auth: QbrIFjTqyrWm1F-TQ4vLc60J5fg Message-ID: Subject: Re: svn commit: r331686 - head To: John Baldwin Cc: Dimitry Andric , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 18:02:01 -0000 On Thu, Mar 29, 2018 at 11:28 AM, John Baldwin wrote: > On Wednesday, March 28, 2018 09:54:41 PM Dimitry Andric wrote: > > On 28 Mar 2018, at 18:51, John Baldwin wrote: > > > > > > Author: jhb > > > Date: Wed Mar 28 16:51:05 2018 > > > New Revision: 331686 > > > URL: https://svnweb.freebsd.org/changeset/base/331686 > > > > > > Log: > > > Expand remaining instances of 'make kernel' to buildkernel + > installkernel. > > > > > > The 'kernel' target is a bit more obscure compared to buildkernel and > > > installkernel. > > > > The 'kernel' target doesn't seem that obscure to me, it is clearly > > documented in build(7), right? In my opinion, the main advantage of > > separate build and install steps is that you can run the former as a > > non-privileged user, while only having to run the latter as super-user. > > I think it is still obscure even if in build(7). That said, after I had > done the commit I had a similar thought that splitting up the build and > install steps is useful in its own right, whether that is due to doing > builds as unprivileged, or doing builds on one machine or installs on > another. > Yea, I documented make kernel because it was fewer steps. I've used it 5 times in the last ~20 years or so since I did that. At the time, I think there was material talking about 'make world' still, so this was there for symmetry. Just like almost nobody uses make world today, almost nobody users make kernel. It is correct, and it works, but times and fashion has changed. We have a completely unpriv'd build now that needn't be in /usr/src, something that wasn't the case when the 'world' and 'kernel' targets were invented, IIRC. I didn't make a fuss when UPDATING changed because of the un-priv'd build, priv'd install separation that is so widely practiced, we barely need to call it out in UPDATING. And that 'barely' is covered completely by the commit to make this two steps. I'd only add I'd keep it documented in build(7), just like we keep world documented. Warner