From nobody Fri Nov 11 01:24:28 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N7gwY0Jd3z4f0l2; Fri, 11 Nov 2022 01:24:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N7gwX59g5z3G41; Fri, 11 Nov 2022 01:24:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668129868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lXqLNFp9JuEbmsGw1wXe2DLAYZX/CLRTqgXW5tLHtSM=; b=NZX0CdDej2FWfy2se/uvP9Z22b8DWfBgDp/j8uk0WdjMBD5En/YA3dTiP/tS71mq7UnDDi Rd8KM9Kn5+Nj4X0yyKatZxEr4HGKuNNuMMjDcyNrPvgjZGGjJez9S19RRo7wK9ufz7jnBV 5BgVqfhJP7ab+Z5s5B5ph5uKUOnQ0RPCyBm01wiBC2uSo5KcBynKDSeANfg7CXV3iPcg6a gu3uA4o75y0r9GPpVtKtKnwS6TaM9LmoxsKOPY2NekFsD6hOsR0O4hKV0SDQYHgnEh4hlL 240hjTTd+3xGwPqcgy5sDjs1w5qkMwI/f/7F60dilq1jGcFF6lap2gvy/KJ4PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668129868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lXqLNFp9JuEbmsGw1wXe2DLAYZX/CLRTqgXW5tLHtSM=; b=gkEtnViom46HfrQBT48Z056KwRZdJXaiYZrTVP/zZdic2L6xNCScmI1FL8u1nO1NsQTmWV LPGAt5teq7ikYrlUltg5xLNIhpOEkNFu7j5Cl4X6KyruXGJymb8TbqWot9XooWcsEegfUF aI19PBS9wYzKT6jjQl5/cBs0+EP5qcRGsiOialgywURLc2XVNGYK4qH7VyQeXpUNu3vODe pL13RjA8MTlic1Nm/txwoLosyM0v19uTN/qjeV0qEamWAcmmhTN7GXuOunrGBVvs2ujP1x Bhs5YasUoPK2dzsSZYFBaJBtwvppTq8YYj9s0hGZ4f09WtEGRKrJwni9ywdhyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668129868; a=rsa-sha256; cv=none; b=sxyt5BEkj9eqbJQchcoGMTq1BiBHNhLGc58KXGqMlrtFqJGaKEkY5Zd/p6gTHaaOsHirP/ XSjCSGDKgJEnooEj3CPk9j8ZLSfbQasn9nmNkVT3whmy33+soACRBPThncaTyyjwuMqNsC feTIyTntkM1ZybIzm62f86aadpg9cx5eHuWcRAe2ZZtxEOQdi3mZ+5K8XlxZ2IzlN+Ur6d dzPPn8M/xPXI6dgoqwu1+Ed+PWYRpUw9vz2YTXtuFuE+5st86jAX97hWUfaG2OaS5crYua pxf5G8Xfk8naEDPp12d98BMKmkHuGbWiU/7UhMdkg4B0sFnBJ97dJyFyEy+UHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N7gwX3yzgzNTN; Fri, 11 Nov 2022 01:24:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2AB1OSVH027184; Fri, 11 Nov 2022 01:24:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2AB1OSjk027183; Fri, 11 Nov 2022 01:24:28 GMT (envelope-from git) Date: Fri, 11 Nov 2022 01:24:28 GMT Message-Id: <202211110124.2AB1OSjk027183@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: b37b564ecf0a - stable/13 - bhyve virtio-scsi: Avoid out of bounds accesses to guest requests. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: b37b564ecf0a2e079acbd1866337a5c6ed739d73 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=b37b564ecf0a2e079acbd1866337a5c6ed739d73 commit b37b564ecf0a2e079acbd1866337a5c6ed739d73 Author: John Baldwin AuthorDate: 2022-08-29 22:36:11 +0000 Commit: John Baldwin CommitDate: 2022-11-11 01:10:18 +0000 bhyve virtio-scsi: Avoid out of bounds accesses to guest requests. - Ignore I/O requests with insufficiently sized input or output buffers (those not containing compete request headers). - Ignore control requests with improperly sized buffers. - While here, explicitly zero the output header of an I/O request to avoid leaking malloc garbage from the host if the header is not fully populated. PR: 264521 Reported by: Robert Morris Reviewed by: mav, emaste MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D36271 (cherry picked from commit bb31aee26bd13307d97c5d5bf2b10bf05bdc18fd) --- usr.sbin/bhyve/pci_virtio_scsi.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/pci_virtio_scsi.c b/usr.sbin/bhyve/pci_virtio_scsi.c index a960afd21317..563798f19b07 100644 --- a/usr.sbin/bhyve/pci_virtio_scsi.c +++ b/usr.sbin/bhyve/pci_virtio_scsi.c @@ -364,14 +364,27 @@ pci_vtscsi_control_handle(struct pci_vtscsi_softc *sc, void *buf, struct pci_vtscsi_ctrl_an *an; uint32_t type; + if (bufsize < sizeof(uint32_t)) { + WPRINTF("ignoring truncated control request"); + return (0); + } + type = *(uint32_t *)buf; if (type == VIRTIO_SCSI_T_TMF) { + if (bufsize != sizeof(*tmf)) { + WPRINTF("ignoring tmf request with size %zu", bufsize); + return (0); + } tmf = (struct pci_vtscsi_ctrl_tmf *)buf; return (pci_vtscsi_tmf_handle(sc, tmf)); } if (type == VIRTIO_SCSI_T_AN_QUERY) { + if (bufsize != sizeof(*an)) { + WPRINTF("ignoring AN request with size %zu", bufsize); + return (0); + } an = (struct pci_vtscsi_ctrl_an *)buf; return (pci_vtscsi_an_handle(sc, an)); } @@ -468,6 +481,15 @@ pci_vtscsi_request_handle(struct pci_vtscsi_queue *q, struct iovec *iov_in, uint32_t ext_data_len = 0, ext_sg_entries = 0; int err, nxferred; + if (count_iov(iov_out, niov_out) < VTSCSI_OUT_HEADER_LEN(sc)) { + WPRINTF("ignoring request with insufficient output"); + return (0); + } + if (count_iov(iov_in, niov_in) < VTSCSI_IN_HEADER_LEN(sc)) { + WPRINTF("ignoring request with incomplete header"); + return (0); + } + seek_iov(iov_in, niov_in, data_iov_in, &data_niov_in, VTSCSI_IN_HEADER_LEN(sc)); seek_iov(iov_out, niov_out, data_iov_out, &data_niov_out, @@ -477,7 +499,7 @@ pci_vtscsi_request_handle(struct pci_vtscsi_queue *q, struct iovec *iov_in, truncate_iov(iov_out, &niov_out, VTSCSI_OUT_HEADER_LEN(sc)); iov_to_buf(iov_in, niov_in, (void **)&cmd_rd); - cmd_wr = malloc(VTSCSI_OUT_HEADER_LEN(sc)); + cmd_wr = calloc(1, VTSCSI_OUT_HEADER_LEN(sc)); io = ctl_scsi_alloc_io(sc->vss_iid); ctl_scsi_zero_io(io);