From owner-svn-src-all@freebsd.org Thu Dec 10 21:48:14 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D5289D6035 for ; Thu, 10 Dec 2015 21:48:14 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C9774137C for ; Thu, 10 Dec 2015 21:48:13 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by wmnn186 with SMTP id n186so5156250wmn.0 for ; Thu, 10 Dec 2015 13:48:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=uCq4ela8R4pFOvqfCbYr2OBUBtcK2gk0BMQo1Qk3oNw=; b=IjfTKkIw0xq8KvNHDFph0SG0JmHafZQrxt36KT2D3u3/tR0bWgG7w6tNtQMSn6jTyl 58Ogd9FEPdHNdvtFIOMGkaSLn5cLMgMfgiJers+NU4aZTmvD4A/EHhznHjdqS+b+Xe9v llAp79EAXLguTBQeKk5d9P3FeqgzElTDKX+uKdLyDun6Z99lgStz608elxmLTFF9khgw Fqav7tuViJs9nGHnK2RdphEj4nQNQ5frMcvao18ULa3XMsPOm0kQRi6yTOCwMh5AlWXg 83o6olxpCFaxC5w+rOV33dxdlcj5ygPeNcLQNY1yKW1rPL8nr5y08Ux+x9i19dnjLW3x AOeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=uCq4ela8R4pFOvqfCbYr2OBUBtcK2gk0BMQo1Qk3oNw=; b=muSrer2jXS7SjAyLWVFm/y8dmc2/XBUuaktLRTAtzeU4jjfCC0vZtRVrjFI8kdK9k5 cvD9Iy80OPOctj0hxxk1Ku/bLteFGkaV2LjLdz7tSE3stmcOPUrkkzNNTCF35elkmh5a o0ZH6mq3pKg8A5fYfVRXR0RMy75EK7kAkHg0x/u5FhgYLn4eS7bi+zugTy7tfoDwTT70 l4fUR7Dz5vwCZBbwejdVm+CMSNb5Im/P4zFZr7QgwkHjGqocPUYjcg5x6q3GXCqNk+Fy XX7KuKjSG98ONhc5AJ20oU2R9Y9K4P6p76OPjTXs6Zrl4cScrUE/RDLAYgcYzXGNzr2W +hfQ== X-Gm-Message-State: ALoCoQl1unO2WYDzMG9x4Rd+ycWXo45V1sl/TgFUP7PkPEPm9sXIgsT5pIqrhX8l1Aie1TS3h0s5REg5ujRP0bjZowYele/uaQbbS3yXszHOQ+xjpShGmdY= MIME-Version: 1.0 X-Received: by 10.28.87.84 with SMTP id l81mr1550523wmb.22.1449784091458; Thu, 10 Dec 2015 13:48:11 -0800 (PST) Received: by 10.194.85.167 with HTTP; Thu, 10 Dec 2015 13:48:11 -0800 (PST) In-Reply-To: <20151210213324.GF82577@kib.kiev.ua> References: <201511230709.tAN79Z4L062228@repo.freebsd.org> <20151210213324.GF82577@kib.kiev.ua> Date: Thu, 10 Dec 2015 22:48:11 +0100 Message-ID: Subject: Re: svn commit: r291171 - in head/sys: amd64/amd64 compat/ia32 i386/i386 kern sys From: Oliver Pinter To: Konstantin Belousov Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2015 21:48:14 -0000 On Thursday, December 10, 2015, Konstantin Belousov wrote: > On Thu, Dec 10, 2015 at 10:18:19PM +0100, Oliver Pinter wrote: > > On Mon, Nov 23, 2015 at 8:09 AM, Konstantin Belousov > wrote: > > > Author: kib > > > Date: Mon Nov 23 07:09:35 2015 > > > New Revision: 291171 > > > URL: https://svnweb.freebsd.org/changeset/base/291171 > > > > > > Log: > > > Split kerne timekeep ABI structure vdso_sv_tk out of the struct > > > sysentvec. This allows the timekeep data to be shared between > similar > > > ABIs which cannot share sysentvec. > > > > > > Make the timekeep_push_vdso() tick callback to the timekeep > structures > > > instead of sysentvecs. If several sysentvec share the vdso_sv_tk > > > structure, we would update the userspace data several times on each > > > tick, without the change. > > > > > > Only allocate vdso_sv_tk in the exec_sysvec_init() sysinit when > > > sysentvec is marked with the new SV_TIMEKEEP flag. This saves > > > allocation and update of unneeded vdso_sv_tk for ABIs which do not > > > provide userspace gettimeofday yet, which are PowerPCs arches right > > > now. > > > > > > Make vdso_sv_tk allocator public, namely split out and export > > > alloc_sv_tk() and alloc_sv_tk_compat32(). ABIs which share timekeep > > > data now can allocate it manually and share as appropriate. > > > > > > Requested by: nwhitehorn > > > Tested by: nwhitehorn, pho > > > Sponsored by: The FreeBSD Foundation > > > MFC after: 2 weeks > > > > Hello Konstantin! > > > > Do you plan to MFC back this changes to 10-STABLE in these days? > > I decided to not merge the change. > And if I'm not wrong, the rationale behind this decision is the type stability of struct sysvec / sysent.