Date: Fri, 17 Aug 2007 11:26:20 +0300 From: "Petar Petrov" <pesho.petrov@gmail.com> To: "sat@freebsd.org" <sat@freebsd.org> Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/115218: Update port: audio/libmtp to version 0.2.0 Message-ID: <8a6e79f40708170126w4d42db14y68a09ba07e322bd0@mail.gmail.com> In-Reply-To: <200708151725.l7FHPS6r069467@freefall.freebsd.org> References: <200708151725.l7FHPS6r069467@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thank you! Unfortunately using CPPFLAGS instead of CFLAGS requires the patch files that the patch in the PR removes. Those patches were needed because in some cases the upgrade fails, because the examples in examples/ use the installed version of libmtp.h instead of the one in the distribution being compiled. For example the upgrade from 0.1.5 to 0.2.0 fails because of this same reason. Using CFLAGS instead of CPPFLAGS causes -I../src to appear before -I/usr/local/include when building the code and then the code uses the right header file. While using CPPFLAGS swaps them (e.g. -I/usr/local/include is before -I../src). The upgrading problem can be solved by either: - Removing libmtp 0.1.5 and installing version 0.2.0. - Putting back the patch files in files/. - Replacing "CPPFLAGS=..." with "CFLAGS=..." in the port Makefile (may lead to other problems). Btw I see that there is already libmtp 0.2.1. I'm going to send a PR that both updates to 0.2.1 and fixes the problem from above.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8a6e79f40708170126w4d42db14y68a09ba07e322bd0>