From nobody Mon Jan 24 14:15:28 2022 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B9586198A99C for ; Mon, 24 Jan 2022 14:15:30 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JjBpV4pkfz3Bq5; Mon, 24 Jan 2022 14:15:30 +0000 (UTC) (envelope-from bapt@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643033730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CzFE3VwdRWwNJzRujaObtI7E8pn2NcKY/plfuBqqmS4=; b=NcrLL4uUhCXevsgJWVKqtUh/OFIRodKXSBtrtdmey1ZMNT1ueTixgSOAPFUPE8FJFKu549 TjeXCSExUInNbVu4r6xmxZEEbdrvVWifFHi2AqWce7AW9vBAKErRVHsk5PG3tc1/sB1b8d g31lnFVHLgUxpo7S62/HgURSqzYJeOdzAZGpZelpilh+Bi8iISGiHujkbOj1pJE5PVqfR8 +HUOiX+z2reA5UFUE/AX9+S4v1d5XAlpeWsI8Q6jYToZyBTMaGU/gcnAUJM7sErFZL0YUP Wi2vE5504hbgspf+TU+m/irJ/GX0Jitm5cIEoMFTSv3FYmnTnnQQk/oXXT76Ew== Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 408F62F05C; Mon, 24 Jan 2022 14:15:30 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 5023A4B4F7; Mon, 24 Jan 2022 15:15:28 +0100 (CET) Date: Mon, 24 Jan 2022 15:15:28 +0100 From: Baptiste Daroussin To: Rosenke Cc: ports@freebsd.org, manu@freebsd.org Subject: Re: pkgbase checksums Message-ID: <20220124141528.u6gzdgp6zr3i6bja@aniel.nours.eu> References: <5fc8453b-1aab-bce9-59e9-1ee36161a580@FreeBSD.org> <20220113125730.zh4zmxj5d4473nmr@aniel.nours.eu> <5e0f8e42-0162-74d8-5fc7-1c2b62afd7dc@dssgmbh.de> <20220117152044.5njhh72fw7hm4tae@aniel.nours.eu> <399b948e-7ff8-d905-3b17-888fe8411cbd@dssgmbh.de> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643033730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CzFE3VwdRWwNJzRujaObtI7E8pn2NcKY/plfuBqqmS4=; b=DI816iYSnBGw5qolT+SRAKVF5jHiEDIevnIeJsXoo8rF2Qy/fIe5Q+b2bXqEOnRYzUSSck GlViuwfaTeVZDBUYHXUryGQjmyjPMMl9AGLIYm1t8wttokUUeQphy+XKsp9pYPUrwPgTqB PHbCGm7fXSDN3WhZi4qoOwua7dlcvor519mE6PjRmkdyN9W7fv7VXdowWSaho70ikheZOF UaQyMyXZr0DLQXqt/+6gP5Bw3QwI4YNVTlSLSJdgDD0yEYpyeCyGJnje4zKpctFrSs74g5 yqRvi7Kme+pn6zvmVKtchnSmmfa6nV5fpYrKVcZfr9Ur7/xHWTXyLxKQGFv+EQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643033730; a=rsa-sha256; cv=none; b=BtGm0tahyLwRtDid+ICHO+ceqCV4F2TH6P9f8fsGpTVN308BDuabfz4JvR98OaK6GyJIHl 2Bki5lc6h8noJY+kFXSVA9hvQhWxMe3ZhYN/J6aYLCavEsyRvtdbLLSewxu+j/O2m8llOy nHDhVXSqQb0/ZiA8GHxPAOSc1zNfK0XeAJguly+0Q+/fIavNHyyhFci1TunVsYygvRQ8Jt BQA0LMUffvH97zWLbNVgBaUXDXAfPIznOWsBmSQ7jtyW9ScmUDsNfQYYAuefhOkrd92gm3 9Xp3iXtLxLGJrm+YW2kxlh1ZfxLhqBel3DG8TmcnG555mnyfDTfNSJkF2hDJtw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Mon, Jan 24, 2022 at 03:11:52PM +0100, Rosenke wrote: > > > On 21.01.22 19:49, Baptiste Daroussin wrote: > > 17 janv. 2022 16:22:31 Rosenke : > > > > > On 17.01.22 16:20, Baptiste Daroussin wrote: > > > > On Mon, Jan 17, 2022 at 04:17:46PM +0100, Rosenke wrote: > > > > > On 17.01.22 16:12, Rosenke wrote: > > > > > > On 13.01.22 13:57, Baptiste Daroussin wrote: > > > > > > > On Thu, Jan 13, 2022 at 11:33:55AM +0100, Stefan Esser wrote: > > > > > > > > … > > > > > > > We have @config for base were pkg will do a 3 way merge, just those > > > > > > > files are > > > > > > > probably not marked as @config and should. > > > > > > > > > > > > > > (@config is native while @sample is external and define only in the > > > > > > > ports tree) > > > > > > > > > > > > > > if they are marked as such, then it means we have a bug in pkg > > > > > > > checksum as it > > > > > > > should not check the checksum of the files marked @config > > > > > > > > > > > > > > Best regards, > > > > > > > Bapt > > > > > > I tried it again with pkg 1.17.5 and FreeBSD 12.3 packages but got the > > > > > > same Error. The @config section is included in the packages: > > > > > > pkg info -R FreeBSD-clibs > > > > > > config: [ > > > > > >     "/etc/nsswitch.conf", > > > > > >     "/etc/libmap.conf", > > > > > >     "/etc/hosts", > > > > > >     "/etc/protocols", > > > > > >     "/etc/netconfig", > > > > > >     "/etc/hosts.equiv", > > > > > >     "/etc/rpc", > > > > > >     "/etc/mac.conf", > > > > > >     "/etc/shells", > > > > > >     "/etc/networks" > > > > > > ] > > > > > > > > > > > > In total these are now 9 cheksum mismatches in the pkgbase jail: > > > > > > === root@dsssrvt4j1 (pts/2) ~ 19(3) -> pkg check -sa > > > > > > Checking all packages:   1% > > > > > > FreeBSD-clibs-12.2.s20220114103031: checksum mismatch for /etc/hosts > > > > > > FreeBSD-clibs-12.2.s20220114103031: checksum mismatch for /etc/shells > > > > > > Checking all packages:  78% > > > > > > FreeBSD-runtime-12.2.s20220114103031: checksum mismatch for /.profile > > > > > > FreeBSD-runtime-12.2.s20220114103031: checksum mismatch for > > > > > > /etc/locate.rc > > > > > > FreeBSD-runtime-12.2.s20220114103031: checksum mismatch for > > > > > > /etc/login.conf > > > > > > FreeBSD-runtime-12.2.s20220114103031: checksum mismatch for > > > > > > /etc/sysctl.conf > > > > > > FreeBSD-runtime-12.2.s20220114103031: checksum mismatch for > > > > > > /etc/syslog.conf > > > > > > FreeBSD-runtime-12.2.s20220114103031: checksum mismatch for /etc/ttys > > > > > > FreeBSD-runtime-12.2.s20220114103031: checksum mismatch for > > > > > > /root/.profile > > > > > > Checking all packages: 100% > > > > > > > > > > > Whoops,  copied the wrong output: > > > > > === root@dsssrvt4j1 (pts/1) ~ 1(3) -> pkg check -sa > > > > > Checking all packages:   1% > > > > > FreeBSD-clibs-12.3.s20220117084939: checksum mismatch for /etc/hosts > > > > > FreeBSD-clibs-12.3.s20220117084939: checksum mismatch for /etc/shells > > > > > Checking all packages:  78% > > > > > FreeBSD-runtime-12.3.s20220117084939: checksum mismatch for /etc/locate.rc > > > > > FreeBSD-runtime-12.3.s20220117084939: checksum mismatch for /etc/login.conf > > > > > FreeBSD-runtime-12.3.s20220117084939: checksum mismatch for /etc/motd > > > > > FreeBSD-runtime-12.3.s20220117084939: checksum mismatch for /etc/sysctl.conf > > > > > FreeBSD-runtime-12.3.s20220117084939: checksum mismatch for /etc/syslog.conf > > > > > FreeBSD-runtime-12.3.s20220117084939: checksum mismatch for /etc/ttys > > > > > Checking all packages: 100% > > > > > > > > > Here we are ;), the bug is on my side then :D, we pkg devs (I said we because > > > > maybe manu will be faster than me on this) will dive in the code and fix. > > > > > > > > Best regards > > > > Bapt > > > Thank you very much. The concept of pkgbase is great, loving it on jails with zfs so far. > > > > > > -- > > > Mit freundlichen Grüßen > > > Henrik Rosenke / Operating > > > > > > Data-Service GmbH > > > Beethovenstr. 2a > > > 23617 Stockelsdorf > > > Tel. +49 451/49001-34       Fax. +49 451/49001-26 > > > Email:rosenke@dssgmbh.de  /www.dssgmbh.de > > > > > > Amtsgericht Lübeck, HRB 318 BS > > > Geschäftsführer: Wilfried Paepcke, Dr. Andreas Longwitz, > > >                   Dr. Hans-Martin Rasch, Dr. Uwe Szyszka > > Fixed in git > > > > Bapt > Thanks, when will the next pkg Version be released? > Tried to manually port back the change in pkg.c but 1.17.5 is missing the > whole hashing structure and i dont want to port back all of this. > > [00:01:17] pkg.c:1522:7: error: implicit declaration of function > 'pkghash_get_value' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > [00:01:17] pkghash_get_value(pkg->config_files_hash, f->path) == NULL) { > [00:01:17]                     ^ > [00:01:17] pkg.c:1522:30: error: no member named 'config_files_hash' in > 'struct pkg'; did you mean 'config_files'? > [00:01:17] pkghash_get_value(pkg->config_files_hash, f->path) == NULL) { > [00:01:17] ^~~~~~~~~~~~~~~~~ > [00:01:17]                                            config_files > Yes too much work happened in git for this feature to be cherry picked easily. But I do plan to release pkg 1.18 soon, I have a last feature to work on before the release. Bapt