From owner-dev-commits-src-main@freebsd.org Sat Feb 27 02:36:35 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E754E558A1A; Sat, 27 Feb 2021 02:36:35 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnVyq69pbz3mbg; Sat, 27 Feb 2021 02:36:35 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: lwhsu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id C08FA70A2; Sat, 27 Feb 2021 02:36:35 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by mail-yb1-f178.google.com with SMTP id l8so10822396ybe.12; Fri, 26 Feb 2021 18:36:35 -0800 (PST) X-Gm-Message-State: AOAM532OuPCoulEAlMr8iFmaAs9hIlLslHMwNdSuf03aIUt0JArtfAQg 9C6qmRr2bhtufiNxWZ0VPInqyaCALi2zXWJr51I= X-Google-Smtp-Source: ABdhPJw1XcFW/nBF8811SgJzbI3kjT0wiPTcMdLKeRdnzcYxDcHWIpm0Rq3+0E+UdiBV15N5iZXo3uaDU0Nfu6/jHCk= X-Received: by 2002:a25:34d5:: with SMTP id b204mr8334370yba.497.1614393395250; Fri, 26 Feb 2021 18:36:35 -0800 (PST) MIME-Version: 1.0 References: <202102261907.11QJ7Oaq039195@gitrepo.freebsd.org> In-Reply-To: <202102261907.11QJ7Oaq039195@gitrepo.freebsd.org> From: Li-Wen Hsu Date: Sat, 27 Feb 2021 10:36:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: bc3bba70d834 - main - inetd: Add examples from manual page and other sources To: Daniel Ebdrup Jensen Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Feb 2021 02:36:36 -0000 On Sat, Feb 27, 2021 at 3:07 AM Daniel Ebdrup Jensen wrote: > > The branch main has been updated by debdrup (doc committer): > > URL: https://cgit.FreeBSD.org/src/commit/?id=bc3bba70d834c169475302334b192bc90c17521e > > commit bc3bba70d834c169475302334b192bc90c17521e > Author: Daniel Ebdrup Jensen > AuthorDate: 2021-02-26 19:05:46 +0000 > Commit: Daniel Ebdrup Jensen > CommitDate: 2021-02-26 19:07:03 +0000 > > inetd: Add examples from manual page and other sources ... > Reviewed by: kevans, brueffer, lwhsu, yuripv This is very minor, but for the record, I didn't click "accept" so I am a bit hesitant to be listed in the "Reviewed by" line because I think it implies I have reviewed everything and meet my standard to commit myself. I was just commenting on some very tiny stuff and help. I support the changes but I don't think my contribution is sufficient as a reviewer. I don't even list myself in the reviewers field in the differential. > Differential Revision: https://reviews.freebsd.org/D28882 ... > diff --git a/usr.sbin/inetd/inetd.conf b/usr.sbin/inetd/inetd.conf > index 65a3507a6dc2..7f5f6783a038 100644 > --- a/usr.sbin/inetd/inetd.conf > +++ b/usr.sbin/inetd/inetd.conf ... > +# Example entry for insecure rsync server > +# This is best combined with a VTI like if_ipsec(4) or wg(4) As we discussed in the differential, we can put if_wg(4) here, and they can be MFC'd together. BTW, still thanks very much for you to work on this! Best, Li-Wen