From owner-freebsd-arch@FreeBSD.ORG  Sat Mar 26 04:08:30 2005
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9C1CD16A4CE
	for <arch@freebsd.org>; Sat, 26 Mar 2005 04:08:30 +0000 (GMT)
Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 06F3A43D31
	for <arch@freebsd.org>; Sat, 26 Mar 2005 04:08:30 +0000 (GMT)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au
	[61.8.0.86])j2Q48SHn007199;	Sat, 26 Mar 2005 15:08:28 +1100
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	j2Q48NS5019873;	Sat, 26 Mar 2005 15:08:25 +1100
Date: Sat, 26 Mar 2005 15:08:22 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@delplex.bde.org
To: Brooks Davis <brooks@one-eyed-alien.net>
In-Reply-To: <20050325223925.GB1944@odin.ac.hmc.edu>
Message-ID: <20050326143417.J3715@delplex.bde.org>
References: <20050325223925.GB1944@odin.ac.hmc.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
cc: arch@freebsd.org
Subject: Re: -I${CURDIR}/../../sys in src/*bin/Makefiles
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Mar 2005 04:08:30 -0000

On Fri, 25 Mar 2005, Brooks Davis wrote:

> In PR bin/79229 the submitter suggests that we add -I${CURDIR}/../../sys
> to CFLAGS in sbin/ifconfig/Makefile.  I initially responded that we
> don't normally do that because buildworld handles picking up the latest
> headers, but after greping other Makefiles in sbin, I found that we
> do actually do that in a number of cases.  It seems to me that we
> should really make up our mind which one we should do.  I'm somewhat
> disinclined to add -I's to every utility, but that's not a strong
> opinion.  What do others thing?

This is a bug in the other Makefiles.  It is not needed for full builds,
and breaks some cases for building just one utility (ones where libraries
are consistent with <sys> but not with ${CURDIR}/../../sys, and the
utility sources are either old so that they match <sys> or haven't
changed so much that they need new system headers).  It is just a hack
that "fixes" a different set of cases (ones where the utility sources
match ${CURDIR}/../../sys, and the installed libraries are either new
so that they match ${CURDIR}/../../sys but not <sys> (unlikely) or
haven't change so much that they don't work with utilities compiled
with new system headers).

I thought that ru fixed it.  Well, that was a long time ago and the
bug seems to be mainly in newer Makefiles.  ps/Makefile was fixed in
rev.1.14 (2001/05/18).

Bruce