Date: Fri, 7 Jul 2023 18:48:23 +0200 From: Mateusz Piotrowski <0mp@FreeBSD.org> To: Emmanuel Vadot <manu@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: c81495a621c4 - main - fwget: Fix quoting Message-ID: <98DC3116-140D-47C8-8B33-E5C666A76D75@FreeBSD.org> In-Reply-To: <202307070719.3677JqSM058134@gitrepo.freebsd.org> References: <202307070719.3677JqSM058134@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hey Manu, > On 7. Jul 2023, at 09:19, Emmanuel Vadot <manu@FreeBSD.org> wrote: >=20 > The branch main has been updated by manu: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc81495a621c461b3d3395a7c5b0e7345= 8201c443 >=20 > commit c81495a621c461b3d3395a7c5b0e73458201c443 > Author: Emmanuel Vadot <manu@FreeBSD.org> > AuthorDate: 2023-07-07 07:16:05 +0000 > Commit: Emmanuel Vadot <manu@FreeBSD.org> > CommitDate: 2023-07-07 07:19:41 +0000 >=20 > fwget: Fix quoting >=20 > This kind of quoting doesn't work, no idea why shellcheck wanted = this. > If there is a "safer" way to "fix" this feel free to do it just = test > that it's working after. >=20 > Reported by: Kenneth Raplee <kenrap@kennethraplee.com> > Sponsored by: Beckhoff Automation GmbH & Co. KG > Fixes: 7ad4d94d5bf2 ("Fix some shell issues by adding quotes and = replace backticks with $()") > --- > usr.sbin/fwget/fwget.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/usr.sbin/fwget/fwget.sh b/usr.sbin/fwget/fwget.sh > index 61acaee86687..90bc23b07077 100644 > --- a/usr.sbin/fwget/fwget.sh > +++ b/usr.sbin/fwget/fwget.sh > @@ -27,7 +27,7 @@ > # IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > # POSSIBILITY OF SUCH DAMAGE. >=20 > -: "${LIBEXEC_PATH:=3D'/usr/libexec/fwget'}" > +: ${LIBEXEC_PATH:=3D"/usr/libexec/fwget"} What was the reported bug here? Quoting here looks alright. >=20 > usage() > { >=20 Best, Mateusz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?98DC3116-140D-47C8-8B33-E5C666A76D75>