From nobody Tue Feb 14 21:44:09 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PGZV64htSz3q33G; Tue, 14 Feb 2023 21:44:14 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PGZV648PQz47br; Tue, 14 Feb 2023 21:44:14 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676411054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uumGPxa4yPIoGShGj0vNuv+wZYz7mXJ+5eRWLUnHIug=; b=w/rRhvYb0RUL8RxOP2d6nKs/6P1pUhJyYjZpiYC2LH0nqb2/aiRnzKM9tegnLcleXrsmza kna8Ig+nqUxIvzB650MNwTCLlokTCjt09JcCKS+vuYplG2EHsLybq0Pb6njuZD/xd6XpsJ ste+akCcOVMdzNQQLnj1Kz6WCxN5dxDAwLx7QVPyCoZ201WuqVHGIx79KBy9kwjvu1LPkG bt38JpIpoyWS70f3wiZIA3X638vBuQkWBay4QFj9xvscUPeNUPdilN+ugdLaTjialxprT4 9C/6Tbyj9/EPBEjEjVRz3ak/cyC01daByK16oP8yis7qjSMis94Q46LvIt68Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676411054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uumGPxa4yPIoGShGj0vNuv+wZYz7mXJ+5eRWLUnHIug=; b=QNLWQfzWN9c6Ef1ZfJa7oDPxbwzh6WfmMv0ifeiMnThYQeIYJtaCAmG0tMwBZlJ2rP6HeA zpmJX+KaCRdW00jGmYpf6KMLWEN082Q3CtoSwRMNgIn1OFjXClu03/fTeeLcLKtPzkt+ko Gi373HE1bfo7/dS1LkgRkTNPWl2LF2cS5BH2xwH29OPJfhLqyXAiSCprXdYbl+QDx15Mvw GPqchl1EEa2mBWUy91GTOdNzOAwR8kzUojfmZp7mbApNvus3428y6G4TeRfa+w3udDdCpV kWEFB9kswz/3DYLTPDXe10/Y0cshjqq7XcsTspGiKRGSrJB5kwt+HXRi2T79HA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676411054; a=rsa-sha256; cv=none; b=D5H9/JbsMzlDpCT24KIY2Kz+OGOX3NcZ4qL8svxK/Ha/uHx3xA44Xi+g8knh0HrLHCa0FN J7nsu7cLYGLlucg8R/oeGkvxFEl5j/mGCD0KpnRs/AdVDxV5uVI1clIUplFS80iFbGmZEC J6rgJPavCr6rNisoDj7GaPNQ6vx8PRPez0rxVhjLQSrkNscBqXVX8pf4lPTkkd3wLBUeT5 DdSOhMlMxRwBzmoTNUJWc+Kg4ufcFKSzqU7k+vmZa/lT5y9QdGJyHyNdCYr56Hs2jeJ6NP n4aehH2m6F7a5KP/Qby17Fjri1LOYf4eVSFq0Ix+L84wgSkJNVdgVloGA/g+Xw== Received: from [192.168.1.10] (unknown [98.42.164.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PGZV56fjtzmfb; Tue, 14 Feb 2023 21:44:13 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.69.23011802 Date: Tue, 14 Feb 2023 13:44:09 -0800 Subject: Re: e35448a901aa - main - powerpc: Drop old workaround for old gcc From: Ravi Pokala To: Warner Losh , , , Message-ID: <68E1F686-AB9F-4AC9-BBC5-0FE5F17041C0@panasas.com> Thread-Topic: e35448a901aa - main - powerpc: Drop old workaround for old gcc References: <202302141654.31EGsBtE057310@gitrepo.freebsd.org> In-Reply-To: <202302141654.31EGsBtE057310@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N > However, that causes problems > for programs that do: It feels like there was supposed to be an example there, but there isn't on= e...? Thanks, Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: > on behalf of Warner Losh > Date: 2023-02-14, Tuesday at 08:54 To: >, >, > Subject: git: e35448a901aa - main - powerpc: Drop old workaround for old gc= c The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=3De35448a901aa56aa232efbc4fe7a73= a9bdac3511 commit e35448a901aa56aa232efbc4fe7a73a9bdac3511 Author: Warner Losh > AuthorDate: 2023-02-14 16:47:08 +0000 Commit: Warner Losh > CommitDate: 2023-02-14 16:47:08 +0000 powerpc: Drop old workaround for old gcc Very old versions of gcc defined _BIG_ENDIAN and _LITTLE_ENDIAN. So to work around that, we undefined them here. However, that causes problems for programs that do: (and many other variations on that theme). Since this often is the result of weirdly nested includes in the ports world that are hard to unwind, drop this workaround to help more ports build out of the box. If there's still an issue here (and my testing hasn't shown it), we'll fix the issue in a brand-new way once I have a reproducer. This fixes the mesa-devel build, and others Sponsored by: Netflix Tested by: pkubaj MFC After: 3 days Differential Revision: https://reviews.freebsd.org/D38564 --- sys/powerpc/include/endian.h | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/sys/powerpc/include/endian.h b/sys/powerpc/include/endian.h index 9e28237bfd24..0fac50361632 100644 --- a/sys/powerpc/include/endian.h +++ b/sys/powerpc/include/endian.h @@ -36,18 +36,6 @@ #define _MACHINE_ENDIAN_H_ #include - -/* - * GCC defines _BIG_ENDIAN and _LITTLE_ENDIAN equal to __BIG_ENDIAN__ - * and __LITTLE_ENDIAN__ (resp). - */ -#ifdef _BIG_ENDIAN -#undef _BIG_ENDIAN -#endif -#ifdef _LITTLE_ENDIAN -#undef _LITTLE_ENDIAN -#endif - #include #endif /* !_MACHINE_ENDIAN_H_ */