Date: Fri, 27 Dec 2019 20:24:58 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Pedro Giffuni <pfg@FreeBSD.org> Cc: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r356142 - in head/sys: dev/ofw sys Message-ID: <201912280424.xBS4OwfL041448@gndrsh.dnsmgr.net> In-Reply-To: <31c49f48-db69-4b8b-54d0-8e575bb3d2f4@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > > On 2019-12-27 22:16, Rodney W. Grimes wrote: > >> Author: pfg > >> Date: Sat Dec 28 02:58:30 2019 > >> New Revision: 356142 > >> URL: https://svnweb.freebsd.org/changeset/base/356142 > >> > >> Log: > >> SPDX: update some tags with two licenses. > >> > >> Modified: > >> head/sys/dev/ofw/openfirm.h > >> head/sys/sys/sched.h > >> > >> Modified: head/sys/dev/ofw/openfirm.h > >> ============================================================================== > >> --- head/sys/dev/ofw/openfirm.h Sat Dec 28 02:11:41 2019 (r356141) > >> +++ head/sys/dev/ofw/openfirm.h Sat Dec 28 02:58:30 2019 (r356142) > >> @@ -1,7 +1,7 @@ > >> /* $NetBSD: openfirm.h,v 1.1 1998/05/15 10:16:00 tsubai Exp $ */ > >> > >> /*- > >> - * SPDX-License-Identifier: BSD-4-Clause > >> + * SPDX-License-Identifier: (BSD-4-Clause AND BSD-2-Clause-FreeBSD) > >> * > >> * Copyright (C) 1995, 1996 Wolfgang Solfrank. > >> * Copyright (C) 1995, 1996 TooLs GmbH. > >> > >> Modified: head/sys/sys/sched.h > >> ============================================================================== > >> --- head/sys/sys/sched.h Sat Dec 28 02:11:41 2019 (r356141) > >> +++ head/sys/sys/sched.h Sat Dec 28 02:58:30 2019 (r356142) > >> @@ -1,5 +1,5 @@ > >> /*- > >> - * SPDX-License-Identifier: BSD-4-Clause > >> + * SPDX-License-Identifier: (BSD-4-Clause AND BSD-2-Clause-FreeBSD) > >> * > >> * Copyright (c) 1996, 1997 > >> * HD Associates, Inc. All rights reserved. > >> > > This situation should not of occured, and leads to an ambigous license state. > > It actually happens a lot (I mean two or more licenses in the same > file): SPDX explicitly uses AND (not OR) for cases like this. > > > What code is under license 2 clause and what under 4 clause? > > Anyone redistributing the file has to respect both licenses. If you are > lucky enough to have access to version control you may be able to > discern the author and the corresponding license, otherwise you are > trapped with both. So the 2 clause add is null, so why have it there? > > > It looks to me as if this was done by Jeff Robinson as the 2 clause is > > attached to his copyright and we should probably just ask him to relax > > that back to the files existing 4 clause license, and or go after Greg > > Ansley of HD associtates to get them to relax the 4 clause. > > > No, Jeff (or anyone else, as I said there are many cases in our tree) is > entitled to choose his own license as long as it is compatible with the > pre-existing licensing. I was specifically sighting this one file, sys/sys/sched.h. Actually that might be a grey area, no place does the BSD license grant you rights to modify the terms of the license, and that is in effect what adding this second license does. You can choose your own license for original work, sure, but obliterating parts of an existing license by applying a second license which is in conflict is probably a poor idea. > Pedro. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912280424.xBS4OwfL041448>