From owner-svn-src-all@freebsd.org Thu Nov 19 00:08:26 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7BAC5475CB2 for ; Thu, 19 Nov 2020 00:08:26 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2k.ore.mailhop.org (outbound2k.ore.mailhop.org [54.148.219.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cc0Q21WrFz4r22 for ; Thu, 19 Nov 2020 00:08:26 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1605744505; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=VQQRwc0ozeXp/GKZQ5jQ/jvaMFMkyRqHimhCL9AuYmxH0+a59cYmu0oGseAVN2dS760VctwxVsVZm 0BrNcex0z1sz0PDOa8ARBqR21VY4pH1lgUUlThgVamH2TQerujlj1x1xcray+MhfL3V1vLyS8qJuf6 dsYdl/s1xXdYOuBFu7uQAiG3IDAzXUcrrIDwvIEbBQ3tF2r/MO9AH0oEczyANxH3uQYh8ZfMef5b5n 08aTni8IcPxQCKDbcXwvcCqeItGQ2ftXN7z6JfRdfDGh2P/WqnLxF8gjXKsPCJMBkXTFngiuRcessm ipv2zBcWJ9IQdDoX1wsYIV0vW9OkjDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=eauvmwF1teDTlEE083sn4Uyabu8ySaNnL4klz00ZG2M=; b=katMpEudWgHSOsIPhCZJubieGBv/s07Ajt0vdyQO1gB9Eg1pL8jSijWp/2Xc3qZ7lu1hD//h/Z8kt s3rMwFD3RzH52OK3H9NS5xO02Aevezg0hBGdjCNzlk+3/wZJmtEckS/+iBXMOvyGku4TeNXM0d01y2 ruAcL2+m8ditvyKNkktMIycWM2R0gmVIOByjahC8YF+quW5NPXKBcqilNcD4K3UWWajinAbxAd1Npk RdUw2mQT1ulkymKzXmn/CXHjUvbg9XpwomYXJqeKjxwIoLA16x+mj1rPuLyoW+Z/EJmcy3idbdoX/8 iLoLcVSY9t5HuVPTYJtqif+tq4VD2dw== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=eauvmwF1teDTlEE083sn4Uyabu8ySaNnL4klz00ZG2M=; b=IBFWv0i2O35oN+U/+Q2RnwFvVZUEhdVbhxbdairyj57uTQAaWI+UanmDc+0D299uxStAgLGyDDStv 7/cA7c1/VgSjwxJ5cHHweZJJW5fODkVwnedaXxnj8XK1KyfdXG/m3GMW0L955KWqPCljV3fC6a7I9J IceMbKkSyCPMFGG2bhaSTx3pskdubsDJtRy4SDzgCTkWwKdOhFEbLcuY3UfgnMAYGW/JlUTx3bIDEC CItfUJUz2mIhIqcYggMwsk7ypdE3Cp0+heFg2kta4UJpnuL2hggAEVd5DGVtEuzIs+sy79b64RnKP+ n8F3uVFivr0AsXgeJl8nETTMKtP5h0A== X-MHO-RoutePath: aGlwcGll X-MHO-User: 5621484a-29fb-11eb-9e11-df46ed8f892f X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 5621484a-29fb-11eb-9e11-df46ed8f892f; Thu, 19 Nov 2020 00:08:23 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 0AJ08MYX047491; Wed, 18 Nov 2020 17:08:22 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <96d3f81c1f992aab16bf4e0228250f24bf79fc8a.camel@freebsd.org> Subject: Re: svn commit: r367695 - in head/sys: kern sys From: Ian Lepore To: John Baldwin , Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 18 Nov 2020 17:08:22 -0700 In-Reply-To: <4f6f6b0a-e71c-a286-507e-abf2522c142c@FreeBSD.org> References: <202011141922.0AEJM2ld055995@repo.freebsd.org> <4f6f6b0a-e71c-a286-507e-abf2522c142c@FreeBSD.org> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Cc0Q21WrFz4r22 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 00:08:26 -0000 On Wed, 2020-11-18 at 15:37 -0800, John Baldwin wrote: > On 11/18/20 2:16 PM, Mateusz Guzik wrote: > > On 11/17/20, John Baldwin wrote: > > > On 11/14/20 11:22 AM, Mateusz Guzik wrote: > > > > Interested parties can check the consumer (also seen in the diff) > > to > > see this is for consistency. I don't think any comments are > > warranted > > in the header. > > I did read the consumer, and there didn't seem tremendous value in > the > extra line there. > > > > These changes would benefit from review. > > > > > > > I don't think it's feasible to ask for review for everything lest > > it > > degardes to rubber stamping and I don't think this change warranted > > it, regardless of the cosmetic issues which can always show up. > > That is not consistent with the direction the project is moving. If > you > check the commit logs of other high-volume committers such as markj@, > kib@, or myself, you will find that a substantial number of those > commits > are reviewed (typically in phabricator) without preventing us from > making useful progress. Also, while the previous core did not > mandate > reviews, we moved closer to it when the Pre-Commit Review chapter was > added to the Committer's Guide: > > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/pre-commit-review.html > > In the related thread on developers@ we indicated that while weren't > yet > making pre-commit review mandatory, we collectively want to move in > that > direction. > Yeah, the direction the project is moving is to drive away the few remaining prolific contributors with policies that take all the satisfaction out of working on freebsd. There's a reason I've gone from being in the top ten commiters list in 2019 to having around a dozen commits in 2020. (Harrison Bergeron lives, it seems, but the world has so many more Diana Moon Glampers to counter with.) -- Ian