From owner-freebsd-fs@freebsd.org Wed Oct 2 02:04:45 2019 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AA6F1FE3D0 for ; Wed, 2 Oct 2019 02:04:45 +0000 (UTC) (envelope-from shiva.bhanujan@quorum.com) Received: from asp.reflexion.net (outbound-mail-211-16.reflexion.net [208.70.211.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46jfbJ1nrHz4fXk for ; Wed, 2 Oct 2019 02:04:43 +0000 (UTC) (envelope-from shiva.bhanujan@quorum.com) Received: (qmail 12732 invoked from network); 2 Oct 2019 02:04:43 -0000 Received: from unknown (HELO rtc-sm-01.app.dca.reflexion.local) (10.81.150.1) by 0 (rfx-qmail) with SMTP; 2 Oct 2019 02:04:43 -0000 Received: by rtc-sm-01.app.dca.reflexion.local (Reflexion email security v9.26.0) with SMTP; Tue, 01 Oct 2019 22:04:43 -0400 (EDT) Received: (qmail 21380 invoked from network); 2 Oct 2019 02:04:42 -0000 Received: from unknown (HELO mail.quorum.net) (64.74.133.216) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 2 Oct 2019 02:04:42 -0000 Received: from QLEXC01.Quorum.local ([fe80::edb6:63d5:778f:2f0e]) by QLEXC01.Quorum.local ([fe80::edb6:63d5:778f:2f0e%14]) with mapi id 14.03.0468.000; Tue, 1 Oct 2019 19:04:41 -0700 From: Shiva Bhanujan To: Eric Borisch CC: Fabian Keil , "freebsd-fs@freebsd.org" , Shiva Bhanujan Subject: RE: [ZFS] Potential silent data corruption when receiving incremental stream with block size change on receiving side Thread-Topic: [ZFS] Potential silent data corruption when receiving incremental stream with block size change on receiving side Thread-Index: AQHTD5fVNyrcrAZt7U2M3rWRyeqM6KdLNZ51gACKLQD//6xDYA== Date: Wed, 2 Oct 2019 02:04:40 +0000 Message-ID: <3A5A10BE32AC9E45B4A22F89FC90EC0701C3767B84@QLEXC01.Quorum.local> References: <20170807165118.72bde0a3@fabiankeil.de> <3A5A10BE32AC9E45B4A22F89FC90EC0701C3767B55@QLEXC01.Quorum.local>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [67.160.204.75] MIME-Version: 1.0 X-Rspamd-Queue-Id: 46jfbJ1nrHz4fXk X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of shiva.bhanujan@quorum.com designates 208.70.211.16 as permitted sender) smtp.mailfrom=shiva.bhanujan@quorum.com X-Spamd-Result: default: False [-1.95 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:208.70.208.0/22]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[Quorum.com]; NEURAL_HAM_MEDIUM(-0.95)[-0.954,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(0.40)[ipnet: 208.70.210.0/23(1.13), asn: 393497(0.91), country: US(-0.05)]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_LOW(-0.10)[16.211.70.208.list.dnswl.org : 127.0.3.1]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:393497, ipnet:208.70.210.0/23, country:US]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[] Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Oct 2019 02:04:45 -0000 Hi Eric, thanks for the pointer. I tried the patch and it works. regards, Shiva ________________________________ From: Eric Borisch =5Beborisch=40gmail.com=5D Sent: Tuesday, October 01, 2019 5:03 PM To: Shiva Bhanujan Cc: Fabian Keil; freebsd-fs=40freebsd.org Subject: Re: =5BZFS=5D Potential silent data corruption when receiving = incremental stream with block size change on receiving side That sounds like a potential hole birth issue. You might consider upgrading to at least 10.4 or 11.1 and re-trying the = send; these added the vfs.zfs.send_holes_without_birth_time (default = true/1) tunable to avoid =22numerous hole_birth bugs=22. See this =5B1=5D = commit. - Eric =5B1=5D = https://svnweb.freebsd.org/base/releng/10.4/sys/cddl/contrib/opensolaris/ut= s/common/fs/zfs/dmu_traverse.c?revision=3D308086&view=3Dmarkup On Tue, Oct 1, 2019 at 5:51 PM Shiva Bhanujan = > wrote: Hello, This seems to be an older email, but I seem to be hitting this in FreeBSD = 10.3. Following is the precise version - FreeBSD R530-Filer-20-194.quorum.net = 10.3-RELEASE-p29 FreeBSD 10.3-RELEASE-p29 =2312 r335461M: Wed Jun 20 = 16:11:04 PDT 2018 = root=40R520-31-232.quorum.net:/usr/obj/usr/src/sys/QUORUM amd64 When I send an incremental snapshot, the md5sum of a couple of the files = in the source and the destination don't match. The previous incrementals = don't have a mismatch. Can somebody please advise on what I should be looking for? I've checked = the URLs mentioned here. The addition or removal of the -L option doesn't = have any change. Regards, Shiva ________________________________ From: = owner-freebsd-fs=40freebsd.org = =5Bowner-freebsd-fs=40freebsd.org=5D= on behalf of Fabian Keil = =5Bfreebsd-listen=40fabiankeil.de=5D Sent: Monday, August 07, 2017 8:10 AM To: freebsd-fs=40freebsd.org Subject: =5BZFS=5D Potential silent data corruption when receiving = incremental stream with block size change on receiving side The original message is attached because it is signed. ________________________________ _______________________________________________ freebsd-fs=40freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-fs To unsubscribe, send any mail to = =22freebsd-fs-unsubscribe=40freebsd.org=22 ________________________________