From owner-svn-ports-head@FreeBSD.ORG Tue Jun 11 16:40:42 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 661D2427; Tue, 11 Jun 2013 16:40:42 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com [IPv6:2a00:1450:400c:c05::232]) by mx1.freebsd.org (Postfix) with ESMTP id 7BADE1D7F; Tue, 11 Jun 2013 16:40:41 +0000 (UTC) Received: by mail-wi0-f178.google.com with SMTP id k10so1085974wiv.11 for ; Tue, 11 Jun 2013 09:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=GziiKWP2TZO4kA7i7JYfsqdXjczzXm5sygS3WERdWuM=; b=CmUvDzbi3L3UH+T64fnCOMXDSYdrtxgoguKsVP8Oge9N4sHP5gJciVcmzbI+eRmuVq QOEacvaZncoVkIlYq6WPd7aPo9t4mZbVNX07YEce3Of6DvwZ3CY7e7HxDbmem6Emvebn jmX5MY4tb/9Hbaks/AIinw5D25EqjZTiz0rAd/WuQwasrrKEOvSt4rHqn065Wh2VUi9o sCdjPkTVL88JguEBbM/ETkF5Tx2QfhF21Zu33lynNKrX4RlwivZen7LER2WtboV8qWxR aT7+gB26cA8DwtJiO2/cTc+0yVTilSQz5v25+74CGJtBb82usztpFa4HJdgf7wCiwvwF ihdQ== X-Received: by 10.180.75.110 with SMTP id b14mr1915189wiw.6.1370968840560; Tue, 11 Jun 2013 09:40:40 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id h8sm18797609wiz.9.2013.06.11.09.40.39 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 11 Jun 2013 09:40:39 -0700 (PDT) Sender: Baptiste Daroussin Date: Tue, 11 Jun 2013 18:40:37 +0200 From: Baptiste Daroussin To: Eitan Adler Subject: Re: svn commit: r320546 - in head/devel: . tradcpp tradcpp/files Message-ID: <20130611164037.GD35160@ithaqua.etoilebsd.net> References: <201306111055.r5BAtHmb094470@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HsYKTmaHn9HHfM39" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jun 2013 16:40:42 -0000 --HsYKTmaHn9HHfM39 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2013 at 06:33:37PM +0200, Eitan Adler wrote: > On Tue, Jun 11, 2013 at 12:55 PM, Baptiste Daroussin w= rote: > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/devel/tradcpp/files/patch-directive.c Tue Jun 11 10:55:16 201= 3 (r320546) > > + static > > + void > > +-d_line(struct place *p, struct place *p2, char *line) > > ++d_line(struct place *p, struct place *p2 __unused, char *line __unuse= d) > ... > > +-d_pragma(struct place *p, struct place *p2, char *line) > > ++d_pragma(struct place *p, struct place *p2 __unused, char *line) > ... > > +-filter_output(const struct place *p, const char *buf, size_t len) > > ++filter_output(const struct place *p __unused, const char *buf, size_t= len) >=20 >=20 > Perhaps we could build without warnings instead of patching the > source? this would simplify the port and make it more obvious what is > being solved. >=20 >=20 > --=20 > Eitan Adler > Source, Ports, Doc committer > Bugmeister, Ports Security teams No patching is better, has I'm heavily working with upstream on this port. In general disable warning is something I don't like, I prefer to fix them,= and I don't find that complexify the port at all. Bapt --HsYKTmaHn9HHfM39 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlG3UwUACgkQ8kTtMUmk6EwF9wCfUEBPpXlO9/UVyecA+YYqrmp8 wpYAn2PjCzoviSJhICCMyLxa9VnaAcTY =AJxO -----END PGP SIGNATURE----- --HsYKTmaHn9HHfM39--