Date: Mon, 1 Apr 2013 18:11:36 +0200 From: Victor Balada Diaz <victor@bsdes.net> To: Stefan Esser <se@freebsd.org> Cc: freebsd-stable@freebsd.org Subject: Re: Any objections/comments on axing out old ATA stack? Message-ID: <20130401161136.GR3178@equilibrium.bsdes.net> In-Reply-To: <5159A2A8.3090705@freebsd.org> References: <51536306.5030907@FreeBSD.org> <20130331130409.GO3178@equilibrium.bsdes.net> <C699FE76-B456-49C7-8D3A-DD54F98DAFC1@samsco.org> <20130401131415.GQ3178@equilibrium.bsdes.net> <5159A2A8.3090705@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 01, 2013 at 05:07:20PM +0200, Stefan Esser wrote: > Am 01.04.2013 15:14, schrieb Victor Balada Diaz: > > Being able to configure quirks from loader.conf for disks AND controllers would be great > > and is not hard to do. If you want i can do a patch in two weeks and send it to you. That > > way it's easy to test disabling NCQ and/or other things in case of hitting a bug. Also > > being able to modify the configuration without a kernel recompile would be a big > > improvement because we could still use freebsd-update to keep systems updated. > > Something like: > > kern.cam.ada.0.quirks=1 > > to force 4KB sectors? > > No need to implement that, it is in -CURRENT (did not check -STABLE). > But there is no quirk, that disables NCQ, currently, although it is > easy to implement. See the places where "ADA_FLAG_CAN_NCQ" is set and > make that value depend on a new quirk flag being unset ... > > But instead of setting that flag in the loader, it would be good to > collect drive signatures that need it and to add quirk entries for > them in ata_da.c ... > > Regards, STefan Yep, something like that but also for controllers. Looking here[1] i don't see it implemented for controllers on current. I agree that we should collect drive and controller signatures and add that quirks to the OS, but being able to play with quirks from loader is still useful. If your FreeBSD version don't have yet the quirks needed for the disk/controller that you're using, you'd need to patch and rebuild a custom kernel. Having a loader tunable helps maintaining "old" FreeBSD versions easier. Regards. Victor. [1]: http://fxr.watson.org/fxr/source/dev/ahci/ahci.c -- La prueba más fehaciente de que existe vida inteligente en otros planetas, es que no han intentado contactar con nosotros.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130401161136.GR3178>