From owner-cvs-ports@FreeBSD.ORG Sun Sep 25 19:42:51 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E67F3106566B; Sun, 25 Sep 2011 19:42:51 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 690478FC0C; Sun, 25 Sep 2011 19:42:51 +0000 (UTC) Received: by gyf2 with SMTP id 2so4709567gyf.13 for ; Sun, 25 Sep 2011 12:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=0cUTCsXdaNROOTSURNd/JoJkxY1qaqiaKjFb3S27e4w=; b=ZJrQ0nYjDEQ47aGph0Unuw+JafeX+yx/O9DQlDhxhAP6FngBzk4FR9GNldNVJoidVa QxdgDTBBrZgKLilM12aE59Z1SER3CMR2hgHO1W62aK7FHheE1K0FtNGsnEEi0vkkCrvn USbsUIcSutV8XGkv8Cr5t0HWU5CQ2+l4DdmeU= Received: by 10.42.140.196 with SMTP id l4mr2618683icu.70.1316979770075; Sun, 25 Sep 2011 12:42:50 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.35.194 with HTTP; Sun, 25 Sep 2011 12:42:20 -0700 (PDT) In-Reply-To: References: <201109251809.p8PI97cd014112@repoman.freebsd.org> From: Chris Rees Date: Sun, 25 Sep 2011 20:42:20 +0100 X-Google-Sender-Auth: VIuyXt2SSWjxQmuYeWWYoV2u3d4 Message-ID: To: Eygene Ryabinkin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/databases/postgresql84-server Makefile ports/databases/postgresql90-server Makefile ports/databases/postgresql91-server Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Sep 2011 19:42:52 -0000 On 25 September 2011 20:41, Chris Rees wrote: > On 25 September 2011 19:09, Eygene Ryabinkin wrote: >> rea =A0 =A0 =A0 =A0 2011-09-25 18:09:06 UTC >> >> =A0FreeBSD ports repository >> >> =A0Modified files: >> =A0 =A0databases/postgresql84-server Makefile >> =A0 =A0databases/postgresql90-server Makefile >> =A0 =A0databases/postgresql91-server Makefile >> =A0Log: >> =A0PostgreSQL: unbreak GSSAPI support >> >> =A0The problem with GSSAPI without Kerberos is that configure.in has >> =A0very funny logics of choosing GSSAPI libraries: >> =A0{{{ >> =A0if test "$with_gssapi" =3D yes ; then >> =A0 =A0if test "$PORTNAME" !=3D "win32"; then >> =A0 =A0 =A0AC_SEARCH_LIBS(gss_init_sec_context, [gssapi_krb5 gss 'gssapi= -lkrb5 -lcrypto'], [], >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0[= AC_MSG_ERROR([could not find function 'gss_init_sec_context' required for G= SSAPI])]) >> =A0 =A0else >> =A0 =A0 =A0LIBS=3D"$LIBS -lgssapi32" >> =A0 =A0fi >> =A0fi >> =A0}}} >> >> =A0This makes configure to happily choose -lgssapi_krb5 when the system >> =A0has Kerberos support (NO_KERBEROS is absent), but ld's '--as-needed' >> =A0will throw this library away when no Kerberos functions are used and >> =A0linker won't produce 'postgres' binary whining about unresolved >> =A0symbols: >> =A0{{{ >> =A0cc -O2 -pipe -fno-strict-aliasing -Wall -Wmissing-prototypes \ >> =A0-Wpointer-arith -Wdeclaration-after-statement -Wendif-labels \ >> =A0-fno-strict-aliasing -fwrapv -L../../src/port -L/usr/local/lib \ >> =A0-rpath=3D/usr/lib:/usr/local/lib -L/usr/local/lib =A0-L/usr/local/lib= \ >> =A0-Wl,--as-needed -Wl,-R'/usr/local/lib' -Wl,-export-dynamic \ >> =A0[... a bunch of *.o files was stripped ...] >> =A0../../src/timezone/pgtz.o ../../src/port/libpgport_srv.a -lintl -lssl= \ >> =A0-lcrypto -lgssapi_krb5 -lcrypt -lm -o postgres >> =A0libpq/auth.o: In function `pg_GSS_error': >> =A0auth.c:(.text+0x6e): undefined reference to `gss_display_status' >> =A0auth.c:(.text+0x8e): undefined reference to `gss_release_buffer' >> =A0auth.c:(.text+0xc5): undefined reference to `gss_display_status' >> =A0auth.c:(.text+0xe5): undefined reference to `gss_release_buffer' >> =A0libpq/auth.o: In function `ClientAuthentication': >> =A0auth.c:(.text+0x82d): undefined reference to `gss_delete_sec_context' >> =A0auth.c:(.text+0x941): undefined reference to `gss_accept_sec_context' >> =A0auth.c:(.text+0x9f1): undefined reference to `gss_release_buffer' >> =A0auth.c:(.text+0xaf3): undefined reference to `gss_release_cred' >> =A0auth.c:(.text+0xb10): undefined reference to `gss_display_name' >> =A0auth.c:(.text+0xbc8): undefined reference to `gss_release_buffer' >> =A0auth.c:(.text+0x10b0): undefined reference to `gss_release_buffer' >> =A0auth.c:(.text+0x111e): undefined reference to `gss_release_buffer' >> =A0libpq/pqcomm.o: In function `pq_close': >> =A0pqcomm.c:(.text+0x105a): undefined reference to `gss_delete_sec_conte= xt' >> =A0pqcomm.c:(.text+0x107d): undefined reference to `gss_release_cred' >> =A0gmake: *** [postgres] Error 1 >> =A0}}} >> >> =A0Also, ports for PostgreSQL 8.4 and 9.0 had their >> =A0misplaced: OPTIONS came after it, so WITH_/WITHOUT_ knobs will not >> =A0be really activated. >> >> =A0PR: 160050 =A0http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D160050 >> =A0Feature safe: yes >> =A0Approved by: maintainer timeout (1 month) >> >> =A0Revision =A0Changes =A0 =A0Path >> =A01.230 =A0 =A0 +8 -4 =A0 =A0 =A0ports/databases/postgresql84-server/Ma= kefile >> =A01.224 =A0 =A0 +8 -4 =A0 =A0 =A0ports/databases/postgresql90-server/Ma= kefile >> =A01.226 =A0 =A0 +7 -0 =A0 =A0 =A0ports/databases/postgresql91-server/Ma= kefile > > Oops, it looks like this is the INDEX-breaking commit. > > If you've discovered this already, sorry to nag. > Hah, shocking timing of mine. Never mind. Chris