From owner-freebsd-bugs@freebsd.org Fri Jan 11 08:26:44 2019
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3EF21485BCD
for <freebsd-bugs@mailman.ysv.freebsd.org>;
Fri, 11 Jan 2019 08:26:44 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
[IPv6:2001:1900:2254:206a::50:5])
by mx1.freebsd.org (Postfix) with ESMTP id 4DA728EB64
for <freebsd-bugs@freebsd.org>; Fri, 11 Jan 2019 08:26:44 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: by mailman.ysv.freebsd.org (Postfix)
id 0B3561485BCC; Fri, 11 Jan 2019 08:26:44 +0000 (UTC)
Delivered-To: bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2EFE1485BCB
for <bugs@mailman.ysv.freebsd.org>; Fri, 11 Jan 2019 08:26:43 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org
[IPv6:2001:1900:2254:206a::19:3])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
server-signature RSA-PSS (4096 bits)
client-signature RSA-PSS (4096 bits) client-digest SHA256)
(Client CN "mxrelay.ysv.freebsd.org",
Issuer "Let's Encrypt Authority X3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 56CA38EB63
for <bugs@FreeBSD.org>; Fri, 11 Jan 2019 08:26:43 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
[IPv6:2001:1900:2254:206a::16:76])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client did not present a certificate)
by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id A5E4A8773
for <bugs@FreeBSD.org>; Fri, 11 Jan 2019 08:26:42 +0000 (UTC)
(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org ([127.0.1.118])
by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0B8QgjS068645
for <bugs@FreeBSD.org>; Fri, 11 Jan 2019 08:26:42 GMT
(envelope-from bugzilla-noreply@freebsd.org)
Received: (from www@localhost)
by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0B8QgGv068644
for bugs@FreeBSD.org; Fri, 11 Jan 2019 08:26:42 GMT
(envelope-from bugzilla-noreply@freebsd.org)
X-Authentication-Warning: kenobi.freebsd.org: www set sender to
bugzilla-noreply@freebsd.org using -f
From: bugzilla-noreply@freebsd.org
To: bugs@FreeBSD.org
Subject: [Bug 234846] [lagg] race condition when adding port
Date: Fri, 11 Jan 2019 08:26:42 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.2-STABLE
X-Bugzilla-Keywords:
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: alexandre.martins@stormshield.eu
X-Bugzilla-Status: New
X-Bugzilla-Resolution:
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: bugs@FreeBSD.org
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-234846-227@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 08:26:44 -0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234846
Bug ID: 234846
Summary: [lagg] race condition when adding port
Product: Base System
Version: 11.2-STABLE
Hardware: Any
OS: Any
Status: New
Severity: Affects Only Me
Priority: ---
Component: kern
Assignee: bugs@FreeBSD.org
Reporter: alexandre.martins@stormshield.eu
Greetings,
I'm facing some random crash when I'm adding a port into an LACP aggregate.
In the coredump, I found that the crash is due to a race condition when the
interface is added to the aggregate.
The condition is the following:
The thread 1 (ifconfig lagg0 laggport em0) is adding an interface to an LACP
aggregate. The code enter the function lagg_port_create in the file if_lagg=
.c.
That function "publish" an update of the interface with the following code:
/* Change the interface type */
lp->lp_iftype =3D ifp->if_type;
ifp->if_type =3D IFT_IEEE8023ADLAG;
ifp->if_lagg =3D lp;
lp->lp_ioctl =3D ifp->if_ioctl;
ifp->if_ioctl =3D lagg_port_ioctl;
lp->lp_output =3D ifp->if_output;
ifp->if_output =3D lagg_port_output;
In the thread 2, thereafter that publication, a packet come on the interface
em0, use the new state of the interface, so lagg_input_p is called. Because=
the
setup of the LACP is not finished (the call to lagg_proto_addport is after =
the
publication), the LACP code uses a NULL pointer and the kernel crashes.
Can I change the code of the lagg_port_create function and put the
"publication" of the new state of the interface at the end of the function ?
Best regards,
Alexandre
--=20
You are receiving this mail because:
You are the assignee for the bug.=