From owner-cvs-doc@FreeBSD.ORG Sat Jul 21 13:11:19 2007 Return-Path: Delivered-To: cvs-doc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2EED616A421 for ; Sat, 21 Jul 2007 13:11:19 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from raven.customer.vol.cz (raven.customer.vol.cz [195.250.144.108]) by mx1.freebsd.org (Postfix) with ESMTP id AA26013C45D for ; Sat, 21 Jul 2007 13:11:18 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from [192.168.0.23] (rb5dg130.net.upc.cz [89.176.238.130]) (authenticated bits=0) by raven.customer.vol.cz (8.14.1/8.14.1) with ESMTP id l6LDBBvk027678 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sat, 21 Jul 2007 15:11:12 +0200 (CEST) (envelope-from pav@FreeBSD.org) From: Pav Lucistnik To: chinsan In-Reply-To: <1f27304c0707210437u4c6994aeg3975a8f932645400@mail.gmail.com> References: <200707201246.l6KCkC8M062760@repoman.freebsd.org> <1184936122.13381.28.camel@pav.hide.vol.cz> <1f27304c0707200606s32541002g488f2f1a92ff8f21@mail.gmail.com> <1184937122.13381.34.camel@pav.hide.vol.cz> <1f27304c0707210437u4c6994aeg3975a8f932645400@mail.gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-Vp+uMmvgPsNeZT+2mt/H" Date: Sat, 21 Jul 2007 15:11:10 +0200 Message-Id: <1185023470.34939.13.camel@ikaros.oook.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 FreeBSD GNOME Team Port X-Spam-Score: -1.547 () AWL,BAYES_00 X-Scanned-By: MIMEDefang 2.62 on 195.250.144.108 X-Milter: Spamilter (Reciever: raven.customer.vol.cz; Sender-ip: 89.176.238.130; Sender-helo: [192.168.0.23]; ) Cc: doc-committers@FreeBSD.org, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/porters-handbook book.sgml X-BeenThere: cvs-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: CVS commit messages for the doc and www trees List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2007 13:11:19 -0000 --=-Vp+uMmvgPsNeZT+2mt/H Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable chinsan p=ED=B9e v so 21. 07. 2007 v 19:37 +0800: > On 7/20/07, Pav Lucistnik wrote: > > chinsan p=ED=B9e v p=E1 20. 07. 2007 v 21:06 +0800: >=20 > > > Since "PTHREAD_LIBS?=3D -pthread", so why we should replace it again? > > > Therefore, it was guessed as a typo of "-lpthread" instead of "-pthre= ad". > > > Because PTHREAD_LIBS =3D -pthread. :) > > > > > > > People are supposed to patch s|-pthread|${PTHREAD_LIBS}| too, because > > PTHREAD_LIBS are not guaranteed to be equal to -pthread forever. > > >=20 >=20 > So...according to what you means, > we should update the "12.12 Threading libraries" section....? This chapter you quoted is 100% correct as it is. You basically went on and gratuitously changed a REINPLACE_CMD example. The old example was just fine. > "12.12 Threading libraries >=20 > The threading library must be linked to the binaries using a special > linker flag -pthread on FreeBSD. If a port insists on linking > -lpthread or -lc_r directly, patch it to use PTHREAD_LIBS variable > provided by the ports framework. This variable usually has the value > of -pthread, but on certain architectures and FreeBSD versions it can > have different values, so do not just hardcode -pthread into patches > and always use PTHREAD_LIBS. >=20 > Note: If building the port errors out with unrecognized option > '-pthread' when setting PTHREAD_LIBS, it may be desirable to use gcc > as linker by setting CONFIGURE_ENV to LD=3D${CC}. The -pthread option is > not supported by ld directly. > " >=20 --=20 Pav Lucistnik But soft, what light through yonder window breaks? It is the East, and Juliet is the sun! Arise, fair sun, and kill the envious moon, who is already sick and pale with grief that thou her maid art far more fair than she. --=-Vp+uMmvgPsNeZT+2mt/H Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBGogXuntdYP8FOsoIRAmY+AJ9W/c0RksEduYoKDO/rRZ1O2N5weQCfck/+ LdAR9Ck23J8Pk+0DTwX90aE= =D45e -----END PGP SIGNATURE----- --=-Vp+uMmvgPsNeZT+2mt/H--