From owner-dev-commits-ports-all@freebsd.org Wed Sep 8 08:53:33 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7AD2A677725; Wed, 8 Sep 2021 08:53:33 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H4GBj2MPFz3F3y; Wed, 8 Sep 2021 08:53:33 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1631091213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bzSnDKagsFpEkWV367yut5u/Iws26nbTdIl3eqCL++8=; b=DRoXcCWQKY5XZ2oBQPyH56biZ4dQF1RUWdbz5bdJF80tYZ26LEv2gQX8vqAG0Jh5o3mDXa o5HEOdqKMazC2QOHHbEJxHDv63jbwuMxtLA92BNv6yVeHxuDVXUkp4BNG+z0uDDsT1sptH qbCp9NxLq3BWS5WkZbw9lCh6TxS88gNMZ1yXdIgzA+4cdAQF5CHJQN3hIgyriN2cGeRcpR rQASc5QPnqVOUbM+c8z8itaGm7yQ0+WFTpwho6AyzDmpDLnGiuDmP1/JhCex8tVMkRNBU2 bUjxQ3u1CoQTEUz7+7XJKJko7HVlX3lBWQ1YfMNB/83BiXPwj3rs/jVMDHS49g== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 2C5AD949E; Wed, 8 Sep 2021 08:53:33 +0000 (UTC) Date: Wed, 8 Sep 2021 08:53:33 +0000 From: Alexey Dokuchaev To: Adriaan de Groot Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c04e85e180e5 - main - graphics/luminance-qt5: adjust Eigen dependency Message-ID: References: <202109080828.1888SmeA017351@gitrepo.freebsd.org> <2865178.slGk94SIus@beastie.bionicmutton.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2865178.slGk94SIus@beastie.bionicmutton.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1631091213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bzSnDKagsFpEkWV367yut5u/Iws26nbTdIl3eqCL++8=; b=OkRgoUNMYdm3HATzAg3M0gdQSrFDaphgH1rKjQTqra76m6OEjhydr4sdWS0uA1pmkxoTFy G0ZeUFJkPXPhd2eyTLZfm88gzMX0yPm+YEl4y66kAsJUQ6r1XeSHjFcsgucbqUwrFMJ5Qw t23V06Zq0aU/mdjgdsMLVyoUNzGDDNPBNNEgBwpaguCeoKF1wpsopGlABux/uMJOTnPOcQ rBcls6h/gC03+wpLL/Wsll+6GQlVWBbohuboaOc1/UyabvTW0/I0M4EHbb/MEJfBwzYBtz FtxmMu7pMedSAmwg8N+Oltc6aopsipY6eoVBlueRtRfcauaQdJj39c2iq4wVCA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1631091213; a=rsa-sha256; cv=none; b=tFjYCStLfQrMDCUFrGAOb+j5ADpzv8yxF9tSsmSDWOuwz+VjJKUPL3EAVAg58tkGTxpwjd oiyu8EXslVobuikwrJIJnxQNbNqPKuu4m5Y3Miw3MQU1/IUXOqnS2lur5ublHkVBH8VhSv uUT0NpXKcXV6vUZ8FznBwYMncj6MhUcJIPUyJq7IGpn0mvh0awgsqABJR6xuN61kzjonyC hR1s8BoHfQK3DtHe1N69UMEMb2u4H5qh6BNSmAINgog44IwxSPMTuLU0sYE4ZT1dU894DO /rO5uRoqWfpm9DGtrrpX5vDSLQK9N+MXp+gB7os5CLlM4fPA7xZIUEUQcyoGrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 08:53:33 -0000 On Wed, Sep 08, 2021 at 10:49:45AM +0200, Adriaan de Groot wrote: > On Wednesday, 8 September 2021 10:35:35 CEST Alexey Dokuchaev wrote: > > This is wrong, I think you're confusing CMAKE_ON and > > SOME_OPTION_CMAKE_ON. > > You're right (and this reminds me how much I dislike the way our CMake > magic-helpers are documented in the porter's handbook). That's the reason why I avoid plain CMAKE_ON/OFF and always annotate CMake's data types explicitly. ./danfe