From owner-svn-ports-all@FreeBSD.ORG  Mon Jan 13 21:13:23 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0FFEBF39;
 Mon, 13 Jan 2014 21:13:23 +0000 (UTC)
Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8BAE918B2;
 Mon, 13 Jan 2014 21:13:22 +0000 (UTC)
Received: from [62.63.84.221] [62.63.84.221:39148] (HELO/EHLO
 mercury.ph.man.ac.uk, authenticated with LOGIN)
 by mail.issp.ac.ru with ESMTP/inet id s0DLDJsG074555 (using TLSv1/SSLv3,
 with cipher DHE-RSA-AES256-SHA (256 bits), verified NO)
 Tue, 14 Jan 2014 01:13:19 +0400 (MSK)
From: Max Brazhnikov <makc@freebsd.org>
To: Pietro Cerutti <gahr@freebsd.org>
Subject: Re: svn commit: r339589 - head/devel/qt4-qtsolutions-soap
Date: Mon, 13 Jan 2014 21:13:18 +0000
Message-ID: <2760333.Zqjtp1erCq@mercury.ph.man.ac.uk>
User-Agent: KMail/4.10.5 (FreeBSD/9.2-STABLE; KDE/4.10.5; amd64; ; )
In-Reply-To: <201401131154.s0DBsq00051868@svn.freebsd.org>
References: <201401131154.s0DBsq00051868@svn.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jan 2014 21:13:23 -0000

On Mon, 13 Jan 2014 11:54:52 +0000Mon Jan 13 11:54:52 2014 Pietro Cerutti wrote:
> Author: gahr
> Date: Mon Jan 13 11:54:52 2014
> New Revision: 339589
> URL: http://svnweb.freebsd.org/changeset/ports/339589
> 
> Log:
>   - USE_QT must overwrite the master port's

Hi Pietro,

This solution doesn't look good for me. I think master port should be fixed
to respect slave ports. I wouldn't break your port (sorry for that), if I had
any clue that the qt4-qtsolutions-singleapplication port is used as a master
for other ports.

Cheers,
Max

> 
> Modified:
>   head/devel/qt4-qtsolutions-soap/Makefile
> 
> Modified: head/devel/qt4-qtsolutions-soap/Makefile
> ==============================================================================
> --- head/devel/qt4-qtsolutions-soap/Makefile	Mon Jan 13 11:52:48 2014	(r339588)
> +++ head/devel/qt4-qtsolutions-soap/Makefile	Mon Jan 13 11:54:52 2014	(r339589)
> @@ -3,10 +3,10 @@
>  
>  MASTERDIR=	${.CURDIR}/../qt4-qtsolutions-singleapplication
>  
> -USE_QT4=	qmake_build moc_build rcc_build uic_build network xml gui
> -
>  .include	"${MASTERDIR}/Makefile"
>  
> +USE_QT4=	qmake_build moc_build rcc_build uic_build network xml gui
> +
>  PORTNAME=	qt4-qtsolutions-soap
>  
>  MAINTAINER=	gahr@FreeBSD.org