Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Jul 2005 05:23:27 GMT
From:      soc-cjones <soc-cjones@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 79894 for review
Message-ID:  <200507100523.j6A5NRBX029800@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=79894

Change 79894 by soc-cjones@soc-cjones_ides on 2005/07/10 05:22:31

	Flesh out the kernel side of things for 'move'.

Affected files ...

.. //depot/projects/soc2005/gvinum/docs/PLAN#4 edit

Differences ...

==== //depot/projects/soc2005/gvinum/docs/PLAN#4 (text+ko) ====

@@ -7,7 +7,9 @@
 
   - Add NOPs for _rename, _move
 
-  - _move
+  - _move 
+    (NOTE: arguments really should be 'src ... dst' for /bin/mv 
+     compatibility)
     - Identify -f flag, drive, object(s) from argv
     - Do sanity checks (is object already on drive?) [kernel-side]
     - Check whether there's free space [kernel-side]
@@ -64,8 +66,17 @@
     - Fix up references in other structures
       - for gv_drive: FOREACH subdisks, fix ->drive
       - for gv_plex: FOREACH subsdisks, fix ->plex
-    - Commit to disk
+    - Commit config to disk
 
 * Add 'move' verb to VINUM GEOM class
-
+  - use 'target', 'objectX' as verb arguments
   - int gv_move(struct g_geom *, struct gctl_req *)
+    - Find target, verify that it's a drive
+    - Find object(s)
+      - If drive, get list of drive's subdisks
+      - If plex, get list of plex's subdisks
+    - Check that sd(s) don't already belong to target drive
+    - gv_sd_to_drive
+  - How to copy data from old sd(s) to new?  gv_sync maybe?
+  - Fix up references?
+  - Commit config to disk



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507100523.j6A5NRBX029800>