From owner-cvs-all  Sat Oct 28 16:10:19 2000
Delivered-To: cvs-all@freebsd.org
Received: from feral.com (feral.com [192.67.166.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id EAA8837B4C5; Sat, 28 Oct 2000 16:10:15 -0700 (PDT)
Received: from zeppo.feral.com (IDENT:mjacob@zeppo [192.67.166.71])
	by feral.com (8.9.3/8.9.3) with ESMTP id QAA27962;
	Sat, 28 Oct 2000 16:10:16 -0700
Date: Sat, 28 Oct 2000 16:10:15 -0700 (PDT)
From: Matthew Jacob <mjacob@feral.com>
Reply-To: mjacob@feral.com
To: Mike Smith <msmith@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/pci pci.c
In-Reply-To: <200010282307.QAA12200@freefall.freebsd.org>
Message-ID: <Pine.LNX.4.21.0010281609350.6685-100000@zeppo.feral.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG




> msmith      2000/10/28 16:07:13 PDT
> 
>   Modified files:
>     sys/pci              pci.c 
>   Log:
>   Unconditionally turning on the I/O and memory enable bits in the PCI
>   command register is too aggressive.  Revert to the previous behaviour, but
>   leave the new behaviour available as an undocumented option.  It's not
>   clear what the Right, Right Thing is to do here, but the more conservative
>   approach is safer.

Uh, yeah. 

You should, IMO, let each platform decide how broken it's PCI implementations
are and have the core layers for them DTRT here.

-matt




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message