From owner-freebsd-net@freebsd.org Thu Jul 16 04:31:13 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 230BA3541D5 for ; Thu, 16 Jul 2020 04:31:13 +0000 (UTC) (envelope-from m-9xus93togkww21j8vtrid56oq4h3v723guwpcfjbfxgtt5h9ymwtuf8bj01unc@bounce.linkedin.com) Received: from maile-bf.linkedin.com (maile-bf.linkedin.com [108.174.3.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.linkedin.com", Issuer "DigiCert SHA2 Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B6hCN2qjTz3ycB for ; Thu, 16 Jul 2020 04:31:12 +0000 (UTC) (envelope-from m-9xus93togkww21j8vtrid56oq4h3v723guwpcfjbfxgtt5h9ymwtuf8bj01unc@bounce.linkedin.com) From: Kaushal Shriyan Message-ID: <370210832.1103575.1594873870905.JavaMail.app@lor1-app45412.prod.linkedin.com> Subject: Kaushal wants to connect with you on LinkedIn MIME-Version: 1.0 To: Date: Thu, 16 Jul 2020 04:31:10 +0000 (UTC) X-LinkedIn-Class: INVITE-GUEST X-LinkedIn-Template: email_m2g_invite_single_01 X-LinkedIn-fbl: m2-aszubpk5bidvre94kvg8u5ggyzuto8xotttufbdhqiqfklmcsc9f8cozu7h9kon0qq1hujjwml9k18gz61alg9maregxuw8o7sx5dh X-LinkedIn-Id: xdi44-kcoaq12z-h Feedback-ID: email_m2g_invite_single_01:linkedin X-Rspamd-Queue-Id: 4B6hCN2qjTz3ycB X-Spamd-Bar: ------------- X-Spamd-Result: default: False [-13.15 / 15.00]; ZERO_FONT(0.10)[1]; R_SPF_ALLOW(-0.20)[+ip4:108.174.3.0/24]; TO_DN_NONE(0.00)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[108.174.3.206:from]; DKIM_TRACE(0.00)[linkedin.com:+,maile.linkedin.com:+]; DMARC_POLICY_ALLOW(-0.50)[linkedin.com,reject]; NEURAL_HAM_SHORT(-0.86)[-0.864]; FORGED_SENDER(0.30)[messages-noreply@linkedin.com,m-9xus93togkww21j8vtrid56oq4h3v723guwpcfjbfxgtt5h9ymwtuf8bj01unc@bounce.linkedin.com]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:55163, ipnet:108.174.3.0/24, country:US]; FROM_NEQ_ENVFROM(0.00)[messages-noreply@linkedin.com,m-9xus93togkww21j8vtrid56oq4h3v723guwpcfjbfxgtt5h9ymwtuf8bj01unc@bounce.linkedin.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.02)[-1.023]; R_DKIM_ALLOW(-0.20)[linkedin.com:s=d2048-201806-01,maile.linkedin.com:s=proddkim1024]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; HTML_SHORT_LINK_IMG_1(2.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; NEURAL_HAM_LONG(-1.01)[-1.005]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[linkedin.com:dkim]; MANY_INVISIBLE_PARTS(0.05)[1]; WHITELIST_DMARC(-7.00)[linkedin.com:D:+]; RWL_MAILSPIKE_POSSIBLE(0.00)[108.174.3.206:from]; WHITELIST_SPF_DKIM(-3.00)[linkedin.com:d:+,linkedin.com:s:+] Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 04:31:13 -0000 ..................................... Kaushal would like to stay in touch on LinkedIn. Kaushal Shriyan Chief DevOps Architect at DigitalAPICraft Bengaluru Area, India View profile https://www.linkedin.com/comm/in/kaushalshriyan?trk=3Deml-gues= t-invite-pprofile-link-cta&trkEmail=3Deml-email_m2g_invite_single_01-null-3= 73-null-null-xdi44%7Ekcoaq12z%7Eh-null-neptune%2Fprofile%7Evanity%2Eview&li= pi=3Durn%3Ali%3Apage%3Aemail_email_m2g_invite_single_01%3B4fl5qd23REyJ4KLBJ= zP%2BpA%3D%3D Confirm that you know Kaushal https://www.linkedin.com/e/v2?e=3Dxdi44-kcoaq= 12z-h&lipi=3Durn%3Ali%3Apage%3Aemail_email_m2g_invite_single_01%3B4fl5qd23R= EyJ4KLBJzP%2BpA%3D%3D&t=3Dsuwj&tracking=3Deml-guest-invite-cta&ek=3Demail_m= 2g_invite_single_01&validationToken=3Dg72kCmBe&invitationId=3D6689383091905= 146936 ..................................... Unsubscribe: https://www.linkedin.com/e/v2?e=3Dxdi44-kcoaq12z-h&t=3Dlun&mid= Token=3DAQFmrFVhGEd36Q&ek=3Demail_m2g_invite_single_01&li=3D381&m=3Dunsub&t= s=3Dunsub&loid=3DAQEZXlREmwmCdAAAAXNV4_nzaWYVWsUTLLNfvbaQAsjPyUEQngQMKMd_1h= ZibPCqTfHZZjk3XPcNk6De7bOHSXhJcs0i8ic_JkjH7_DJgg&eid=3Dxdi44-kcoaq12z-h Help: https://www.linkedin.com/e/v2?e=3Dxdi44-kcoaq12z-h&lipi=3Durn%3Ali%3A= page%3Aemail_email_m2g_invite_single_01%3B4fl5qd23REyJ4KLBJzP%2BpA%3D%3D&a= =3DcustomerServiceUrl&ek=3Demail_m2g_invite_single_01&li=3D380&m=3Dfooter&t= s=3Dhelp&articleId=3D67 You are receiving Invitation emails. LinkedIn will use your email address t= o make suggestions to our members in features like People You May Know. This email was sent to freebsd-net@freebsd.org. =C2=A9 2020 LinkedIn Ireland Unlimited Company, Wilton Plaza, Wilton Place,= Dublin 2. LinkedIn is a registered business name of LinkedIn Ireland Unlim= ited Company. LinkedIn and the LinkedIn logo are registered trademarks of L= inkedIn. From owner-freebsd-net@freebsd.org Thu Jul 16 05:26:26 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D6DD235582B for ; Thu, 16 Jul 2020 05:26:26 +0000 (UTC) (envelope-from zec@fer.hr) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060c.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::60c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B6jR55y9Fz432n for ; Thu, 16 Jul 2020 05:26:24 +0000 (UTC) (envelope-from zec@fer.hr) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YqE4doWfTN5IJK2gudZvIVsuIeT//mE5B0K13h6bmYE6LgSklZGUyXPEF1J9/SwpcrWPAE+8fAa/9VNvJB8rGf+XQy4I80WWirORGWfjUVsyHuisDyUe/I3AA0O1mD3lnQaVKEQRPTYW3/SLlcAsK9fM0NwfgIzuthjlS8JDYmsuS0CY2/pD1fG+9m7HpqC7qS6xhKGRLDfHIoSE/RXEP9UH9TWGbDSBSohrk97eEQa0kVc1WorYneyg2mfXApBVEHjLhlb9YqWQ7+WpXB9qWg8FQy9OZ9xtk5atwcARuJnpYSuQ6j0pF+Ii7Egl1W3Kimer6SrNfmjdHaGlSwjtYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYq/e3Nx87oQyoP5MaugRq++Fz6nzx2uwNzi4t+2sZQ=; b=KQ9glLAiQwtSwIa5YnLnwFi3ecYQnkq3E/hG+QV4E7ZjMMKmkrtIvgryy7DEbPHe6HqA8BzvayJhQMrBXTYB6ljNLYxp/d/tbsP/EyClfGJaG2FjwjIan6gGvNcaBpP4u97V3irL4M1eYWELlqB+nK8kYAfJHfD/KISPkMBgHHYFFoFmnhQbgPFnD1dvIrV1FkExrePbvVMxs7GBKJWj7VVUep2IOW8QyTum81B1Rb+p8SmAz+/LatdRnQkewbdclLzzSj7/xIJJOjjPkJIE+m1hZ8pn9lbEUjjVo7dJDPUjRG9kBuQAEIB3nwo2H0b8KiepfscftCMeBR0FlxDzAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fer.hr; dmarc=pass action=none header.from=fer.hr; dkim=pass header.d=fer.hr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferhr.onmicrosoft.com; s=selector2-ferhr-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYq/e3Nx87oQyoP5MaugRq++Fz6nzx2uwNzi4t+2sZQ=; b=XvyApSiJh7R/IVkkHkrQfbu+OXzzufaB0Tm0YT63vxiHDk3MCmKgfuDnb/EXtsB0DB4Wq7wqmDrS3AAO036j/Nxh5lSF0LRcvyVcEmt4b4BDSu9IOVR+VFf108Y2DaDWyqFxcpWeBnZx8Fwd9aoGH3/BV+FjrLawd0LeE8OomCw= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) by VI1PR0801MB2111.eurprd08.prod.outlook.com (2603:10a6:800:8d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Thu, 16 Jul 2020 05:26:23 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::c8e:e335:c7:319b]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::c8e:e335:c7:319b%3]) with mapi id 15.20.3195.018; Thu, 16 Jul 2020 05:26:23 +0000 Date: Thu, 16 Jul 2020 07:26:22 +0200 From: Marko Zec To: John-Mark Gurney Cc: freebsd-net@FreeBSD.org Subject: Re: IF_DRV_PREPEND unlocked? Message-ID: <20200716072622.5fa35ba2@x23> In-Reply-To: <20200715232624.GR4213@funkthat.com> References: <20200715232624.GR4213@funkthat.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0401CA0001.eurprd04.prod.outlook.com (2603:10a6:800:4a::11) To VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x23 (31.147.103.178) by VI1PR0401CA0001.eurprd04.prod.outlook.com (2603:10a6:800:4a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend Transport; Thu, 16 Jul 2020 05:26:22 +0000 X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) X-Originating-IP: [31.147.103.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a41f5f3-69ef-4582-a688-08d82948c6fc X-MS-TrafficTypeDiagnostic: VI1PR0801MB2111: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bIi0EpBh33JTdjCkxWRYtstjCrdzbNc7dqgC+BL7crpbZ/RrG2CJR5LJ5N88e3/WeAqgY+spyKH1WDzAuzbNCcb43j8ku8y8b6NKAk1iIZe/Xvcei5fmM6gXmtsvswQYs8ZXNvPRBK2+nB/ZN+U/7RPGCkhUJ34LUEK/7j/sJoLNv7zVaKEQ2kb5/GRUHO5OO7qx4DusLBXBQr0zF3d3y3+gnhjpqaMdvJENIrZLatJuTIUNOyashIQZNDBpvfzOD6p3D+Hh8MB8V0PpTZe/+rs8lTAJPsPjY8BXibiBxe9KcOOvh19/9RrD6QQfSA30eDMKNrmWR5rWlt5Gh6sLTg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4783.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(39850400004)(396003)(366004)(136003)(26005)(956004)(1076003)(52116002)(6496006)(6916009)(9576002)(186003)(16526019)(8936002)(4744005)(83380400001)(8676002)(5660300002)(33716001)(7116003)(86362001)(2906002)(316002)(786003)(9686003)(55016002)(4326008)(66476007)(66556008)(66946007)(478600001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: MAxHTH6cPFKoNLm+FrTj7qLuIkEqi0qjjSKYJx005c3OXAxl/FAQRNjgoXzROFyCHrpMRhc1MfrvraYXg0N9EnjQydTj4jFvyr8y4fJ8+yyZoM9JsNawIvnzxfFBPB0pPzZHUBd8EUjbpK+yXk8XNEfaIoyvV1XtZH6XCqexHKsibN1B3qMn+/K5xYbou8t60yocEQR4j9It9rbaaNsrw4EHVqlFGmoEzz3ASBdlroaJwY7PZsArUmgU3h7iDNtthJqodpGmL1rTnmar4aps26yd8A8V+I+1FGim36chKbAR1igdfqXTPe/97ZyGRQbIuAg47CJyJJJRJHIj274bR6C/f12erwq5XAT348dSFGKrr9i8QJcJ6M3QUN2YK4p1mXf0ejNo/Ggv4aXs1irCt1gdh3NEQB8KvfJJcjSqKCjnb26CTSjBOxIhaAzkbhCFiTYFalbLc7yTE6Sbj34vENjR7Ab9voY3btRrZgQd2niuzi4wgyCB9EdM7nkYVrHk X-OriginatorOrg: fer.hr X-MS-Exchange-CrossTenant-Network-Message-Id: 5a41f5f3-69ef-4582-a688-08d82948c6fc X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4783.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2020 05:26:22.8484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ca71eddc-cc7b-4e5b-95bd-55b658e696be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RhqPxvpIVtiFSYNUZhXUdJJP9tMPkQAEsY87xnYwvbWIJse7180G8kqdR/M/8FpZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2111 X-Rspamd-Queue-Id: 4B6jR55y9Fz432n X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ferhr.onmicrosoft.com header.s=selector2-ferhr-onmicrosoft-com header.b=XvyApSiJ; dmarc=none; spf=pass (mx1.freebsd.org: domain of zec@fer.hr designates 2a01:111:f400:7d00::60c as permitted sender) smtp.mailfrom=zec@fer.hr X-Spamd-Result: default: False [-2.86 / 15.00]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_MEDIUM(-1.03)[-1.034]; R_DKIM_ALLOW(-0.20)[ferhr.onmicrosoft.com:s=selector2-ferhr-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a01:111:f400::/48]; NEURAL_HAM_LONG(-0.99)[-0.992]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[fer.hr]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[ferhr.onmicrosoft.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2a01:111:f400:7d00::60c:from]; NEURAL_HAM_SHORT(-0.83)[-0.832]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US]; RCVD_TLS_LAST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[31.147.103.178:received] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 05:26:26 -0000 On Wed, 15 Jul 2020 16:26:25 -0700 John-Mark Gurney wrote: > I happen to be looking at the implementation of IFQ_DRV_PREPEND, and > unlike IFQ_DRV_DEQUEUE, it doesn't obtain the lock when manipulating > the ifq. I took a brief look at a few drivers, and it looks like some > of them expect that _PREPEND lock the Q like _DEQUEUE does. > > This is likely not an issue often, since it's an error path that > likely rarely happens, but we should fix it. > > Should we just add the IFQ_LOCK/_UNLOCK to the macro? > > Comments or thoughts? I also have a hard time understanding the semantics of IFQ_DRV_* macros: per altq(9) they appear to be variants of their IFQ_ counterparts which are intended to be protected by some other mechanism rather than IFQ_LOCK, but in some instances this isn't the case, as they do grab the IFQ_LOCK. Marko