From owner-freebsd-usb@FreeBSD.ORG Tue Nov 3 10:00:15 2009 Return-Path: Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 705971065670 for ; Tue, 3 Nov 2009 10:00:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 33CB48FC1C for ; Tue, 3 Nov 2009 10:00:15 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nA3A0C63059454 for ; Tue, 3 Nov 2009 10:00:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nA3A0CnU059453; Tue, 3 Nov 2009 10:00:12 GMT (envelope-from gnats) Resent-Date: Tue, 3 Nov 2009 10:00:12 GMT Resent-Message-Id: <200911031000.nA3A0CnU059453@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-usb@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sebastian Huber Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2C111065670 for ; Tue, 3 Nov 2009 09:52:52 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id D23BE8FC18 for ; Tue, 3 Nov 2009 09:52:52 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nA39qqSM082387 for ; Tue, 3 Nov 2009 09:52:52 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id nA39qqlq082386; Tue, 3 Nov 2009 09:52:52 GMT (envelope-from nobody) Message-Id: <200911030952.nA39qqlq082386@www.freebsd.org> Date: Tue, 3 Nov 2009 09:52:52 GMT From: Sebastian Huber To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: usb/140242: dev/usb/controller/ehci_ix4xx.c shortcomings X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2009 10:00:15 -0000 >Number: 140242 >Category: usb >Synopsis: dev/usb/controller/ehci_ix4xx.c shortcomings >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-usb >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 03 10:00:12 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Sebastian Huber >Release: 9-current >Organization: embedded brains GmbH >Environment: >Description: In ehci_ixp_attach() setting of sc->sc_bus.usbrev is superfluous since this is also set in ehci_init(). Calling ehci_reset() without a valid sc->sc_offs value makes no sense. >How-To-Repeat: >Fix: Index: ehci_ixp4xx.c =================================================================== --- ehci_ixp4xx.c (revision 198848) +++ ehci_ixp4xx.c (working copy) @@ -157,8 +157,6 @@ return (ENOMEM); } - sc->sc_bus.usbrev = USB_REV_2_0; - /* NB: hints fix the memory location and irq */ rid = 0; @@ -230,7 +228,6 @@ | EHCI_SCFLG_BIGEMMIO | EHCI_SCFLG_NORESTERM ; - (void) ehci_reset(sc); err = ehci_init(sc); if (!err) { >Release-Note: >Audit-Trail: >Unformatted: