From owner-svn-src-head@freebsd.org Wed Mar 1 16:59:20 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7BF68CF190F; Wed, 1 Mar 2017 16:59:20 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0B6E8BF7; Wed, 1 Mar 2017 16:59:20 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id m70so8373841wma.1; Wed, 01 Mar 2017 08:59:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6+G+HDafH5OUZ3ohcGP1ffVces1Yf+PvyxJZwOkKBnw=; b=W6K1MT/vCBXmgm3El4vGMoDdPgqKWZMT/IlUOcjl4CSy0ChevoBqLNth44QPeMOg2G 6eOZ41+Et/Nir5ZJnIPwslrMSQc5Z3HDfiDO6f72jE7tXNTcr5v/ViLBbKcpiXek7LIV 0WGsdcbg4k1vNkKNe83cGsI9tHOPoR+8SfXCI1act7ffzuM+1KTNEzl84lVNcm/UB5Jv bnrVWvBhBuzesSyYciMr5/BG5lpe+2MEwpxjUXSYqTGMVKLOsp+C3SUs+loVO/mxnzHj Nqh3m8cly91gW/qpU439hlJwtw9oYMnzxRg3G1v9oV9dxYpggQmXn5oLafU5urYen0B2 x8hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=6+G+HDafH5OUZ3ohcGP1ffVces1Yf+PvyxJZwOkKBnw=; b=bAVKG2VT+jBFQNL/jNZHgk1J2HkVOhdv5N7dEW7FUbbGY4uT01rZciX0SAerOUy5ss o+WF3UygRnfCaved41RGWkxXTkdQthG/mAHGmQIBPOJW5jaAuYFbf2NLZB2raYFv9QpU ivgGI7jiTkU2rfNBEqd9v5xoCPcMKqWxguLlvTTsQqM2gBEPichkHfja62j+CagSU2HI DrVljwAu/bLJIB+AYKIYXXsu/e8ahQY5Mkd7guGTQSgur0aBlPALIX2M+jI6UNsz/vZY Kb1Zv0y6Rk+udgzl6zMSwMVZV29TvPiRTuobVMZVakmKBLm2MQ1B3EDYuxKlE8rE5JIG Px4Q== X-Gm-Message-State: AMke39kglOXfgz/jOR4ATQ5Z0vkgMD1MKBMWRYynjLyN4HsUzAZ2A8VF5SDfzM5LXZhTug== X-Received: by 10.28.57.131 with SMTP id g125mr4154090wma.33.1488387558488; Wed, 01 Mar 2017 08:59:18 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id z88sm7384911wrb.26.2017.03.01.08.59.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Mar 2017 08:59:17 -0800 (PST) Sender: Baptiste Daroussin Date: Wed, 1 Mar 2017 17:59:16 +0100 From: Baptiste Daroussin To: "Rodney W. Grimes" Cc: Alexey Dokuchaev , src-committers , Ian Lepore , svn-src-all@freebsd.org, "Ngie Cooper (yaneurabeya)" , svn-src-head@freebsd.org, Ngie Cooper Subject: Re: svn commit: r314464 - head/usr.sbin/yppush Message-ID: <20170301165916.kuizbr2w5l2beoac@ivaldir.etoilebsd.net> References: <20170301163050.GA81295@FreeBSD.org> <201703011643.v21GhtaI057213@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ati2n6uvzjsuspua" Content-Disposition: inline In-Reply-To: <201703011643.v21GhtaI057213@pdx.rh.CN85.dnsmgr.net> User-Agent: NeoMutt/20170206 (1.7.2) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 16:59:20 -0000 --ati2n6uvzjsuspua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 01, 2017 at 08:43:55AM -0800, Rodney W. Grimes wrote: > > On Wed, Mar 01, 2017 at 08:54:51AM -0700, Ian Lepore wrote: > > > ... > > > You're not the only one who has diffed build output logs (I suspect > > > anyone who has to maintain a non-trivial build infrastructure has done > > > so), and you're not the only one who thinks that changing relative > > > paths to absolute is a bad idea. > >=20 > > +1. Relative paths are so much nicer (and they are usually shorter as > > well). I didn't respond to these changes only because .CURDIR itself > > is expanded to a full path, so arguing if one wants some ../../ within > > what's inherently starts with a slash seems pointless. >=20 > True, in the normal use relative paths are shorter, but in how this > actually all goes about the use of ${SRCTOP} vs ${.CURDIR} yeilds > both short strings in the Makefile, and shorter output in the log. And making the logs with relative path would actually be hard given how make works or maybe I'm missing something >=20 > Your reasoning is also why I was somewhat quiet on it when I saw it > start to be merged into -stable, which was the first place I saw it. > I *thought* at that point the whole of -current had already been > converted and this was just coming over with other nearby changes. >=20 > I believe we have some other full path things that have crept > forward into the production release, but that may be in ports > only. Nope bad full paths links I found in just a few seconds: >=20 > lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 chfn -> /usr/bin/chpass > lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 chsh -> /usr/bin/chpass > lrwxr-xr-x 1 root wheel 7 Nov 30 02:27 cpio -> bsdcpio > lrwxr-xr-x 1 root wheel 21 Nov 30 02:27 mailq -> /usr/sbin/mai= lwrapper > lrwxr-xr-x 1 root wheel 21 Nov 30 02:27 newaliases -> /usr/sbi= n/mailwrapper > lrwxr-xr-x 1 root wheel 10 Nov 30 02:25 pgrep -> /bin/pgrep > lrwxr-xr-x 1 root wheel 10 Nov 30 02:25 pkill -> /bin/pkill > lrwxr-xr-x 1 root wheel 6 Nov 30 02:27 tar -> bsdtar > lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchfn -> /usr/bin/chp= ass > lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchpass -> /usr/bin/c= hpass > lrwxr-xr-x 1 root wheel 15 Nov 30 02:26 ypchsh -> /usr/bin/chp= ass > lrwxr-xr-x 1 root wheel 15 Nov 30 02:27 yppasswd -> /usr/bin/p= asswd >=20 > This breaks the abilty to mv usr/bin and have the right stuff > happen if you invoke usr/bin.moved/mailq. Almost every was with absolute path for the symlinks, we have changed "rece= ntly" most (all?) of the symlinks for libraries (.so files) into relative to be a= ble to have a proper sysroot, and yes I agree we should go further and make all= the symlinks relative which is very easy install just add the option -l sr and = magic happen :) Best regards, Bapt --ati2n6uvzjsuspua Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAli2/eEACgkQY4mL3PG3 PlrDCA/9EWm78GgYCgaRDk0Yol5nzMotpoLcH4f/A7+n6n33NKNjukgtpI+MlXHe taOU5k2cx4KQR845aBKAFzyAe1G90yoy+AW0Ib8g89IZeQcS3H1dJJsH/srMqke6 iPYsQN+MBfn5vf5JMz56BTfbzVEPpd/TVXes9DwciAKF0oH0qdNif+dYawmPZD3V EHt4IRC0tJrw1rgmLrZCPBcn6m0StSxwN20GXENyLCHOFUDsNcCMe6BaTtk2Fm+l iXfp52PYz3C9D1nSi6gdFe1kgHdVRDWeZltUnWFOuz2uN83ohmzXvJ/lqwLhaMsA I2Nx2F43+2D+hoA6CdBkFvKKKNNzD9Js0qjfz5j3TOl8H6DOlZZPE7S8SnYa7Tw0 0zViqkFAUi4tKIIg79BUZjAUNZBsNjeqCzm246i/Zn5cRviL+pSPnz9ySBSOcIQ/ SCpLmvkslFFaRt5WZBGZUq4JP2L5zVuacdvjmWU9IIfwCf9RNtqCiUEsSJrk3vHt qizj1SvQMdkqRO2lJJ3FrnGcxiTjpF245ww9qEC9HRHi5gBVTCNSg/qk9w21U3VX b/hgLH3+Ms/PNTcjNEMPbrPN4GcuLYOubug8F21tDPrBQhp65d8kAXs2IGs+E8YU lrSEcjhV6QrY9OSv91Jesx43wL8Bu9Zqywmal7wQskV0rGWk984= =pd+Z -----END PGP SIGNATURE----- --ati2n6uvzjsuspua--