From owner-svn-src-head@FreeBSD.ORG Sat Sep 15 20:59:06 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F3D84106566B; Sat, 15 Sep 2012 20:59:05 +0000 (UTC) (envelope-from tijl@coosemans.org) Received: from mailrelay007.isp.belgacom.be (mailrelay007.isp.belgacom.be [195.238.6.173]) by mx1.freebsd.org (Postfix) with ESMTP id E883A8FC1B; Sat, 15 Sep 2012 20:59:04 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmcFAJ/qVFBbsSJD/2dsb2JhbABFhUBHtgaBCIIgAQEFIzMiARALDgYECRYLAgIJAwIBAgEnHgYNAQUCAQGIAAeoC5IeiyGFVoESA45pgSCCKJNSgmg Received: from 67.34-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.34.67]) by relay.skynet.be with ESMTP; 15 Sep 2012 22:57:55 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.5/8.14.5) with ESMTP id q8FKvrWO030961; Sat, 15 Sep 2012 22:57:54 +0200 (CEST) (envelope-from tijl@coosemans.org) Message-ID: <5054EBCB.6070105@coosemans.org> Date: Sat, 15 Sep 2012 22:57:47 +0200 From: Tijl Coosemans User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:14.0) Gecko/20120804 Thunderbird/14.0 MIME-Version: 1.0 To: Eitan Adler References: <201209142347.q8ENlN7N034951@svn.freebsd.org> In-Reply-To: <201209142347.q8ENlN7N034951@svn.freebsd.org> X-Enigmail-Version: 1.4.2 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2E590DA5D730AC1A0BBA97B2" Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r240527 - head/bin/df X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Sep 2012 20:59:06 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2E590DA5D730AC1A0BBA97B2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 15-09-2012 01:47, Eitan Adler wrote: > Author: eadler > Date: Fri Sep 14 23:47:23 2012 > New Revision: 240527 > URL: http://svn.freebsd.org/changeset/base/240527 >=20 > Log: > Free memory before exiting in order to > help tools understand that we're not leaking it. > =20 > PR: bin/171634 > Submitted by: Erik Cederstrand > Approved by: cperciva > MFC after: 3 days >=20 > Modified: > head/bin/df/df.c >=20 > Modified: head/bin/df/df.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/bin/df/df.c Fri Sep 14 22:53:47 2012 (r240526) > +++ head/bin/df/df.c Fri Sep 14 23:47:23 2012 (r240527) > @@ -290,6 +290,7 @@ main(int argc, char *argv[]) > prtstat(&mntbuf[i], &maxwidths); > if (cflag) > prtstat(&totalbuf, &maxwidths); > + free(mntbuf); > return (rv); > } Freeing memory right before exiting is a waste of time. The tool shouldn't complain about it. --------------enig2E590DA5D730AC1A0BBA97B2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iF4EAREIAAYFAlBU69EACgkQfoCS2CCgtiuZlgD+IR7A62UL9tvnk1PuFF/Bx2L3 JNyU0AcPrbTnGhTSUjEA/R7sStG8AdMo4UKVZsYoqirwKMr7SgHSPgXif6qxG8zR =bQX8 -----END PGP SIGNATURE----- --------------enig2E590DA5D730AC1A0BBA97B2--