Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 15 Sep 2012 22:57:47 +0200
From:      Tijl Coosemans <tijl@coosemans.org>
To:        Eitan Adler <eadler@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r240527 - head/bin/df
Message-ID:  <5054EBCB.6070105@coosemans.org>
In-Reply-To: <201209142347.q8ENlN7N034951@svn.freebsd.org>
References:  <201209142347.q8ENlN7N034951@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help 
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig2E590DA5D730AC1A0BBA97B2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 15-09-2012 01:47, Eitan Adler wrote:
> Author: eadler
> Date: Fri Sep 14 23:47:23 2012
> New Revision: 240527
> URL: http://svn.freebsd.org/changeset/base/240527
>=20
> Log:
>   Free memory before exiting in order to
>   help tools understand that we're not leaking it.
>  =20
>   PR:		bin/171634
>   Submitted by:	Erik Cederstrand <erik@cederstrand.dk>
>   Approved by:	cperciva
>   MFC after:	3 days
>=20
> Modified:
>   head/bin/df/df.c
>=20
> Modified: head/bin/df/df.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/bin/df/df.c	Fri Sep 14 22:53:47 2012	(r240526)
> +++ head/bin/df/df.c	Fri Sep 14 23:47:23 2012	(r240527)
> @@ -290,6 +290,7 @@ main(int argc, char *argv[])
>  			prtstat(&mntbuf[i], &maxwidths);
>  	if (cflag)
>  		prtstat(&totalbuf, &maxwidths);
> +	free(mntbuf);
>  	return (rv);
>  }

Freeing memory right before exiting is a waste of time. The tool
shouldn't complain about it.


--------------enig2E590DA5D730AC1A0BBA97B2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iF4EAREIAAYFAlBU69EACgkQfoCS2CCgtiuZlgD+IR7A62UL9tvnk1PuFF/Bx2L3
JNyU0AcPrbTnGhTSUjEA/R7sStG8AdMo4UKVZsYoqirwKMr7SgHSPgXif6qxG8zR
=bQX8
-----END PGP SIGNATURE-----

--------------enig2E590DA5D730AC1A0BBA97B2--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5054EBCB.6070105>