From owner-freebsd-net  Tue Apr 25  9:36:53 2000
Delivered-To: freebsd-net@freebsd.org
Received: from luxren2.boostworks.com (luxren2.boostworks.com [194.167.81.214])
	by hub.freebsd.org (Postfix) with ESMTP
	id 99CCD37BDE6; Tue, 25 Apr 2000 09:36:35 -0700 (PDT)
	(envelope-from root@boostworks.com)
Received: from boostworks.com (root@oldrn.luxdev.boostworks.com [192.168.1.99])
	by luxren2.boostworks.com (8.9.1/8.9.1) with ESMTP id SAA40157;
	Tue, 25 Apr 2000 18:32:59 +0200 (CEST)
Message-Id: <200004251632.SAA40157@luxren2.boostworks.com>
Date: Tue, 25 Apr 2000 18:33:07 +0200 (CEST)
From: Remy Nonnenmacher <remy@boostworks.com>
Reply-To: remy@boostworks.com
Subject: Re: Proposal for ethernet, bridging, netgraph
To: csg@waterspout.com
Cc: archie@whistle.com, julian@elischer.org, pavel@alum.mit.edu,
	nsayer@sftw.com, luigi@FreeBSD.ORG, freebsd-net@FreeBSD.ORG
In-Reply-To: <20000425105926.A518@waterspout.com>
MIME-Version: 1.0
Content-Type: TEXT/plain; CHARSET=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On 25 Apr, C. Stephen Gunn wrote:
> On Mon, Apr 24, 2000 at 07:14:44PM -0700, Archie Cobbs wrote:
> 
>> OK, here's a patch ready for review & test.. this patch does one
>> thing, which is move the calls to BPF and BRIDGE'ing out of each
>> Ethernet driver and into ether_input().
> 
> Why not also modify ether_input() to remove the Ethernet header
> when appropriate?  Instead of the monkey business to add the Ethernet
> Header back on.
> 
> There are a couple of places in ether_input() that do this already,
> and you're proposing another for passing the packet to bpf.
> 
> I proposed this a few weeks ago, but never cleaned up my patch
> for submission.  <sigh>
> 
> It would certainly prevent some of the kludges to deal with the
> Ethernet Header for things that want a peek at it, like VLANs.
> 

That's correct. the patch break the bridging due to the ether header
ripping. It would be preferable (at least for speeding up bridging) to
adjust the packet after all bridging/BPF stuff.

RN.
ItM




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message