From owner-cvs-all Thu Nov 29 15:47:52 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id A0D3C37B416; Thu, 29 Nov 2001 15:47:47 -0800 (PST) Received: (from luigi@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id fATNllI06694; Thu, 29 Nov 2001 15:47:47 -0800 (PST) (envelope-from luigi) Message-Id: <200111292347.fATNllI06694@freefall.freebsd.org> From: Luigi Rizzo Date: Thu, 29 Nov 2001 15:47:47 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/pci if_dc.c if_sis.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG luigi 2001/11/29 15:47:47 PST Modified files: sys/pci if_dc.c if_sis.c Log: Per jlemon request, reintroduce some printf() when an mbuf allocation fails, and fix (i hope) a couple of style bugs. I believe these printf() are extremely dangerous because now they can occur on every incoming packet and are not rate limited. They were meant to warn the sysadmin about lack of resources, but now they can become a nice way to panic your system under load. Other drivers (e.g. the fxp driver) have nothing like this. There is a pending discussion on putting this kind of warnings elsewhere, and I hope we can fix this soon. Revision Changes Path 1.60 +8 -3 src/sys/pci/if_dc.c 1.39 +8 -3 src/sys/pci/if_sis.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message