From owner-freebsd-bugs  Thu Apr 25 16:30:13 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id F0C5E37B422
	for <freebsd-bugs@hub.freebsd.org>; Thu, 25 Apr 2002 16:30:02 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g3PNU2V02686;
	Thu, 25 Apr 2002 16:30:02 -0700 (PDT)
	(envelope-from gnats)
Date: Thu, 25 Apr 2002 16:30:02 -0700 (PDT)
Message-Id: <200204252330.g3PNU2V02686@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Gregory Carvalho <GregoryC@stcinc.com>
Subject: Re: bin/37013: ls directory name output trailing slash duplcation- PATCH
Reply-To: Gregory Carvalho <GregoryC@stcinc.com>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR bin/37013; it has been noted by GNATS.

From: Gregory Carvalho <GregoryC@stcinc.com>
To: Maxim Konovalov <maxim@macomnet.ru>
Cc: bug-followup@freebsd.org
Subject: Re: bin/37013: ls directory name output trailing slash duplcation- PATCH
Date: Thu, 25 Apr 2002 16:25:45 -0700

 Maxim Konovalov wrote:
 > 
 > Have you seen bin/33187?
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/33187
 
 I apologize for my oversight. Perhaps the compact patch I provided sufficiently
 addresses the concerns expressed in the thread related to bin/33187.
 
 1) Color settings remain unaffected by bin/37013.
 2) The code style of bin/37013 maintains consistency with the original ls.c.
 3) bin/37013 doesn't break ``ls -dF /''.
 4) Symlinks operate properly with bin/37013.
 5) While bin/37013 does not truncate the output of ``ls -dF
 /usr////////////////'' to /usr/, it resrticts ls(1) from appending an
 additional, illegitimate /.
 6) bin/37013 is a minimal patch, and I anticipate negligible performance impact;
 in other words, bin/37013 could still be interpreted as "overloading" the
 utilites.
 
 I recognize bin/33187 addressed some of these issues, but, in my opinion, item 5
 above is the weakest link for bin/37013.
 
 With respect,
 Gregory Carvalho

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message