From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 13 15:50:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 346531065687 for ; Wed, 13 Aug 2008 15:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 19B478FC17 for ; Wed, 13 Aug 2008 15:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m7DFo1Zb098249 for ; Wed, 13 Aug 2008 15:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m7DFo1eZ098248; Wed, 13 Aug 2008 15:50:01 GMT (envelope-from gnats) Resent-Date: Wed, 13 Aug 2008 15:50:01 GMT Resent-Message-Id: <200808131550.m7DFo1eZ098248@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B90201065678 for ; Wed, 13 Aug 2008 15:42:37 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [217.170.79.85]) by mx1.freebsd.org (Postfix) with ESMTP id 8169A8FC14 for ; Wed, 13 Aug 2008 15:42:37 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1KTIUg-0000p9-VO for FreeBSD-gnats-submit@freebsd.org; Wed, 13 Aug 2008 19:42:39 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 2784C8FA4 for ; Wed, 13 Aug 2008 19:42:36 +0400 (MSD) Received: by hades.panopticon (Postfix, from userid 1000) id B85A51702D; Wed, 13 Aug 2008 19:42:34 +0400 (MSD) Message-Id: <20080813154234.B85A51702D@hades.panopticon> Date: Wed, 13 Aug 2008 19:42:34 +0400 (MSD) From: Dmitry Marakasov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/126507: [PATCH] bsd.cmake.mk: set CMAKE_BUILD_TYPE to "" X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dmitry Marakasov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 15:50:02 -0000 >Number: 126507 >Category: ports >Synopsis: [PATCH] bsd.cmake.mk: set CMAKE_BUILD_TYPE to "" >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Aug 13 15:50:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 7.0-RELEASE-p1 i386 >Organization: >Environment: System: FreeBSD hades.panopticon 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #1: Wed Jun 25 15:36:22 MSD 2008 root@hades.panopticon:/usr/obj/usr/src/sys/HADES i386 >Description: CMake has several build types, and (I think that appeared in 2.6.1) adds stuff to {C,CXX}FLAGS depending on buildtype. >From /usr/local/share/cmake/Modules/Platform/gcc.cmake: SET (CMAKE_C_FLAGS_INIT "") SET (CMAKE_C_FLAGS_DEBUG_INIT "-g") SET (CMAKE_C_FLAGS_MINSIZEREL_INIT "-Os -DNDEBUG") SET (CMAKE_C_FLAGS_RELEASE_INIT "-O3 -DNDEBUG") SET (CMAKE_C_FLAGS_RELWITHDEBINFO_INIT "-O2 -g") Currently, buildtype is set to Release, so `-O3 -DNDEBUG' is unconditionally added to cflags, which is, of course, very bad. Thus, hardcode CMAKE_BUILD_TYPE to "", so cmake doesn't ever tamper with cflags set by the ports system. >How-To-Repeat: >Fix: --- bsd.cmake.mk.patch begins here --- Index: bsd.cmake.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.cmake.mk,v retrieving revision 1.2 diff -u -r1.2 bsd.cmake.mk --- bsd.cmake.mk 10 Aug 2008 15:43:46 -0000 1.2 +++ bsd.cmake.mk 13 Aug 2008 15:35:02 -0000 @@ -47,12 +47,11 @@ -DCMAKE_C_FLAGS:STRING="${CFLAGS}" \ -DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}" \ -DCMAKE_INSTALL_PREFIX:PATH="${CMAKE_INSTALL_PREFIX}" \ - -DCMAKE_BUILD_TYPE:STRING="${CMAKE_BUILD_TYPE}" + -DCMAKE_BUILD_TYPE:STRING="" # # Default build type and sourcedir # -CMAKE_BUILD_TYPE?= Release CMAKE_SOURCE_PATH?= . CMAKE_INSTALL_PREFIX?= ${PREFIX} --- bsd.cmake.mk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: