From owner-freebsd-emulation@FreeBSD.ORG Sat Jul 29 10:09:05 2006 Return-Path: X-Original-To: freebsd-emulation@freebsd.org Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6CC516A4E1 for ; Sat, 29 Jul 2006 10:09:05 +0000 (UTC) (envelope-from mag@intron.ac) Received: from mail.oreilly.com.cn (oreilly.com.cn [211.154.219.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id A306443D46 for ; Sat, 29 Jul 2006 10:09:04 +0000 (GMT) (envelope-from mag@intron.ac) Received: from origin.intron.ac ([210.51.165.237]) (AUTH: LOGIN intron) by mail.oreilly.com.cn with esmtp; Sat, 29 Jul 2006 18:08:58 +0800 id 000C9458.44CB33BD.000027D9 References: <1153994127.11460@origin.intron.ac> <20060728093647.GA32168@stud.fit.vutbr.cz> In-Reply-To: <20060728093647.GA32168@stud.fit.vutbr.cz> From: "Intron" To: Divacky Roman Date: Sat, 29 Jul 2006 18:05:47 +0800 Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312"; format=flowed Content-Transfer-Encoding: 7bit Message-Id: <1154167741.55639@origin.intron.ac> Cc: alexander@leidinger.net, freebsd-emulation@freebsd.org Subject: [Updated on 2006-07-29] Re: My Linux AIO Implementation Calling for Test X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jul 2006 10:09:05 -0000 Download: http://ftp.intron.ac/tmp/linux_aio-20060729.tar.bz2 1. Use LMSG(). 2. I wonder whether ARGS() is handy enough. Instead, the keyword __func__ instituted by ISO C99 should be used. See my DARGPRINTF(). 3. Some modifications for style(9). ------------------------------------------------------------------------ From Beijing, China Divacky Roman wrote: > On Thu, Jul 27, 2006 at 05:44:01PM +0800, Intron wrote: >> Download: http://ftp.intron.ac/tmp/linux_aio-20060727.tar.bz2 >> >> Based on FreeBSD aio(4), my patch set has implemented 5 system calls >> of Linux Asynchronous Input/Output: io_setup(2), io_destroy(2), >> io_getevents(2), io_submit(2) and io_cancel(2). It only works with >> 7.0-CURRENT. > > havent studied details but here are my suggestions: > > 1) please conform to style(9) > > 2) please use LMSG, ARGS macros to be conform with the rest of the linuxolator > > 3) why do you use uma directly? linuxolator uses malloc from within M_LINUX. I > personally dont mind using uma zone directly but if there is a reason for it. > > thnx for your contribution! > > roman