From owner-freebsd-net@FreeBSD.ORG Sun Nov 21 19:18:45 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ABF5F106566C for ; Sun, 21 Nov 2010 19:18:45 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 39BCF8FC12 for ; Sun, 21 Nov 2010 19:18:44 +0000 (UTC) Received: by bwz2 with SMTP id 2so5670594bwz.13 for ; Sun, 21 Nov 2010 11:18:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:user-agent:mime-version:content-type; bh=NHLGrFonkXKoeiIXP6Xo/k1bJeC3aELJUHfpMzG4RK8=; b=Gj+sORrfUGz+SiXiIEyNPZftbQpR1cYtm3OrX2AaqkK67jxnADrQ6uONUtkLEITEra Vg70ST/LznZhoBcMmdUvxWsbz8gvMYSjyIkm44Lu65JuFYlF6qOS88VBD88EXiJhpzuG qfZ2XCWT3Zt4ok1U9YkTm3feVO288f6LaeI3k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; b=FIzKMsVsXKpeiLiEOIHS60xb5O59T2pke+VYdIfZLU2tmdJ1WqFY3np/LjRFGjYYn8 kmAG6Up9rls7gF5Q6JC6yCvedzDfAO43L45JY4PNqcyhpBvKy+k1oC7gwx0aodCejORy U2Oov2yGb9/DUHrdVoDhsjr1FaAGsmoQesMGc= Received: by 10.204.129.210 with SMTP id p18mr4372979bks.85.1290365286559; Sun, 21 Nov 2010 10:48:06 -0800 (PST) Received: from localhost ([95.69.174.185]) by mx.google.com with ESMTPS id p34sm1978764bkf.15.2010.11.21.10.48.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 21 Nov 2010 10:48:05 -0800 (PST) From: Mikolaj Golub To: freebsd-net@FreeBSD.org Date: Sun, 21 Nov 2010 20:48:03 +0200 Message-ID: <86aal28qe4.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Cc: Subject: net/if_epair.c: semicolon missed X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2010 19:18:45 -0000 --=-=-= Hi, In net/if_epair.c semicolon is missed in epair_nh_drainedcpu() (see the patch below). This shows up when compiling with EPAIR_DEBUG. Also, what was a reason to declare epair_debug mib as XINT? Shouldn't be just INT? -- Mikolaj Golub --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=if_epair.c.patch Index: sys/net/if_epair.c =================================================================== --- sys/net/if_epair.c (revision 215576) +++ sys/net/if_epair.c (working copy) @@ -305,7 +305,7 @@ epair_nh_drainedcpu(u_int cpuid) if ((ifp->if_drv_flags & IFF_DRV_OACTIVE) != 0) { /* Our "hw"q overflew again. */ - epair_dpcpu->epair_drv_flags |= IFF_DRV_OACTIVE + epair_dpcpu->epair_drv_flags |= IFF_DRV_OACTIVE; DPRINTF("hw queue length overflow at %u\n", epair_nh.nh_qlimit); break; --=-=-=--