From owner-freebsd-arch@freebsd.org Thu Feb 14 21:47:28 2019 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 339FF14E2F01 for ; Thu, 14 Feb 2019 21:47:28 +0000 (UTC) (envelope-from johalun0@gmail.com) Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D33CC8D5E2 for ; Thu, 14 Feb 2019 21:47:26 +0000 (UTC) (envelope-from johalun0@gmail.com) Received: by mail-ot1-x342.google.com with SMTP id i5so13138010oto.9 for ; Thu, 14 Feb 2019 13:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Sccg4DIZjmUqIHgrd1gyONzite+uGUiq4jMtLkHqM5U=; b=Zphv9PrGyLSWNlxbcKcD9Xb2uQ5ZB1I09K6nni/Lx5NgaUkCoCg2qzwwjwrKHoba1y okDadilFubkZI/nmfYsXrRgrFVM9nLmC6nLu3MYYsno/TIpdwCOm2PZd0Wy1Bwbxsb4X leQqemcG+9HT+OsMPmKToIwyCPG9sng8WOlRmYgUEW8pCLxMY+h3F+Pqz1sHaYTVfybf dq9W/9ShwKM1pp4WrpQEpf2r7YJO9gl8rKEMR/Yq3MQPKPlaV9OeyPT/gnWng6pt1A4l y8NIo3YBFefFIIWrl6WZniRkwQIt4y1QbSyMdoSkssBS2erqBffS+xydWflo3zZVcxHA qJZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=Sccg4DIZjmUqIHgrd1gyONzite+uGUiq4jMtLkHqM5U=; b=F8xtMSQDD97gQtuYNOXc35Agk7R1wiTrjxvy8BuwEQCiCmCGkSJVM7KIHRTZB3e9LC /+dSeY8qofn3Xw1ISsDYTOXYeb6Zzctez7rQe/gQvXWZdJEEiU3PKCyAKt8IUsQCtAM5 5/NyDyCjYJpKFDfcBEHemMAXc3mlvWbxU/hVpX6O1JEy613lpIluaFd0XDaUAgxH8Ya0 VSVKqUVVdjxvWddtmvxhalh+qGrJEF0itUX+JtFOgDnXj5eLVWh7LLpmRw0elsFBB/Fx VsAxEq7BW3asUniDZbpPugQV5lGSJa8LoQa2YdLy5zBZawPd3oVYukbQGUddJ/SuI51F JnbQ== X-Gm-Message-State: AHQUAubJZ04LcYQu8yGqKGEKI+z5pePFwMYLdloFvPTEWo1TZvHUuKVY Fy+LzrzD1y0D+EkdpsrAd/v5Oy2v X-Google-Smtp-Source: AHgI3Iatk9YP+53zebKwuYGsaDTwwDXit7BcEUDFdWGivTSbXE6AaSLmuV413DbMI77hdgxmbyPSIQ== X-Received: by 2002:aca:5284:: with SMTP id g126mr3803241oib.31.1550180845562; Thu, 14 Feb 2019 13:47:25 -0800 (PST) Received: from [192.168.1.33] ([81.174.250.12]) by smtp.gmail.com with ESMTPSA id p24sm1428823otl.64.2019.02.14.13.47.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 13:47:24 -0800 (PST) Subject: Re: "DRM removal soon" is premature To: freebsd-arch@freebsd.org References: <20190214180101.GB67712@troutmask.apl.washington.edu> <20190214182419.GA67872@troutmask.apl.washington.edu> <20190215065959.S4212@besplex.bde.org> From: Johannes Lundberg Openpgp: preference=signencrypt Autocrypt: addr=johalun0@gmail.com; keydata= mQINBFxFmoIBEADoFO5jY+Fmsg44KiZjufEmpEf4kt7nCOfxNG9SruWpoXUaq0B296F+fIZC hNZqv1v7lGTsfoWRusxJmLd5CQgHHxEyruZbbPpNsQ/JKoDY3GGmrmWfN/SX3y0t0kdB9HsW mJcvZhK7we52f4gxddIVBS9nQoVoONX+hzXf8zwOAa0ik0EPgEwpIKS4j9lLq4bU+mqVKdRR bPeDujEA/qbsCKhaFJkPzXZtzEe6srq4RK1doEztwnKz02b+8gs642TRkWDQeTRZputrAaoN Un4R76A1QpXWyrFG1dQu48IGHi3KbkrvNyq6R1aUBIA0+CG1npIbxmc2mtSjoyvdipmDRbBD +mhECIxmYfBT6818zuj91XjrfOyfVdV2BryBvqFkJLkS3N3QElBIiVdDgdrqiNFWiOlDMxNI tdP16oQBNo8IB27/0YHpnQEw1MafZv5gG5DO0zLtLy88ASAfL7BYf90JP19rT4JIwnxsXxyv kEJnzhsXf0QVObEiAu1MqeFyWfZ8PpunmvEmJ0VChOL+v/kIx1E9cxhhzMZhqiMXfyM4zx2+ BF1FwAwJYPuJLu2B3L0uVBu+M1YvSOmKAbXPDP8PsqPjgSBTYI51MUjuuxN6jSsHDuK6G5k4 pUWR8axa+wafhd6Vz8zVwdTJZ9LdxgLLVg0kprBgccPHhPAZVQARAQABtCZKb2hhbm5lcyBM dW5kYmVyZyA8am9oYWx1bjBAZ21haWwuY29tPokCVAQTAQgAPhYhBIl1Pb3+hI60ivmRSULn yG4BGvSeBQJcRZqCAhsjBQkJZgGABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEELnyG4B GvSe9O0P/RzeQAu1R37RlONZTXNn+qIAHvHbZEhzrCibzaZnwYdC31wGrYmXNDyiQIqOngFf QJuufQtH/+95OESJsjR+42L/pNfFdaEWxiI003qE7uCMzLK5UWUXd/5d5vYY0CaPyNCj1tyM ZIq7x4CaR3QLTh/Fw4zMUI/ZPH2S5SxVFGv0ZZFAdNYILD3qCkAS/9HmXsqufBWbfutA8TTf wyJfywmvf7ENjlZ4QOjb242ZY9NndqbmqTgWVAws+PN5e9AT8HkadscCTCSkYnxJyYG2El27 DpAAkekYplb/C0j82KSz2fy9RgwD+tTqt88DJOeFbIbrYt44u7KLHpzaZeqyUtn0reHCkE0W lnKH2kXXbuswFB4sONxI/J5+qSmOsAm5ItO3voyjm/swpmFR1yBlxo4th26gbO5NfBOK9YsY zHKgiRDv6ZdnHo+htphRxcCDHsFPzkQe5jouI25dvMZYl1LaTS/09lwYVwVIB2SFmMtFZ7rB N4NBSzPlpsg+g4dJNqiw6Rfa2Q/wUv+MzTJgLtHjDccXlpm33Nc09UytHFtNn26PO/zrM39r TwzdLu1mg0x2WWEWTIqe4CaczQU9SIg49BSyJNoPSZx3V7nMhTKbOeQKR5aV3dXI66aENw86 pa1tipuUKCPmope/GTJatUgPiD3JkyiD+7c1zQX2UAGmuQINBFxFmoIBEACb55RAkM59huAx 4Ddd8WBjsw25qf7rzxeRKAQ7or/8LvJBYQDPXZy0RhkRiu+P+MjxwGb6HVh+LDyAYDn9d8Mt ZqCP/dOGNcl7pkb6IhfRc3i5neckXCYfbm0cigiX9JkqZSt3KT96zbjCxsFZKyIyEFsMl46q 7wKWK5Irj3zxV/Z51JNTJyMLcIRWhY8G6qlMNFgZkz2Hv63w6BRekKVImOmOdThLAscy5ybq 2CIUeAwPG7lMYG9rgcPdn3tMPeWlLmUmi5pSwOQ3AKg3xFrW3WfegjRHdqpeuXoeTjYPPCW4 gyl59uv6E12a6eivItCxj67vlBXgOr4um+zoPyXG/WfidIFtWaEgyBrlGR1Klk7SIcqjEHUA FdiM+PweY4opHXXKn60NOZCqBJ59K43drOQgRouz8E2T3yEoYg40xAfY3lhJV/Vx5+kSTjmy sT2xotlPn/GzfaAEvNuJDK+Mec3LvfbbDoOWFolNyEvoMQqF5Q3A8eGqYsoVGBPxyzNvF2iY LkymxiXpgrSN0Q/LOK7pFlWwbVC8Z6g5I0J9ecgD55dGLoX2luLir787XX/JxGffzbRnP9NE ifenJGrQmx4CyEaz/CHQqSbROm5Uo/YFUX9J7OfUO4mtu90j773j32I3psey/Fz3EC/A2PHv Ghb0KsWYpS3Pj5TV1gGyswARAQABiQI8BBgBCAAmFiEEiXU9vf6EjrSK+ZFJQufIbgEa9J4F AlxFmoICGwwFCQlmAYAACgkQQufIbgEa9J7qOQ//YG/4e69YTSjtiYLXzBI8tRU2Sx+NFByx zx+C/r0EBThLtgRwCqEUZRB7iIDSO8aZ0Qa3vwWRohlD1tn/LBdDFfMmuQkNVdLIrjBoGBB9 B5xHdZJ9xnTZEwpTtk6IWolT4j+8rpGemGKKiFo3X6l02On4Qb4iM7h6rcDb76mfwooNYzB3 8PPcLvyOWb/9iCXAb5N7doo5zmOl15DVwvIF04eXU0q1FFj/iS1zNmtZ5Got82O1TQFV+de4 Rb3YA80IZhhhCiHHJqkMKeKQogRqU+UNDBARUBxfUtKsJtQzTQ2JUGwkb6X6bx53FTLP6O9q hDoODVweE1LdB1k1H5Nn+gawPdRMBqj43Y2amK7KEgoTBrwU04CLpKiaAC0S+EcJFfJcwtpK k3F+uTtP/hnhFnWbn8SgRkHKXKWqSCt63NstXhMzAJut1gEzV+CcPNKqa/sFgQaYEvzCS5Kl F/PXj0++f3TIFqT+2ZNNp8Bz8dT7gh8RPPg5oYQiCHH8K1RAmq7gKqmwyg0qgOazHnped+od X4f3qx320JAP6NP9wglDm6eht48NJzb0sffN8z34wrP66oz8oPKtS5CFV0m/384hEg0lmi3W wo2Hno7rA1etTPJX0dI6/GLlQDtNTHvKQ077HQdWVOMQVWC9j7YH7Zr9NjtOvxcNVRX3fxpJ 6CE= X-Tagtoolbar-Keys: D20190214214722429 Message-ID: <62d87c2d-2535-9bdd-c4c8-6a74121518a9@gmail.com> Date: Thu, 14 Feb 2019 21:47:22 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190215065959.S4212@besplex.bde.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspamd-Queue-Id: D33CC8D5E2 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Zphv9PrG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of johalun0@gmail.com designates 2607:f8b0:4864:20::342 as permitted sender) smtp.mailfrom=johalun0@gmail.com X-Spamd-Result: default: False [-3.45 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.30)[-0.299,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(-0.14)[ip: (3.90), ipnet: 2607:f8b0::/32(-2.56), asn: 15169(-1.98), country: US(-0.07)]; RCVD_IN_DNSWL_NONE(0.00)[2.4.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 21:47:28 -0000 On 2/14/19 8:20 PM, Bruce Evans wrote: > On Thu, 14 Feb 2019, Warner Losh wrote: > >> On Thu, Feb 14, 2019 at 11:24 AM Steve Kargl < >> sgk@troutmask.apl.washington.edu> wrote: >>> ... >>> The in-tree version does not compile because someone disconnected >>> drm2 from the build.=C2=A0 r342567 would not have happen if drm2 was >>> not disconnected. >> >> Technically, it's just off by default. It's still connected to the >> build. >> We just don't have a good way to lint the code, as drm isn't in i386 >> NOTES. > > It is also only built in the modules tree if MK_MODULES_DRM2 is set (wi= th > further convolutions for MACHINE_CPU_ARCH).=C2=A0 This is apparently no= t > set set > by default or forced for universe, so drm2 doesn't get tested by univer= se > either, and even extensively tests for changes like r343567 don't notic= e > when they break it. We are working on getting CI to build and test-load kmod ports on changes in base that might cause breakage (mostly vm sub system) as soon as they are committed. > >> You might try this fix instead, though I don't think it will matter. I= >> think the breakage you're seeing is a result of a subtle dependency >> in the >> drm2/ttm code with FreeBSD's vm system. Even had it been connected to >> the >> build and fixed at the time, I don't think it would have mattered. > > Another bug in the module is that it has no man pages.=C2=A0 I used kld= load > to find its dependencies.=C2=A0 i915kms didn't seem to depend on ttm. > >> diff --git a/sys/dev/drm2/ttm/ttm_bo.c b/sys/dev/drm2/ttm/ttm_bo.c >> index 010afe6d8b3b..20083ff0fb53 100644 >> --- a/sys/dev/drm2/ttm/ttm_bo.c >> +++ b/sys/dev/drm2/ttm/ttm_bo.c >> @@ -1498,11 +1498,11 @@ int ttm_bo_global_init(struct >> drm_global_reference >> *ref) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tries =3D 0; >> retry: >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 glob->dummy_read_page =3D vm_page= _alloc_contig(NULL, 0, req, >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 1, 0, VM= _MAX_ADDRESS, PAGE_SIZE, 0, VM_MEMATTR_UNCACHEABLE); >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 1, 0, 0x= fffffffful, PAGE_SIZE, 0, VM_MEMATTR_UNCACHEABLE); >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (unlikely(glob->dummy_read_pag= e =3D=3D NULL)) { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 if (tries < 1 && vm_page_reclaim_contig(req, 1, >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0, VM_MAX_ADDRESS, PAGE_SIZE, 0))= { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0, 0xfffffffful, PAGE_SIZE, 0)) {= >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tries++; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto retry; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 } > > I used VM_MAX_KERNEL_ADDRESS.=C2=A0 kib said that it should be more rel= ated to > bus spaces.=C2=A0 0xfffffffful seems just wrong on amd64. > >> Since that will eliminate the possibility that PAE is defined and >> giving a >> bigger max. Though it also likely won't matter if you have < 4GB of >> RAM in >> your machine. Obviously, this patch is not committable, but if it >> works it >> tells us something. > > r343567 gives most of PAE including its slowness, but doesn't give > full PAE > due to problems with device addresses. > >> But as I said, I doubt this will work as there's something subtle >> (likely >> the size of a variable or struct element) in ttm that's now out of syn= c. > > I see what look like subtle vm problems (a few frame buffer pages > mismapped), but they are the same as a couple of years ago, and I don't= > have any devices mapped above 4G on i386. > > Bruce > _______________________________________________ > freebsd-arch@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"=