From owner-svn-src-all@FreeBSD.ORG Thu Aug 22 10:07:04 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 28FA4D6C for ; Thu, 22 Aug 2013 10:07:04 +0000 (UTC) (envelope-from mailer-daemon@vniz.net) Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B39C32ED0 for ; Thu, 22 Aug 2013 10:07:03 +0000 (UTC) Received: by mail-ee0-f44.google.com with SMTP id b47so803635eek.3 for ; Thu, 22 Aug 2013 03:06:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:openpgp:content-type :content-transfer-encoding; bh=qCMOGWCpLQLRSJlWy2A2M8oXc6/uZoesOaLH+Otb4bY=; b=d4r9HInK5x5kuJMu+IrOVtHHfycgeNmdysTs9Nj0wK9N2qe6R0WeeaKeTxJ32WsPxX k5idoKtILfSlqY7qxl/szTUdrcC97olDuklux1hCMR9pEaOws+BDlRedgMkQivLzx+dw spK4litogdwDgynube/f0mpL/wOTnLncpSDqcuJhtz0zVLTBnkZgBpfPk/VTdSymS4nN dyfCmUkvv7R9MmAkX7cRGoh1QBn9sZyjbDNzeDDP3yKGHJ+h0I0nh1X8EvLUFqiAauIG FYr6q3Q/NF0J2nONb9WeuuoVNINI8LSD9VzeGTQ1FOXI7Nme9uUaul+TvQkFM5ba111o tdtg== X-Gm-Message-State: ALoCoQlbOms8Z7ttImVymsw0hPvbDEtjgsEIAffERoFXLHjzR9oDu7YYt6fkWfFINepNGxb9sUvn X-Received: by 10.14.115.133 with SMTP id e5mr17642449eeh.27.1377166015729; Thu, 22 Aug 2013 03:06:55 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id b45sm16400984eef.4.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 22 Aug 2013 03:06:55 -0700 (PDT) Message-ID: <5215E2BC.3070904@freebsd.org> Date: Thu, 22 Aug 2013 14:06:52 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Jilles Tjoelker Subject: Re: svn commit: r254600 - head/lib/libutil References: <201308211646.r7LGk6eV051215@svn.freebsd.org> <5214F72B.7070006@freebsd.org> <20130821190309.GB52908@omg> <20130821202725.GA4991@stack.nl> <20130821212413.GC52908@omg> <20130821213755.GA8052@stack.nl> <5215E16E.4080207@freebsd.org> In-Reply-To: <5215E16E.4080207@freebsd.org> OpenPGP: id=964474DD Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Sergey Kandaurov , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Aug 2013 10:07:04 -0000 On 22.08.2013 14:01, Andrey Chernov wrote: > On 22.08.2013 1:37, Jilles Tjoelker wrote: >>> if (number == UINTMAX_MAX && errno == ERANGE) { >>> return (-1); >>> } >>> >>> + if (errno == 0) >>> + errno = saved_errno; >>> + >> This looks good to me. >> > > Just being nitpicking) number == UINTMAX_MAX check is unneeded. > Sorry for misguiding, forget it. The check is needed, other functions inside strtoumax() (FIX_LOCALE, isspace) may set errno in theory. -- http://ache.vniz.net/ bitcoin:1G6ugdNY6e5jx1GVnAU2ntj2NEfmjKG85r