From owner-freebsd-current@FreeBSD.ORG Sat May 22 04:53:25 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9AE316A4CE; Sat, 22 May 2004 04:53:25 -0700 (PDT) Received: from carrick.bishnet.net (carrick.bishnet.net [217.204.9.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7BCB43D49; Sat, 22 May 2004 04:53:25 -0700 (PDT) (envelope-from tdb@carrick.bishnet.net) Received: from tdb by carrick.bishnet.net with local (Exim 4.33; FreeBSD) id 1BRV3u-0006cQ-Sg; Sat, 22 May 2004 12:53:10 +0100 Date: Sat, 22 May 2004 12:53:10 +0100 From: Tim Bishop To: Bob Bishop Message-ID: <20040522115310.GA23999@carrick.bishnet.net> References: <6.0.3.0.2.20040306091212.0366f5b8@gid.co.uk> <20040306221929.37F8016A4CF@hub.freebsd.org> <6.0.3.0.2.20040310112318.03638078@gid.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6.0.3.0.2.20040310112318.03638078@gid.co.uk> User-Agent: Mutt/1.4.2.1i X-PGP-Key: 0x5AE7D984 X-PGP-Fingerprint: 1453 086E 9376 1A50 ECF6 AE05 7DCE D659 5AE7 D984 Sender: "T.D.Bishop" X-Bishnet-MailScanner-Information: Contact postmaster@bishnet.net X-Bishnet-MailScanner-VirusCheck: Found to be clean X-Bishnet-MailScanner-From: tdb@carrick.bishnet.net cc: Bill Paul cc: current@FreeBSD.ORG Subject: Re: Small patch for if_ndis_pccard.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 May 2004 11:53:26 -0000 On Wed, Mar 10, 2004 at 11:37:02AM +0000, Bob Bishop wrote: > Had a go with this 3Com 3CRSHPW196. Had to apply the following patch to > work around a difference of opinion between the .inf file and the card CIS > about the use of underscores: > > --- if_ndis_pccard.c.orig Wed Mar 10 10:27:37 2004 > +++ if_ndis_pccard.c Wed Mar 10 11:10:54 2004 > @@ -134,7 +134,9 @@ > int i; > > for (i = 0; i < len; i++) { > - if (toupper(s1[i]) != toupper(s2[i])) > + if (toupper(s1[i]) != toupper(s2[i]) > + && !(s1[i] == ' ' && s2[i] == '_') > + && !(s1[i] == '_' && s2[i] == ' ')) > return(0); > } > > I suppose you might prefer to fix this sort of thing in ndiscvt. FWIW this patch works for me. Well, where "works" means it now detects the card :-) > Anyway, with the patch the card attaches etc but we get a panic (as kind of > expected) when trying to bring the interface up with ifconfig. > > FWIW, log: > > ndis0: <3Com 3CRSHPW_96 Wireless LAN PC Card> at port 0x100-0x11f irq 11 > function 0 config 1 on pccard0 > can't re-use a leaf (Rate)! > can't re-use a leaf (RTS_Threshold)! > can't re-use a leaf (Frag_Threshold)! > can't re-use a leaf (PreambleType)! > can't re-use a leaf (Channel)! > can't re-use a leaf (Operating_Mode)! > can't re-use a leaf (ESSID)! > can't re-use a leaf (WEP_KEY_INDEX)! > can't re-use a leaf (EncryptionLevel)! > can't re-use a leaf (WEP_KEY_1)! > can't re-use a leaf (WEP_KEY_2)! > can't re-use a leaf (WEP_KEY_3)! > can't re-use a leaf (WEP_KEY_4)! > can't re-use a leaf (WEP_Mode)! > can't re-use a leaf (AuthenticationType)! > can't re-use a leaf (PowerMgmtMode)! > can't re-use a leaf (BasicRates)! > can't re-use a leaf (BeaconPeriod)! > ndis0: NDIS API version: 5.1 > ndis0: 802.11 address: 00:04:75:9a:46:20 > ndis0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps > > (Not so easy to catch the panic, this ThinkPad doesn't have a serial port.) And likewise, exactly the same output and panic. I'm using -CURRENT as of today. I'm happy to try and provide more information, but like Bob I'm also using a thinkpad. Cheers, Tim. -- Tim Bishop http://www.bishnet.net/tim PGP Key: 0x5AE7D984