From owner-freebsd-ports@freebsd.org Sun Jul 8 15:21:38 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65340102F84A for ; Sun, 8 Jul 2018 15:21:38 +0000 (UTC) (envelope-from trashcan@ellael.org) Received: from mx2.enfer-du-nord.net (mx2.enfer-du-nord.net [IPv6:2001:41d0:401:2100::5:8a0e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F35D5793B7; Sun, 8 Jul 2018 15:21:37 +0000 (UTC) (envelope-from trashcan@ellael.org) Received: from [IPv6:2003:e9:7f2a:de01:3487:cc8e:8b17:555e] (p200300E97F2ADE013487CC8E8B17555E.dip0.t-ipconnect.de [IPv6:2003:e9:7f2a:de01:3487:cc8e:8b17:555e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.enfer-du-nord.net (Postfix) with ESMTPSA id 41Nsch3grNz3JJ; Sun, 8 Jul 2018 17:21:24 +0200 (CEST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.100.0 at mail.enfer-du-nord.net Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: beadm-1.2.8: erroneous beadm create From: Michael Grimm In-Reply-To: <5A4EB662-9562-47E4-A436-FAAAFFF524C6@ellael.org> Date: Sun, 8 Jul 2018 17:21:23 +0200 Cc: bdrewery@FreeBSD.org Content-Transfer-Encoding: quoted-printable Message-Id: <92E9643B-2120-4D2A-8A2B-84FC50465DEB@ellael.org> References: <5A4EB662-9562-47E4-A436-FAAAFFF524C6@ellael.org> To: Mailing List FreeBSD Ports X-Mailer: Apple Mail (2.3445.8.2) X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RDNS_NONE autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail.kaan-bock.lan X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 15:21:38 -0000 Michael Grimm wrote: > Well, I do see the point of embedding variables with ", but I do also = believe that checking for a null string and removing that resulting =E2=80= =A6 > -o =3D"" > =E2=80=A6 before applying the final 'zfs clone' command with it would = be a much better patch.=20 FYI: The author of beadm has fixed this issue, and he will include his = fix in the upcoming beadm-1.2.9 release. Regards, Michael