Date: Fri, 17 Aug 2007 09:00:06 GMT From: "Andrew Pantyukhin" <sat@FreeBSD.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/115218: Update port: audio/libmtp to version 0.2.0 Message-ID: <200708170900.l7H906B8013342@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/115218; it has been noted by GNATS.
From: "Andrew Pantyukhin" <sat@FreeBSD.org>
To: "Petar Petrov" <pesho.petrov@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/115218: Update port: audio/libmtp to version 0.2.0
Date: Fri, 17 Aug 2007 12:57:40 +0400
On 8/17/07, Petar Petrov <pesho.petrov@gmail.com> wrote:
> Thank you!
>
> Unfortunately using CPPFLAGS instead of CFLAGS requires the patch
> files that the patch in the PR removes.
>
> Those patches were needed because in some cases the upgrade fails,
> because the examples in examples/ use the installed version of
> libmtp.h instead of the one in the distribution being compiled. For
> example the upgrade from 0.1.5 to 0.2.0 fails because of this same
> reason. Using CFLAGS instead of CPPFLAGS causes -I../src to appear
> before -I/usr/local/include when building the code and then the code
> uses the right header file. While using CPPFLAGS swaps them (e.g.
> -I/usr/local/include is before -I../src).
>
> The upgrading problem can be solved by either:
> - Removing libmtp 0.1.5 and installing version 0.2.0.
> - Putting back the patch files in files/.
> - Replacing "CPPFLAGS=..." with "CFLAGS=..." in the port Makefile (may
> lead to other problems).
I see. This command in post-patch fixes the problem:
@${REINPLACE_CMD} -Ee 's|(\$$[(]CPPFLAGS[)]) (\$$[(]AM_CFLAGS[)])|\2 \1|'\
${WRKSRC}/src/Makefile.in ${WRKSRC}/examples/Makefile.in
I can commit it now if it's OK with you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200708170900.l7H906B8013342>