From owner-svn-src-all@freebsd.org Tue Apr 4 13:55:41 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5EC5D2EEF1; Tue, 4 Apr 2017 13:55:41 +0000 (UTC) (envelope-from kevans91@ksu.edu) Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0052.outbound.protection.outlook.com [104.47.38.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F285A81; Tue, 4 Apr 2017 13:55:40 +0000 (UTC) (envelope-from kevans91@ksu.edu) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ksu.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1tpjkhBIG+I8A8s/jrP2vxgBggD1XSX0/AJgCkIPEn0=; b=WqdSLFA/s5dcEmZLckHBhUeAD+uGsMlRpcgmOEzjGdtPLHuFvEVMbYLuxAPlj8ocXrU/vdJUHhnPvGzuB5lpYB+ydclXY10Y6iv61MYoVa2+Rx3IqZ6cFgkLsU3f7HtF9v6LhHzw78ZcIaY0aoWWDPHEPXxVgEl5bVE5JEfheeQ= Received: from DM5PR05CA0001.namprd05.prod.outlook.com (10.173.226.11) by BN6PR05MB3570.namprd05.prod.outlook.com (10.174.234.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.8; Tue, 4 Apr 2017 13:55:38 +0000 Received: from BL2NAM02FT022.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::204) by DM5PR05CA0001.outlook.office365.com (2603:10b6:3:d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.8 via Frontend Transport; Tue, 4 Apr 2017 13:55:37 +0000 Authentication-Results: spf=pass (sender IP is 129.130.18.151) smtp.mailfrom=ksu.edu; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=bestguesspass action=none header.from=ksu.edu; Received-SPF: Pass (protection.outlook.com: domain of ksu.edu designates 129.130.18.151 as permitted sender) receiver=protection.outlook.com; client-ip=129.130.18.151; helo=ome-vm-smtp1.campus.ksu.edu; Received: from ome-vm-smtp1.campus.ksu.edu (129.130.18.151) by BL2NAM02FT022.mail.protection.outlook.com (10.152.77.153) with Microsoft SMTP Server id 15.1.1005.5 via Frontend Transport; Tue, 4 Apr 2017 13:55:37 +0000 Received: from calypso.engg.ksu.edu (calypso.engg.ksu.edu [129.130.43.181]) by ome-vm-smtp1.campus.ksu.edu (8.14.4/8.14.4/Debian-2ubuntu2.1) with ESMTP id v34DtbQF023134; Tue, 4 Apr 2017 08:55:37 -0500 Received: by calypso.engg.ksu.edu (Postfix, from userid 110) id 5ACF5248305; Tue, 4 Apr 2017 08:55:37 -0500 (CDT) Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by calypso.engg.ksu.edu (Postfix) with ESMTPA id 003CF248302; Tue, 4 Apr 2017 08:55:34 -0500 (CDT) Received: by mail-wr0-f171.google.com with SMTP id w11so214088341wrc.3; Tue, 04 Apr 2017 06:55:34 -0700 (PDT) X-Gm-Message-State: AFeK/H03YR8nyEGwKYx8Da/7WQHX0V09xkmDm8ZdonteN8KUIxCdT9u865F6UVyTC84PA5NNESfZDlIDNTJ+nw== X-Received: by 10.223.154.54 with SMTP id z51mr201770wrb.76.1491314134083; Tue, 04 Apr 2017 06:55:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.39.134 with HTTP; Tue, 4 Apr 2017 06:55:13 -0700 (PDT) In-Reply-To: References: <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org> <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> From: Kyle Evans Date: Tue, 4 Apr 2017 08:55:13 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r316477 - head/usr.bin/grep To: Ed Maste CC: Andrey Chernov , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:129.130.18.151; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39850400002)(39450400003)(39400400002)(39410400002)(39860400002)(39840400002)(2980300002)(438002)(24454002)(377454003)(189002)(199003)(5660300001)(93516999)(63696999)(54356999)(50986999)(6246003)(38730400002)(4326008)(450100002)(6916009)(2950100002)(93886004)(45336002)(229853002)(46386002)(236005)(90966002)(54906002)(498394004)(55446002)(9686003)(53546009)(8676002)(8936002)(59536001)(8576002)(106466001)(61266001)(9896002)(189998001)(88552002)(61726006)(305945005)(84326002)(75432002)(2906002)(86362001)(512874002)(42186005)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR05MB3570; H:ome-vm-smtp1.campus.ksu.edu; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2NAM02FT022; 1:7J3MlJni4TZ9FqSFs1iuxC+uFYFUf1BHRB7Ae86BaVzjy+yF5beurj6cDY5G+MPB3L1J3+Xu9iwnQ3kPP3QGfMIgpa2xzuq0QvKRYfYIMEvuzEfvXGd5kCbK7PBAK7a1wvOWrsAVJyapqngAMtrmXy47eV+u7vtp0P448GSbzftrTc8V9JHEDQN1Sfx2ypcY6WMCYSM8k68PWJ6ziwbHQq2H2UhaFO3HsNvUYUK8TEneI6hFDTct/plyHc0wDJxfsz6N0PnBeIAiG1knLD+PjyUWB5xfiu2H47NjXLKZklaiLLvTAYR6KZRz6u438ctwhXPoDw4fu7SXEPZuZ6p8rmFkwoXqTpd5eLw9rykBkw9CasEv9E2j91vsvOu5eDCF6V27h1dneOjjfms5Cq23SHohs/p/J5PpToZYtFaq/EhN+o3sZICf4N0Rbzhpjtsu/BRGYRK92DU6lZ53+8UCR/aj+J9QP2F70u/L/A8RwkmDQeDyPIv0UIpFBs4vstnK+edWchTKT3jscFVDIZEjpA686EPk1XD7KUCkiZhtU68= X-MS-Office365-Filtering-Correlation-Id: 1071a257-2770-4ed6-d22e-08d47b62460d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BN6PR05MB3570; X-Microsoft-Exchange-Diagnostics: 1; BN6PR05MB3570; 3:ZU7sQpYuTMG5XpaGbcAwe7TfF9tqPqpJWukR4NxjwlShVUtsusqRVSnZlv7nohC/oKNu6TUd0gC4tLEWuEhD6EKvMdWOP6EpBuYo2hOwDNiN6VBxKZU/TIjbI2vPQFRgk3A8Je2zzyqtyBwr2DNl7auQ456KPoRYh/urEAtVYxSHMB34L0hDublitABsLQSC+dTCcjCpj/RRn5UcgDHit8NFxnUETbADhruOK28LjPZD4aWAmWKhMA/Tq/DLsw/vCDx5VTq1XMao36bVVGT1KuAYSsLTJpFjUCqvsvqURN2Bek6xMOjtucgGIv3H2qmkJAcocg8h2r5ab3MkxAvXmlD9yC1r+PHo7HUHin6UG+lrxAgmfabjjjH7sN5HOelvtKFaoZsf1KGLrhcXKnxq681GIzHYLKwY1VZRWgZsKWQfHVlHBkPTC2J4xD8/RwIFBqiJdVAaun/HZ7AtJvLhaat/Tw8j2IZNss+MfSy+a6bSBpxSiHm/PQ/yS2+AQ9+TSnivzKE29bqtnNhYBmoXtg== X-Microsoft-Exchange-Diagnostics: 1; BN6PR05MB3570; 25:EwUvId/AjS6D8rVD3QhS25ZJPWFlzD+6ZVZIHWeppczZxMVBylUUWNU3dS1iqmhsMLDroyIBwNUt72IcOEUuWNESUXOPESq2h7bCiYoM3vz2mXWU29KOgmuW3IRzTLuK7HtwqOyUHCg9w5yTZOgNhPoLdFZf08wYqzIsWkpsJx6l3KJkjP+rcy2vANwHnwFeZcwv32lL1tTHyYEUEgo1hXD+lfYJ+7jJcmbu5bDhO3eFBVKQNhdKjGGI1WiiHIwn9C9UwikEeMldTBLEsMk0TTOfy2VU32X/1zbQLeBEIkAeLVPKwO/CK24eHwIeSC/nFNwKRbg7K7rq4DSrvN58LfzLi6eq0bPDwk6Ydkb+FOzXu+37v01HO+xaitSl1UDA1+iCMgPT/50Szyjs+dL2Rv7QoZwop7xO5zImIusewRsW6QPLJgUo0ZqtsDUZu3FzUL2iKZwzfoqQ4LrPqSG2lA==; 31:AGQXI+HIKCdeo6sdY980bykavIY+CpZsHfhWDDW+RTRLQl+CNkRwJvcshsnriBMLReF8lQ6/YzUXRk0iBJoYQh1Z4tAzL56gqyUk2XrO28y/U8/E1KrEfcSezQm9W7+AT+70sstSoanj8Tke4QFk8qCf/q53m8j68tVNeu1s7OPESHgqFE0S4EoAIjuGT+ZyYex6j/jl4brldDGLFnZ6lGlH3nyI0Pl5o3W1283A06nYSizICy42s5gTm5i37J+IQKrLdH0FEL2uviWfh/iLE07xfvy3pGDgP/g0CXK6DOQ= X-Microsoft-Exchange-Diagnostics: 1; BN6PR05MB3570; 20:9jYGX+IdT3erlCsJtGbtAR4Ct0AQIQwTcmthtySmPJDN58NUqa1cuLjeGCUE8zO01mUh9aOyKbwl8W2rJB0zaWvAvGFfrYlr1zRU6MKXR7OteN9kIKzXiTiqtoBYewew+yJMAKnuWfm5+vuTDrUk+PGQZTK4GvHHeF/IEwFiCwKzhELB4P4TJre9LSoHMuoqzvOOjoJz79eURcQkLoy1mwrL/58foY8jT4yEl4lc0egRo43Thk7/6ExMWBG6hda+o1aNCD6c6Bqf51sj6wD7bs1Qp77cwuCUgVQqkZ81ngkWUL6I0YMgenKZSndKAzuRr2rP+dqn6DQIx5QO+RgnZWwtU2XCFIStR6kwknYeZzD2pocYYrLsDG+FPRjcDTz4A6qshL4LBqSQR/IN5IGridXN6iOLyKNTfoORyRxtxAECPfvuIwr16DPjFcaGXPScdLxVRHZYj81983iWej2gNEXw3jsh3Ipc9o3pAk7ohcoN7dCkMlgxbnUffWkWEntA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(13017025)(13015025)(13024025)(13023025)(13018025)(5005006)(93006095)(93004095)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281529075)(201702281528075)(201703061421075)(20161123564025)(20161123555025)(6072148); SRVR:BN6PR05MB3570; BCL:0; PCL:0; RULEID:; SRVR:BN6PR05MB3570; X-Microsoft-Exchange-Diagnostics: 1; BN6PR05MB3570; 4:c8sFQTvHkbvrTOQIQHcG4IWPdxAJGbrzpTdC4W2Pz82GCr/gWNntOGRCD2z9rsvDtD9D/oykZ1jzHogiimuzl6sL6op8EaCaos2awHMQ1cVwZm6MiVSxm3jWLQvqMVqFNuilOcZZuB4la+LF9I/dEVEZ3KRRNXGndAN6ccN/qUfWb1zWEQX1il5MKIgYRnZ8vht8l1gUuY9x6uFpTrPwmlX4yJVi+3H/y23fzrTzPzoDPk6PneijX21VKjkIEaW0t9Z5fwJAcHB1QDkA6eSvyWmvisuFyjt4HKDkcHO440YLMj9wkuKlXFPcpF4vqnFivobG+6zK39FdLav84eWDyqGmZTD0YJ99KHwEyCxs1HO6P2pGUeupf3jJFLdiJ5MMFrxd5JTCrRf4amoZ7+mxwPjS8TDL5c1IGeIOXoDmHvj0jTbdRatNonGrK55qh9HHnZuGhveL4bkC/Z66QwZZimhQmFw4KcReeta1g3albIMR8Vf6rr7zgxaW3FiwTcLuJ4bZQl8rnyEQ994DRDq+phrzU7shx1yIKq+nZv0NL3hEj6SDlemM/DCL0HK4gU/JixDD0i7tQHR57sJveRFyZS9qR39y/ZuDGNnbW+FRtDJ7qUWZD5SEhn3dxZiNtdW2MykOmzaSofBz/iN7sA45lfwEpIEPV91zM/4Z9Zs0L5TWmiqKg6UqPfZui5W6L8mozn6hTHgKwjVm+hQMPHRbdtNaVIm6ypUejIq/JQigZBDvtYVwiTUgWuzzSG5CgGpogY4ggD+joBzXtoeKA+3RLGg/UdnJ+JvkYwwciqd1DnuUCQyuVoq6UpcKoGY8c1sA9dvHa+d5Sa0atnAMX00Gvw== X-Forefront-PRVS: 0267E514F9 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR05MB3570; 23:P9bKsTe9xvRlD0K1OJi75XjVyFw5liUDpbjFBPSYi?= =?us-ascii?Q?9eiqM+jjndZNrABLnScet9jeF/K5RFWj5oFMpSf9lql+0tF6BnV4ecpHbols?= =?us-ascii?Q?INjP+M2X8ofGU9iJn34A47024YYEc5R4eZKteJ9eijNTnjHa50LoMPBIcjYv?= =?us-ascii?Q?aYE6jW9PWonlRQ+Hb3Lj+vsfn28uCMHfeUfCSFYnm9DWGYsXmbK9LqDKU+3J?= =?us-ascii?Q?699lEwp4YrtcgJ52ycUMnLopfP9fVTDlzQ7k0kBZ3XlvhbVy8bgb3ZoNEp7U?= =?us-ascii?Q?J7reUTlJ/fS0Bt418uJpKr/PW29UNCqvPNXiUX7E6D/gjn/E+G23ZrYVTWmV?= =?us-ascii?Q?MxemMzvq6bK1Cl+f4AYIVVVSlYKhjkFs4wPTFN3pcPVjSbiBY6pxaX4fk8KA?= =?us-ascii?Q?kma5wbbrFef8mmppaUkGrNBqnuR+99R3e5jrCP70g3KkOVOpQ44uHbjcdth3?= =?us-ascii?Q?zFc/SjJVHajJ8ulM6dDpjiLRDtqoecudMAE4B/JhXbJa2Hb1laYg9JgTvoKo?= =?us-ascii?Q?Qx3/mlTrVNyEm5jPRkczp4uTYj5KSvGgOOhB4z+mb5Amuqf6abeTc/VFVV6G?= =?us-ascii?Q?c0ewYcB8cK+dHMiabP1cB/WXAegqX325pvApTmFGo3b8m5ioNed4+Vk1qk9t?= =?us-ascii?Q?SVdehukPW6RCyFcyTJLkdBnQmhc1jCCgS6oD3754MM9+1Qf7GbvpFORe0cC6?= =?us-ascii?Q?qAIuNofdykw7N4sGDwYY3bgWZU7cwhWmmdruWia3BeSvGehDL4ceqS6e0TDP?= =?us-ascii?Q?m1NdzxAh81Wvj1Oik6z0eZbooBCKs1Ca7Jf2pR5q/zLpiTOMa3B8pqnEQmzn?= =?us-ascii?Q?WkizBT9qiYXkYOo85IwxgqwrnN8PrEgAy/6iXu72HVU3Gz7bc+/DIbSI9CUt?= =?us-ascii?Q?bhHG0Imh0MQES5PL+eBO/uO2X1HaLd1yvJNk1c3SVE1roNDE9kE69TusWTFW?= =?us-ascii?Q?KUiZ/5xVdBS89vBSiGmoaUNdDEBezHQUdlmTddMogzFtgSaE1KpbrL/qUIEI?= =?us-ascii?Q?mjkpbNJYj1gxUvQx09KtR9Fqd8rrU6jYRYvNDkEg65dAf3s+PQEUEg6rrCjK?= =?us-ascii?Q?pVr34vy399GPj/kO13vFfUxDqJtd1MB14O/WcmcTaNcSjygf+OmANLzfEaTz?= =?us-ascii?Q?0jG/faWxzqpHpzU48BIMBIa7ecSg0pTLDWFmjr+sfyJtXxIblAuW89AX14q/?= =?us-ascii?Q?8xeurYDfEnbTzaxeiwnIqhGe49iK2elZsfrL32HNr+CUybqBqqLpbD1XAxvo?= =?us-ascii?Q?oezGhA0qslbt/+ZEdL3S/poSO6SiiLcj4vEvFc+?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR05MB3570; 6:+WV4Wbr6H3dGCxBi+R3N0HE7t7Ilx/zcYMkWA7EKoKalvvbMXF6G/bSLGPdM/t+D1zE9ynsxavut30yWDF8dVWZnG1dIWzGdr8GbDlaDIIU0n5C8rW5+Jp4DIxTwSxRETxniC+vl40apM3Po+88sYcSLcxfAzwsAJP9LqLvas/vfWXd/kVuiWqhXFCIdoVcHhLnVWqOkmbo075ups0uYia0P/OBqIm7IkPqDL5SNX4S62WnC/6f3kdBPTNwvW5b9eVseW086e0KmTEfk0aTht9qAPjU9EvNc0A/Kp79QIV1VwjpLVQHqA0QyLNvKp6JdhCoHP6LRXNu2BBs+4TRyhKMVoaRPUm3ABawwchPM2rRYwFjuf2zfuJjjssOrbgfXQfLjLah0WZhpahHKfm+z2Q==; 5:x0rQL7qLYZrFevIyuPidsj7jN1waXSJLnHC9+XNcwD5A7nTRXPtpx4kPjvqjOkuNqs2C7O0kxYpOPC8+wWYzs0fg1ngD5OWgS3gQ3Pn+oKGTzvITl1IggCklGzUlK8Hf9eCzR0/8BeUD1l1TcNZ19w==; 24:MBPg+Yzd6V0Q64s7HgoTg6fZqJZVZFW3albbPvOcJNLzS1ZIDbTxuUDw2/XIPIDSBOxwEpxGCj4nNxn0gK9eqg7SlzbhPSbLQmsj7ydVG/Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR05MB3570; 7:D4KR0dmjCE2Dc3+RSkyQp4p/qAOkPwXboeJrShEbE8e7kB1RpEsNQRgigwD5PoEl9qYJKiIzhtpsHY8jQtYobrUrtyzIvlr+cZLidXkidXZaokAqEMPOun5aKgoCSItz3QfGtDDNjXJy7ZPIAvDR6ZHT8PgRG0DGA79MV0NasyiwCI3S6eyH/BKzUprbyliMLZ8TlKMP8I/JVVLFUoxaZ3f63Y40pDdgusDq7NjUuSsqiYhRuheBg0HFV6O6rMXLQGYsDQ7reH8BK2Kw2RDEmJjh50GvCOE+O9glLSdwoe2b4eDsaOwyH+GTZ1SmCZYHRWiLLY5RlsPe8OiUtme8BA==; 20:gAKq4cZnBxOwnopg9wCemWSdZn2j21OOMFFK1GfjMj9YDwhmnnH7PLA0b5xFDdslEtKNrQrqHoRaRwbpndtkvnK9OEkEYvhSil9WYHRUJoLbx6zrO0LPVMJmVoa/Vt9nST2kuhLWl9wdIyxwgbGSiQkazUGniOrQMpUiatg0tpw= X-OriginatorOrg: ksu.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2017 13:55:37.6998 (UTC) X-MS-Exchange-CrossTenant-Id: d9a2fa71-d67d-4cb6-b541-06ccaa8013fb X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d9a2fa71-d67d-4cb6-b541-06ccaa8013fb; Ip=[129.130.18.151]; Helo=[ome-vm-smtp1.campus.ksu.edu] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR05MB3570 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 13:55:41 -0000 On Tue, Apr 4, 2017 at 8:53 AM, Ed Maste wrote: > In this case I'd rather we remove the 00 and have the test verify > that. I think it's fine if there are a few tests that fail when run > with GNU grep where it has the undesired, differing behaviour. > Excellent- can you please revert this entire bit then: @@ -474,13 +509,13 @@ printline(struct str *line, int sep, reg fwrite(line->dat + a, matches[i].rm_so - a, 1, stdout); if (color) - fprintf(stdout, "\33[%sm\33[K", color); + fprintf(stdout, "\33[%sm", color); fwrite(line->dat + matches[i].rm_so, matches[i].rm_eo - matches[i].rm_so, 1, stdout); if (color) - fprintf(stdout, "\33[m\33[K"); + fprintf(stdout, "\33[00m\33[K"); a = matches[i].rm_eo; if (oflag) putchar('\n'); I'll address this in the unit tests review shortly.