From owner-cvs-all Thu Nov 28 17:15:24 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AC0D37B401; Thu, 28 Nov 2002 17:15:23 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id A618443EA9; Thu, 28 Nov 2002 17:15:21 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id MAA07262; Fri, 29 Nov 2002 12:15:13 +1100 Date: Fri, 29 Nov 2002 12:28:53 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Alfred Perlstein Cc: Mike Barcroft , , Subject: Re: cvs commit: src/sys/sys select.h In-Reply-To: <20021128171321.GO16066@elvis.mu.org> Message-ID: <20021129122620.F15170-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 28 Nov 2002, Alfred Perlstein wrote: > * Mike Barcroft [021128 07:38] wrote: > > mike 2002/11/28 07:34:32 PST > > > > Modified files: > > sys/sys select.h > > Log: > > Fix the standards case by referring to __fds_bits instead of fds_bits > > in FD_*() macros. > > Are we going to do a sweep where we prepend two underscores to > almost everything (for namespace protection)? Do we need someone > to do it after 5.x and what is the guideline for doing it? Hopefully not. Underscores should only be used where necessary. One underscore suffices in most places (but 2 may be used for style reasons). __fds_bits is a special case (1 underscore doesn't suffice because this name is used in a macro). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message