From owner-freebsd-arch@FreeBSD.ORG Mon Jan 9 20:22:20 2012 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E26F51065672; Mon, 9 Jan 2012 20:22:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 6204A8FC0C; Mon, 9 Jan 2012 20:22:18 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q09KMFNP059559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 9 Jan 2012 22:22:15 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q09KMFR3054492; Mon, 9 Jan 2012 22:22:15 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q09KMEgo054491; Mon, 9 Jan 2012 22:22:14 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 9 Jan 2012 22:22:14 +0200 From: Kostik Belousov To: Yamagi Burmeister Message-ID: <20120109202214.GZ31224@deviant.kiev.zoral.com.ua> References: <20111226220756.GR50300@deviant.kiev.zoral.com.ua> <20120102063700.GF50300@deviant.kiev.zoral.com.ua> <20120108174112.50e030ba.lists@yamagi.org> <20120108195913.GI31224@deviant.kiev.zoral.com.ua> <20120109103747.578d4e44.lists@yamagi.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9C8JZALFROMdO0HE" Content-Disposition: inline In-Reply-To: <20120109103747.578d4e44.lists@yamagi.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: amd64@freebsd.org, arch@freebsd.org, marius@freebsd.org, flo@freebsd.org Subject: Re: AVX X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 20:22:20 -0000 --9C8JZALFROMdO0HE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 09, 2012 at 10:37:47AM +0100, Yamagi Burmeister wrote: > First, thank you for working on AVX, it's much appreciated. >=20 > On Sun, 8 Jan 2012 21:59:13 +0200 > Kostik Belousov wrote: >=20 > > > CPU: Intel(R) Core(TM)2 Duo CPU T6670 @ 2.20GHz (2194.55-MHz > > > K8-class CPU) Origin =3D "GenuineIntel" Id =3D 0x1067a Family =3D 6= Model > > > =3D 17 Stepping =3D 10 > > > Features=3D0xbfebfbff > > MCA,CMOV,PAT,PSE36,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE> > > > Features2=3D0x408e3bd > > PDCM,SSE4.1,XSAVE> > > > AMD Features=3D0x20100800 AMD Features2=3D0x1=20 > > Is this Features excerpt from the patched kernel, or from pristine svn > > sources ? If the later, please show me the Features from the patched > > kernel. >=20 > That was the output of the patched kernel. I see. The issue was that cpu_feature2, which is decoded to print the Features2 line, is retrieved much earlier then XCR0 is updated by fpu initialization code. I added a cludge to reload cpu_feature2 if XSAVE was indeed enabled. So now you should see OSXSAVE reported if XSAVE is indeed enabled. >=20 > > I thought that I correctly handled savectx, but apparently I did not. > > The issue for sleep enter could be fixed by the avx.4.patch, I am not > > sure about shutdown -r panic. > >=20 > > http://people.freebsd.org/~kib/misc/avx.4.patch >=20 > Both panics are gone. The system goes into suspend just fine and even > resumes. And no more panics at reboot. Very good, thank you for testing. I decided to avoid use of __fillcontextx() for !x86 architectures for now, since nobody seems to know what happens on sparc64. Florian, can you, please, retest the defer_sig to see if it works now ? I hope that this is commit candidate: http://people.freebsd.org/~kib/misc/avx.5.patch --9C8JZALFROMdO0HE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk8LTHYACgkQC3+MBN1Mb4jcFgCeL5DpuUjELfEVHpjT3IS9h3VE hC4AoM/xGLzjJD04zenoDKCWjlYwFLCy =++UU -----END PGP SIGNATURE----- --9C8JZALFROMdO0HE--