From owner-freebsd-bugs@FreeBSD.ORG  Thu Mar  6 06:00:02 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2BC451065672
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  6 Mar 2008 06:00:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 0A0618FC26
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  6 Mar 2008 06:00:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2660157049732
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 6 Mar 2008 06:00:01 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m26601Fu049731;
	Thu, 6 Mar 2008 06:00:01 GMT (envelope-from gnats)
Resent-Date: Thu, 6 Mar 2008 06:00:01 GMT
Resent-Message-Id: <200803060600.m26601Fu049731@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7824C1065670
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu,  6 Mar 2008 05:58:57 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 68FEE8FC27
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu,  6 Mar 2008 05:58:57 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m265ts56028744
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 6 Mar 2008 05:55:54 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m265ts1K028743;
	Thu, 6 Mar 2008 05:55:54 GMT (envelope-from nobody)
Message-Id: <200803060555.m265ts1K028743@www.freebsd.org>
Date: Thu, 6 Mar 2008 05:55:54 GMT
From: Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/121418: ruptime does not show correct information
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Mar 2008 06:00:02 -0000


>Number:         121418
>Category:       misc
>Synopsis:       ruptime does not show correct information
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 06 06:00:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Atsuo Ohki
>Release:        7.0-Release
>Organization:
Univesity of Tsukuba
>Environment:
FreeBSD smr01 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Thu Mar  6 14:39:27 JST 2008     ohki@smr01:/usr/src/sys/i386/compile/GENERIC  i386
>Description:
ruptime command give "no hosts in XXX",
while it shoud be.

>How-To-Repeat:

>Fix:
variable `now' is used without initialization.

--- ruptime.c-ORIG      2008-03-06 14:57:39.000000000 +0900
+++ ruptime.c   2008-03-06 14:58:07.000000000 +0900
@@ -191,6 +191,7 @@
        rewinddir(dirp);
        hsp = NULL;
        maxloadav = -1;
+       (void)time(&now);
        for (nhosts = hspace = 0; (dp = readdir(dirp)) != NULL;) {
                if (dp->d_ino == 0 || strncmp(dp->d_name, "whod.", 5) != 0)
                        continue;
@@ -239,7 +240,6 @@
                        warnx("host %s not in %s", host, _PATH_RWHODIR);
        }
 
-       (void)time(&now);
        qsort(hs, nhosts, sizeof(hs[0]), cmp);
        for (i = 0; i < (int)nhosts; i++) {
                hsp = &hs[i];


>Release-Note:
>Audit-Trail:
>Unformatted: